Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <abd63588-d45b-9d1e-5d1e-b095c8112793@nvidia.com>
Date:   Wed, 16 Feb 2022 19:18:03 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH v4 2/4] mm: Rename zap_skip_check_mapping() to
 should_zap_page()
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        "Kirill A . Shutemov" <kirill@shutemov.name>,
        Matthew Wilcox <willy@infradead.org>,
        Yang Shi <shy828301@gmail.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Alistair Popple <apopple@nvidia.com>,
        David Hildenbrand <david@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Hugh Dickins <hughd@google.com>
References: <20220216094810.60572-1-peterx@redhat.com>
 <20220216094810.60572-3-peterx@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220216094810.60572-3-peterx@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2hBbWZhbndRT1lGd202bFVPRlNDdzgrYm5RQXV0ZFpMSGRvRHYvZHloSDlI?=
 =?utf-8?B?ZXpubWpib3hlRVh0Ty9xUGxVSkFjRDF5ZFdOdzRSVTBxWHlJcys3aTRNMTJh?=
 =?utf-8?B?a3BWRFd6MHlQb3lHNUdhby9UZjBWbUFVQVY5aWQzWS9tdmkxS1lFdzJjVW96?=
 =?utf-8?B?NDk0VnMrK1kxdHZ2OTluMHpGNEhUWVo3eHZjYXYyVURVaENUVFR1ZTg2aGdl?=
 =?utf-8?B?Nkx0VXhaVmoySGk4eWxVNll3UG41RW5ycjFnbCtkVkM4bEtxM1dBcCtaYVhq?=
 =?utf-8?B?ZFQ5SDlhVUV0cTFpbGFWKzM2YUxxZzF0VTlnT1M1OE5LR24xYVFGUjNLWElM?=
 =?utf-8?B?aXNrdHoxcVM4bE9URlIrQTJHcjhuemZuT2kxb3EyL21HUHUwOTdja0NmWlFT?=
 =?utf-8?B?aUpPTEtYUHBIUDBCL1QwS21ucmJxVFkrSGpldWxDQ2lzRGpBeHdaeDdDTVhY?=
 =?utf-8?B?V0wydXp4eEtGZFZGZEtvbEpiNS9pZHgrdy84MUhBMzEvNExyTDA5SzNZZmZF?=
 =?utf-8?B?L1RVdEM3OTYvbVFFUTZoZWJ5Yk1vL2dFSDRIZlJPa2wxcXdlSGtacVdsTnUx?=
 =?utf-8?B?QzNLNFAxUUlNQ2hrcDV5Nzg1VTN3V0s3Smp0UGF1T09aQmZ5V0o3c2l5MHRM?=
 =?utf-8?B?UUwwWXU0QzhRNkJzcFJzVXFmY0lPZHJTT3YxVzhmVysrU3ZjOExDa09neE4r?=
 =?utf-8?B?NWVvZWtTaWJGS2ZzWU9BRzhMQTRXenM4VDhtaTU4NGlKTVJBc3A4L3pDVmJU?=
 =?utf-8?B?K3NETDYrWEdtMW9LR3NuQlVFZWpyYzVBbjNsNEJpbVBhemVjQXJHTmpMczNT?=
 =?utf-8?B?b3MrazRWbGhOU0R5Q05abjBBaWdGNE5wQVpSbWd0dTZ0Z3IyK2ZsUWNtSTlV?=
 =?utf-8?B?OVhGc2wvUy95eWg0dWUyZk5kL29JMFcrU0R0Tm9PR1d0cTJjQWV2U3N1dWZL?=
 =?utf-8?B?V1N3NG14dXBNdlFvbU53Z0JQVm8wS1ExSVM0Mks2dUVTeCtWeE8vc1dERUk3?=
 =?utf-8?B?TGVlamxWMFR3R0lwN2x0TzlRaVNPNGNBUE0zMW1uWGpRLzJnT29CMTNJVkZI?=
 =?utf-8?B?QWNrdHhqZ21RMlhEZCs5WGlLSmpQNG02VHNKUFM2Njh6NThCcGN5OXh3dzI3?=
 =?utf-8?B?eDlHT2IwTGFnRzFzTElTS1NaRndzZlRQLzFGZlMzVmVwZW9KUmlTb2NkRUti?=
 =?utf-8?B?N0dHZE5tQUR5WXozTkJ5ODBVTDV5dUpkV3ZmZ1crSEgzSlJRUWRncXJrOXA3?=
 =?utf-8?B?NEZ4T1ZJTlFDOXNmSEp3TnY4T2FTTmVaL1RXNGJSTHAvaFdnOUdVMlVxcnN5?=
 =?utf-8?B?bWpOT0tua2E3VlY3SWdBa24xMncxTmFHQ2VERFVSYUlSVDVqTjJLcnJhRjBa?=
 =?utf-8?B?NlpJemd5RkF0cXRhdnphUzBYcFZ0NjJTQ0lYWVRnclVZSEtrSDlsN01HOFBn?=
 =?utf-8?B?VXNidFVkdDNteWJlMEFxTE9KcHgxcHhvWVBKWjZqRndyR1JKQ211MzlnNmdL?=
 =?utf-8?B?U0gweUtndjl1VHRjMHpLSjlFZnJ0RTFrRis0dC9QNDJJb3RQb2VsSXpPSlBD?=
 =?utf-8?B?WVFqbUk4OWZaci9Yc2Zjbm9PNEdGUHFhL0pIRDBqeENQbElJT3lXaEZHMFFK?=
 =?utf-8?B?OTYrektKMi9pTzBuYTN4bnJrSTR2NTczdUE2d2EzU0hldFBqWDVkWHZnYWpO?=
 =?utf-8?B?YzBncmd2OVRhMit0UytWbm9YblFSY29rMkpadVJQR2hERnlDUFVpclJuMTFO?=
 =?utf-8?B?bXFVYjJzaElSNXhvVzRSeXZ4UVdxeCtFOEoyVzlDNllaUEs2anhEcUgzbzhj?=
 =?utf-8?B?MWp0UFAyRFhnaXEzdWlpelI2MnhJeG55L0djL3Y4MHRNdGhjMFJnbmRTdFpV?=
 =?utf-8?B?VkY3Sk80MTY1aFJTYXZxMnpadmZ4N2V5Mk82VDJDVThNWEdwdUJ5dmtXUmpM?=
 =?utf-8?B?d1ZBNHNCekE2Q2I2cG1uZkdmUkdJWEpzSTlvVlBoS1V4N2ZJbFBWcUE4bEty?=
 =?utf-8?B?SG9VcDVtR01tdmNjVXdYRDViR2tOMG5oM1h3U1JZcW1XOUhTZWNoUi9LbkxG?=
 =?utf-8?B?N09jZjlTczh4WjVSTk83WURRQVg0WW1HUHVLNkpPWExwa1pqWUtMZk5LSTZ0?=
 =?utf-8?B?Z2dNSko4dWhmd2ViL00rV0VJRE9tV1R0UzNWcG5wNWxZU05yclhPcXo0cWM0?=
 =?utf-8?Q?gkMi5eNBDrLKbEAwtIpamlc=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6059696-8e03-4484-d2a3-08d9f1c41d83
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 03:18:06.1791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5fKSkIR+CSIyCaTRAYQtmCtxXfLSVwefDB2Iv120pXwHD86/pSR9Trd1F7EnIAHd9XnyHSpWbS5JtQSQWpyxlg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3522
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/16/22 1:48 AM, Peter Xu wrote:
> The previous name is against the natural way people think.  Invert the meaning

Definitely. 

> and also the return value.  No functional change intended.
> 
> Suggested-by: David Hildenbrand <david@redhat.com>
> Suggested-by: Hugh Dickins <hughd@google.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/memory.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>

thanks,
-- 
John Hubbard
NVIDIA

> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 4bfeaca7cbc7..14d8428ff4db 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -1326,20 +1326,19 @@ static inline bool should_zap_cows(struct zap_details *details)
>  
>  /*
>   * We set details->zap_mapping when we want to unmap shared but keep private
> - * pages. Return true if skip zapping this page, false otherwise.
> + * pages. Return true if we should zap this page, false otherwise.
>   */
> -static inline bool
> -zap_skip_check_mapping(struct zap_details *details, struct page *page)
> +static inline bool should_zap_page(struct zap_details *details, struct page *page)
>  {
>  	/* If we can make a decision without *page.. */
>  	if (should_zap_cows(details))
> -		return false;
> +		return true;
>  
>  	/* E.g. zero page */
>  	if (!page)
> -		return false;
> +		return true;
>  
> -	return details->zap_mapping != page_rmapping(page);
> +	return details->zap_mapping == page_rmapping(page);
>  }
>  
>  static unsigned long zap_pte_range(struct mmu_gather *tlb,
> @@ -1374,7 +1373,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
>  			struct page *page;
>  
>  			page = vm_normal_page(vma, addr, ptent);
> -			if (unlikely(zap_skip_check_mapping(details, page)))
> +			if (unlikely(!should_zap_page(details, page)))
>  				continue;
>  			ptent = ptep_get_and_clear_full(mm, addr, pte,
>  							tlb->fullmm);
> @@ -1408,7 +1407,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
>  		    is_device_exclusive_entry(entry)) {
>  			struct page *page = pfn_swap_entry_to_page(entry);
>  
> -			if (unlikely(zap_skip_check_mapping(details, page)))
> +			if (unlikely(!should_zap_page(details, page)))
>  				continue;
>  			pte_clear_not_present_full(mm, addr, pte, tlb->fullmm);
>  			rss[mm_counter(page)]--;
> @@ -1433,7 +1432,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
>  			struct page *page;
>  
>  			page = pfn_swap_entry_to_page(entry);
> -			if (zap_skip_check_mapping(details, page))
> +			if (!should_zap_page(details, page))
>  				continue;
>  			rss[mm_counter(page)]--;
>  		} else if (is_hwpoison_entry(entry)) {