Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Feb 2022 16:31:19 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Daniel Vetter <daniel@ffwll.ch>,
        Andrzej Hajda <andrzej.hajda@intel.com>
Subject: Re: [PATCH v2] drm/bridge: Clear the DP_AUX_I2C_MOT bit passed in
 aux read command.
Message-ID: <20220217083119.GA3781632@anxtwsw-Precision-3640-Tower>
References: <20220217082224.1823916-1-hsinyi@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220217082224.1823916-1-hsinyi@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bvNxYgzE8YMT/qAhi/AQpf2eyME6hxtwN+c29MJ5l30m6f2lmomVGPVEopa9?=
 =?us-ascii?Q?hCaEm0SemZlcFnKhf04KwJvo+Jy+YlZjXdwsLBGqHbRkxjp3zMRrsTZM0aKa?=
 =?us-ascii?Q?yxioy1UqA/+rdrmzueTfC3iGbQhVuGS2al/y35I2vT/kubFtq2kqw5y44iOC?=
 =?us-ascii?Q?Ei5LHjgdmH0xPhdjBIGTERlLXl+aOuW1Nb8AWtpYTbxwW9AglkYdJf1XddP1?=
 =?us-ascii?Q?58yP+cGt2yrARida70/OVnWyHZKO8EVwPfFs1XiGEYjlZRCajkWdtVvhUgo4?=
 =?us-ascii?Q?Dspl0IvOwGpqr6xomrUR5VdEq2RY95jKE7ac1RkAWeFl0yzHrotcrNtnuR/i?=
 =?us-ascii?Q?JmVLvzLEPijHQEF1P1+CZ/PaWgmzL95I/hyZaIbguyiCl8M1IaDVFsrZXPsN?=
 =?us-ascii?Q?5QW9q1RPeKUvEu8pFcAGPteXv+znE2zztxihprLMmEgDSf380HWwaxCWU47Z?=
 =?us-ascii?Q?VMjQcPir3BgyfzauvK+6ys7K6rJFC5eB6mahzW4NRgdjivaZMeSNJRucYg6H?=
 =?us-ascii?Q?ptFMZ0Py4LK6sFITuO7KTl7GTKBggCwL8mxUovG2x8IBehGxKsWgaxSdDOQP?=
 =?us-ascii?Q?zDWdsAeXxRes0XSEvh3TmBSTahy3Hz+8paQ8Ss44aC9ksSiZJ4l0/FUE0Bty?=
 =?us-ascii?Q?ittrRv7xNclnGgOslKDPkxefAfd7u34rZcCtZ4cBTVugCMmKyuYscWb8yldk?=
 =?us-ascii?Q?bDNbhZD4edSxXZnV6QVoUBOhVmD4LgqPVHRlbrRFsp3Zp5nwoC+IbtOKmhHP?=
 =?us-ascii?Q?HrxFHBN7XuW59AfuL0VXlLGf5VJxxZAoOeyMCUrU600PyS4HbLfML/5mWh//?=
 =?us-ascii?Q?ACpwccZMhVcxaWIK8weFdnXUn+U+jhmNBj3jhYoCUD39yvWxX3cauX6pSGvM?=
 =?us-ascii?Q?XwcdBR9LbGl5/aDO2/lxnlcWXWoSEh+FBHZkwEQEueV4r2NGD0e8EE2vBwlZ?=
 =?us-ascii?Q?NBC9M5AutKMCSb7qwVD/1u7m7rZqCidi1Qy09sdCNafYMAA4KYHTio624G8D?=
 =?us-ascii?Q?HEmsFa8V6eLnDvrr+LbZVfCp2R+uXEFPkdti2F0kvx6DTinv3FNR17PiNTbL?=
 =?us-ascii?Q?Nd7umM7kC4zz9qAMeBEWKk6TGBPiX0QulSce6niE9Lk3Fz0j01nJzK1VZPT9?=
 =?us-ascii?Q?20mgwNFOSY/X2+sixCwOcQXBQ0InEm0mSQz839Yn3AtZfTULRcyOXrkughYj?=
 =?us-ascii?Q?rpc5u5rDj7VOUB6Gz9RiaK2Ca9hheDHMzVZnZid0tEk3pQllKd3pqOk6hVA1?=
 =?us-ascii?Q?KTi4mTDbpHlYwwPnUXEbewEAowkSf7v/KdwZqCsiPjnQCCBK3EU4SbjOC/S7?=
 =?us-ascii?Q?E51O+1mERGhw+wP3lNyLrPwWaH1RS4xnW5Mpntcd2+Ae0ZJrTrGviE3iqLCY?=
 =?us-ascii?Q?wk3om7H2Hrrb+J2hI54UN0/vUUj4QtLKAAd/1NJnXpe8nACrPKtR5nj4l2ke?=
 =?us-ascii?Q?hMQBvNnbZgIlXDR/lEahAuX8rOHz7TgpGsx0bjrSGGSWrUV6KHoMy91QWWTQ?=
 =?us-ascii?Q?cLDzf6/s7L1c0a3rnIYI/6IHlr2hC0A2Z9GDRjXRA3T/IyCbPv9FU+GZgj1k?=
 =?us-ascii?Q?Z7mdhgltCyZ2lTG6dpclBFVT7vSyHv69ocy4utZP3oSZb9AP1ZBiGEQE7LeY?=
 =?us-ascii?Q?b/h4hCjT6MCOhh1t4mm5QZ4=3D?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 31049ef0-5f24-4211-6451-08d9f1efe21f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 08:31:24.5945
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LpSr51ToepN4SNsGt/UH2GjjZ/wVE2Ce5h+ttmh5F8zeZj6EKVKIyGMMTlGUEAmw/HJAMQQVqh7sxztMXZRv3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0401MB3697
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 17, 2022 at 04:22:25PM +0800, Hsin-Yi Wang wrote:
> If the previous transfer didn't end with a command without DP_AUX_I2C_MOT,
> the next read trasnfer will miss the first byte. But if the command in
> previous transfer is requested with length 0, it's a no-op to anx7625
> since it can't process this command. anx7625 requires the last command
> to be read command with length > 0.
> 
> It's observed that if we clear the DP_AUX_I2C_MOT in read transfer, we
> can still get correct data. Clear the read commands with DP_AUX_I2C_MOT
> bit to fix this issue.

Hi Hsin-Yi, thanks for the patch!

Reviewed-by: Xin Ji <xji@analogixsemi.com>

Thanks,
Xin
> 
> Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux channel")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
> v1->v2: Offline discussed with Xin Ji, it's better to clear the bit on
> read commands only.
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 633618bafd75d3..2805e9bed2c2f4 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -253,6 +253,8 @@ static int anx7625_aux_trans(struct anx7625_data *ctx, u8 op, u32 address,
>  	addrm = (address >> 8) & 0xFF;
>  	addrh = (address >> 16) & 0xFF;
>  
> +	if (!is_write)
> +		op &= ~DP_AUX_I2C_MOT;
>  	cmd = DPCD_CMD(len, op);
>  
>  	/* Set command and length */
> -- 
> 2.35.1.265.g69c8d7142f-goog