Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp735290pxb; Thu, 17 Feb 2022 13:36:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyYajBB7axyPFsDKtVK+7GpMn/IdsTv3liBXpjjWuDL60LIIWkN06UqPpoDuKeRSYfQWXQx X-Received: by 2002:a17:906:eb03:b0:6cd:7cc2:a677 with SMTP id mb3-20020a170906eb0300b006cd7cc2a677mr3952760ejb.208.1645133813855; Thu, 17 Feb 2022 13:36:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645133813; cv=none; d=google.com; s=arc-20160816; b=Ar8wTNZRw1P6CEhTIed2xnhKti0CjsViwGljsUIQW/TVVROpXOd8GcXcvvrvYANFZG kRPfXQqGlIdg2fcWJ4wFQ6zRMPZJKGUALCnl94agwLZ2GtdoYw8R4aSL02wD79gdyqjr 06cMz1G6ey/BfQDZPcu/YtNfyCErJ3hPzz7OuyKua/yH3eHXoDEIJcZ1k8VxD3wSDVNb BM7ryn0U8IQugA5UvG566dlKhrWqJirxvb/HQMgVuXLlZ+Ln8MQTTJ60nGNnItIkvmS5 ZJWJTPIM1BsQdBI+xrinRg9RylObDBNcTM7NLws/kOcrBawv89G8B9vABfkS6B+lWYWu wWgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=aeGiUBdTUsu2S57zEGwHIQUfJ7eIXxjLnxwtpKrBdv4=; b=sUJwOro3C6p+X+vZqhl0S/1UGZbzpnP+hv7PrVXE3SnbbbkqtBImk8eR3vuZ15vjsR r9jq4+/OC6gDmglnDQA0Mrwo6TW7jPuuDapaG3Pn4JNNkzOfuIT7Agz9h6TGPf2+Q9gl gNSLndx1TeKjvtA31WpszcsxRSl+L7DxgtyXCaSPjRdR527fLoQkFIFxVlZisLNNEjjN Ib33j156BgR0IA2T1o7hu110jbJEg0D7WdPN4DocMB85BW32k+9BvnHSBX9kNj4gki/f mwrAnpCJ1Uzw+LosXRIERFwdyxfjALm9s1bpWGlaRuP5YAYG9787mb9aetNEqvoMIDtm cHVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b3si4404649eds.472.2022.02.17.13.36.30; Thu, 17 Feb 2022 13:36:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244101AbiBQSM1 (ORCPT + 99 others); Thu, 17 Feb 2022 13:12:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:46790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244118AbiBQSMZ (ORCPT ); Thu, 17 Feb 2022 13:12:25 -0500 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E36211C7EA5; Thu, 17 Feb 2022 10:12:08 -0800 (PST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 21HI7aqe029714; Thu, 17 Feb 2022 12:07:36 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 21HI7Z7l029713; Thu, 17 Feb 2022 12:07:35 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 17 Feb 2022 12:07:35 -0600 From: Segher Boessenkool To: Masahiro Yamada Cc: David Laight , "netdev@vger.kernel.org" , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Ingo Molnar , Jakub Kicinski , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" Subject: Re: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h Message-ID: <20220217180735.GM614@gate.crashing.org> References: <978951d76d8cb84bab347c7623bc163e9a038452.1645100305.git.christophe.leroy@csgroup.eu> <35bcd5df0fb546008ff4043dbea68836@AcuMS.aculab.com> <9b8ef186-c7fe-822c-35df-342c9e86cc88@csgroup.eu> <3c2b682a7d804b5e8749428b50342c82@AcuMS.aculab.com> <2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 18, 2022 at 02:27:16AM +0900, Masahiro Yamada wrote: > On Fri, Feb 18, 2022 at 1:49 AM David Laight wrote: > > That description is largely fine. > > > > Inappropriate 'inline' ought to be removed. > > Then 'inline' means - 'really do inline this'. > > You cannot change "static inline" to "static" > in header files. Why not? Those two have identical semantics! Segher