Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964964AbXBOHW0 (ORCPT ); Thu, 15 Feb 2007 02:22:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964965AbXBOHW0 (ORCPT ); Thu, 15 Feb 2007 02:22:26 -0500 Received: from smtp.osdl.org ([65.172.181.24]:37665 "EHLO smtp.osdl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964964AbXBOHWZ (ORCPT ); Thu, 15 Feb 2007 02:22:25 -0500 Date: Wed, 14 Feb 2007 23:21:37 -0800 From: Andrew Morton To: Mathieu Desnoyers Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Ingo Molnar , systemtap@sources.redhat.com, ltt-dev@shafik.org Subject: Re: [PATCH 02/05] Linux Kernel Markers, architecture independant code. Message-Id: <20070214232137.7aa86259.akpm@linux-foundation.org> In-Reply-To: <11712242074091-git-send-email-mathieu.desnoyers@polymtl.ca> References: <1171224207118-git-send-email-mathieu.desnoyers@polymtl.ca> <11712242074091-git-send-email-mathieu.desnoyers@polymtl.ca> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 57 On Sun, 11 Feb 2007 15:03:24 -0500 Mathieu Desnoyers wrote: > Linux Kernel Markers, architecture independant code. > > Signed-off-by: Mathieu Desnoyers > > ... > > + > +#ifndef MARK > +#define MARK GEN_MARK > +#define MARK_ENABLE_TYPE GEN_MARK_ENABLE_TYPE > +#define MARK_ENABLE_IMMEDIATE_OFFSET GEN_MARK_ENABLE_IMMEDIATE_OFFSET > +#endif Also perhaps this nastiness can go away once each architecture has asm/marker.h? > +#ifdef MARK_POLYMORPHIC What's this? Is it commented somewhere? (It should be...) > +static int marker_set_ins_enable(void *address, char enable) > +{ > +#ifdef CONFIG_X86_32 > + return arch_marker_set_ins_enable(address, enable); > +#else > + char newi[MARK_ENABLE_IMMEDIATE_OFFSET+1]; > + int size = MARK_ENABLE_IMMEDIATE_OFFSET+sizeof(MARK_ENABLE_TYPE); > + > + memcpy(newi, address, size); > + MARK_ENABLE(&newi[0]) = enable; > + memcpy(address, newi, size); > + flush_icache_range((unsigned long)address, size); > + return 0; > +#endif //CONFIG_X86_32 > +} eww. Can we put a suitable arch_marker_set_ins_enable() into each arch's marker.h? > +#else > +static int marker_set_ins_enable(void *address, char enable) > +{ > + return -EPERM; > +} > +#endif //MARK_POLYMORPHIC > + > > ... > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/