Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp799650pxb; Thu, 17 Feb 2022 15:14:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxcHowLoY8P33g9wRBHoxE5TUI+HUuZf+6YZEw47UJVpqaMybscMQyVkGb+M4DuzBiI8b2r X-Received: by 2002:a63:fc0e:0:b0:365:39dd:2cd0 with SMTP id j14-20020a63fc0e000000b0036539dd2cd0mr4197756pgi.173.1645139665525; Thu, 17 Feb 2022 15:14:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645139665; cv=none; d=google.com; s=arc-20160816; b=EQTLja65UkIrLbk8LqLvEF4e4rG0crRlXIE9oWiqN+CA8qVYW907hxeOQuZiWqQb8T x9ZjYoejxIAJl4U2UdBs1hyP1LitimWLnJyKP2810IqPZFfPSjo7h4Gj67rOyuPwFwor hqYlExWLXNshpddjq/LNBs4rTdaBAMQl/jqOefdYar1hwj6eRrGwl29ERyL/FNbAsGtP 2XV6D54JqXI3/JGC8yETXCI2o6n1fQ77zzI/u4eTeOwIQw3N3Jlzu0FLSGFV+2npY1NN TLFNirQ32hsqVLSZxw37NEr2QOFz2o6Qqvz5qT0PgpK0TlOlABGxbz2IBPIqEG7apMZa fnxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e/N0Rhhzz5vwAvXJwS8oHDh3H0bU+N1BFIY6++JNrEA=; b=aPc1loSBnvu7ZNXSfkq7UFQK99kf4izezjOpa+OMFAMsXRDpSZCkhC/CmjW5219LLh q5G7BIX6tY5px4bEBfEsXkzYtaZ9TfHbMWwQoUdR4KdSQMVvBi91oQw62X4IrqWXgQxB ld12gQGG2Q8m3GJy4rkQTAKfUPChShTQrFX0pPNfIqC4v34ktZXv5FH+28b+u5VX+w/M ixxUyv6S7l90PqXa4g0mkEtO0LvVChK5WbGC6ZF53N8fOlodP+a+RGaV/y5TcvGxjvgm 2KYB5vhaq423WHR7fAP/tHfoj0io7GPoAZnFCdM/Qv4QhN0EWBbInOO+X01WqGLNBSGM imzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=I32ZG9aS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q42si1973244pjq.28.2022.02.17.15.14.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 15:14:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=I32ZG9aS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A672028BF5B; Thu, 17 Feb 2022 15:05:15 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245001AbiBQTIU (ORCPT + 99 others); Thu, 17 Feb 2022 14:08:20 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242994AbiBQTIT (ORCPT ); Thu, 17 Feb 2022 14:08:19 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 325DC2B254 for ; Thu, 17 Feb 2022 11:08:05 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id v5-20020a17090a4ec500b001b8b702df57so10295713pjl.2 for ; Thu, 17 Feb 2022 11:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e/N0Rhhzz5vwAvXJwS8oHDh3H0bU+N1BFIY6++JNrEA=; b=I32ZG9aSf+guazsrpIpkMpf9UReyMsE3bpQQZ6ri67ToYEBZCORnXry2tmSi5TjU8J 382+l2UPVDCC6WMcYhrQ4Ql/C8KnmmSsv4eN0pdwoUq1qX97hUA8y+pJAapfOixKQ08J xDyub5BY2k73NG/rjsLLz16hejmske6xZghcN+bObChI4+Pf44Y8Ozd+J561ppOjx8KG Wko6+4R9koNHhmnLe/PcG43TKfJBkI8+Iy3Dgj3fpFfZXe90ToFMip+4QGGO0AfHKjMn ACq4PbZBwJQOQuhsDZwgyrDhYNvCzkNIzJt3dK9rMHZTA5VcVOUWnxWe3DNrfdJbHG4P FQ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=e/N0Rhhzz5vwAvXJwS8oHDh3H0bU+N1BFIY6++JNrEA=; b=tufoaNdUyvJ2l7onOW9evVso1cuL2lPnImn3K9iYDCUaB57oNPxGBey0d5wnS9FDFF jvBxYgc+z9GYq/XMyGvGGAB/fomVZMa2zYHvsaIT4YmwHji3TOCe8yHG3Ulkk9Wog/fY DhnHu0DdYWYTavv0ysye5fv5co/r6II0iZDwu5XWb4CRtVHnTV0PhglOQpi4wfwLfPeR 517LgThmXoJLAJvNmGOpDuYHvyJAj0GHkYd7VP3271KFRJ3pZAgZr5Aq6DTGldSDUpwr 1vPHoEv1SoE5WZ5XXJ+9WEWYu8EQb1ZJJUUU62PbQ+O6pMDYuNZAbnVkeTmWaHeoFqA/ MqIA== X-Gm-Message-State: AOAM531fUkJQtMBIOTD/h4vLq++bE26NXOVnl8MEzN1KfEvOFK1DhCu/ ROt6XCv/FDI5PzH7cWUd35kAYblLJGTxZANY X-Received: by 2002:a17:902:b288:b0:14d:5f1e:4ff3 with SMTP id u8-20020a170902b28800b0014d5f1e4ff3mr4109531plr.24.1645124884621; Thu, 17 Feb 2022 11:08:04 -0800 (PST) Received: from localhost.localdomain ([123.231.106.116]) by smtp.gmail.com with ESMTPSA id k62sm8707864pga.86.2022.02.17.11.08.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 11:08:04 -0800 (PST) From: Husni Faiz To: pure.logic@nexus-software.ie, elder@kernel.org, gregkh@linuxfoundation.org Cc: Husni Faiz , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: greybus: loopback: Fix Coding Style Error Date: Fri, 18 Feb 2022 00:37:22 +0530 Message-Id: <20220217190722.44894-1-ahamedhusni73@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_SORBS_WEB, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Macros with multiple statements should be enclosed in a do - while block. Signed-off-by: Husni Faiz --- drivers/staging/greybus/loopback.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 2471448ba42a..33666a49e0a8 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -162,10 +162,12 @@ static ssize_t name##_avg_show(struct device *dev, \ } \ static DEVICE_ATTR_RO(name##_avg) -#define gb_loopback_stats_attrs(field) \ - gb_loopback_ro_stats_attr(field, min, u); \ - gb_loopback_ro_stats_attr(field, max, u); \ - gb_loopback_ro_avg_attr(field) +#define gb_loopback_stats_attrs(field) \ + do { \ + gb_loopback_ro_stats_attr(field, min, u); \ + gb_loopback_ro_stats_attr(field, max, u); \ + gb_loopback_ro_avg_attr(field) \ + } while (0) #define gb_loopback_attr(field, type) \ static ssize_t field##_show(struct device *dev, \ -- 2.25.1