Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 17 Feb 2022 12:34:39 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Jianbo Liu <jianbol@nvidia.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, olteanv@gmail.com, andrew@lunn.ch,
        vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, kuba@kernel.org, rajur@chelsio.com,
        claudiu.manoil@nxp.com, sgoutham@marvell.com, gakula@marvell.com,
        sbhatta@marvell.com, hkelam@marvell.com, saeedm@nvidia.com,
        leon@kernel.org, idosch@nvidia.com, petrm@nvidia.com,
        alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        baowen.zheng@corigine.com, louis.peens@netronome.com,
        peng.zhang@corigine.com, oss-drivers@corigine.com, roid@nvidia.com
Subject: Re: [PATCH net-next v2 0/2] flow_offload: add tc police parameters
Message-ID: <20220217113439.GE4665@corigine.com>
References: <20220217082803.3881-1-jianbol@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220217082803.3881-1-jianbol@nvidia.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?an90PYvdUh6wyZ5KQ4W13cGZsFM12/05tU3J69o3p86NPfF+H66AKFXtm3XQ?=
 =?us-ascii?Q?ATUk4TQ3e1tz4NDnpaZYu17uWZeO9CnL3SWj7xgJvU1GSjXqrhwqdoX3vik6?=
 =?us-ascii?Q?uZP11HMGxl8F21+I6o8RnoniH8PM6HHGkp62NX0YFzCghT3o48rqO+fnRBmd?=
 =?us-ascii?Q?hjDnyOh0jx7euoDM7b+jFKIPkUnrBRiAgSrtE3w5qX/KWMCCTahV2IepkBql?=
 =?us-ascii?Q?YVcL7VB5wxCjOxeH9jnZ2iYcifZWTBoE9mIO9QE3AdyB21w/70lgNU6iMSzB?=
 =?us-ascii?Q?TD5Z31Wqon5l4rirJjFE778m1LuiDVno+C+n86PhANeq64V3mRbBUdBc3C3I?=
 =?us-ascii?Q?QJOi7N/7sw/XQ8EB1cIf6FeLKa9JdxgdAlWs26elCnOi2m0yTkr1w9wBvZwa?=
 =?us-ascii?Q?iKVXExmiKHExMSBbErKnaaf96DvKz1BGiO5ailCsPPne7zG2c389JWWdHGFk?=
 =?us-ascii?Q?DXgXrvu9SV/ZCYn61OT1YUBIwSBS1qOm9G0AI8BEL3L0ABwdKlGX6NShmsHr?=
 =?us-ascii?Q?AiLhXyfZcWYTjyYfl8XEjRYP+dPK7wowFHiv1DyHAJlOjT0GOjvbMXa77rvO?=
 =?us-ascii?Q?tHVlVfv2UTudT6C0oYSaotyrGok9iQlg0oO2JchD0Gpn9EYEPuSK6yyMOS2h?=
 =?us-ascii?Q?TTrqS+J+NT6R9kCNJQlVE1mg3m+F6kQCdcRArqQWXrbDGpiMcwG6G8obbIzn?=
 =?us-ascii?Q?pliGkMuJLzCjCbLsMNPJ9wEDQTm4Nnf3C9593zdPkpfSpYgvWwnHBL7KFozX?=
 =?us-ascii?Q?Amm9hTfcCMY3CgLmXxL61pOEh9D0SJNq/C7fQ+SzcRdJ+ty4MNrtInl2UkzO?=
 =?us-ascii?Q?sWN7024KhQPmdP+Wpfz5m2Ya2Yk9LLJkm2L2SZ/dcnYO0jEoTaWVYcQI0vKr?=
 =?us-ascii?Q?zEupCOwRlM8UghcXq/Z/TZlh5exNNaaa8PS/qF7NqJ5yyeNSgJv1aAnNNnec?=
 =?us-ascii?Q?BcLSgYl4GIKDSrwNt4e3ydWpjd851enmaU5BMllaTML0oiTU67wGdC2RJ6Vr?=
 =?us-ascii?Q?Rddo/P7jJb8BnkmfhaAgTmSNG9c3Yo0wgbIQ94lcBWXRl2QLjXyHtYodZ5wF?=
 =?us-ascii?Q?i46rGDISGWv9+/P8AJKTgMR+vmeMwmN2PeI4I35nMLpwhesVVuSieRqq/s51?=
 =?us-ascii?Q?+x1YuOLFG6wxOdKnAENs3P7isqFUGLjuN8Ynx0I3Kk66Zsl9G7UuBSSYT3QX?=
 =?us-ascii?Q?9hLgc0dHoVA0O54Z/VRDTVgL4W2MwNewOaPcB/yntb0OCXq3DQwMIVrlywfn?=
 =?us-ascii?Q?/pFyyUo85URME9RLTXXT/T1YUrTpe92o5aHBVjmQmfn08sj2IUkuVUX4dPyZ?=
 =?us-ascii?Q?2uM2E9ZdsYuzCihoesgTjvrzeS0YmfHCd0V8AL9ygK3br39gOfzhyfCKJ8tT?=
 =?us-ascii?Q?PnCywi4n+rnEa/N0Jz+UWXIAc65PslHWf4EDPqL8tCvVfdoFcDNPTmI07e8t?=
 =?us-ascii?Q?A43YjkosaB+5FWmH31nD7Zi+3lfKBNy1orThXmASFZ/lzN88S6+gKzNZrejH?=
 =?us-ascii?Q?d/FOK5sOuQG8C11HPFGYIfMJ2RUN3KThEyjdXfbJ3p9cJ2tmJeNLQH88mA5/?=
 =?us-ascii?Q?8znb8d/9LeSOJYUTn9UCZamB2/HO4I84CggEs3Lf+GM7AOtH1kzSO/fBgE7F?=
 =?us-ascii?Q?o8TeAKnS4o1jYQHCQBXe7z1hs1+ecTRb29buFdq+vnES6z3cjdY8X2gVquFR?=
 =?us-ascii?Q?iRDtAPjqWlFWjcgYD9YlEVzR4jOfrHME6gBB3KBorrtwEa2KbDwCjoZXW3Ok?=
 =?us-ascii?Q?CdcsH13iwMAWxyPd3ByLvRN3OOLCuA4=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c31dd49-e710-48cc-892d-08d9f209807e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 11:34:47.5289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bbL93b+Vg5VYv/AbDx5Zzp487bYnCWJOVa/4hROEDMUaXo1v7z/nmeD4rdcwpHyQKBZuUiyPKFxiRG9XMMGPKJ+hgtqiYgJVQBd6urWDx7o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3298
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 17, 2022 at 08:28:01AM +0000, Jianbo Liu wrote:
> As a preparation for more advanced police offload in mlx5 (e.g.,
> jumping to another chain when bandwidth is not exceeded), extend the
> flow offload API with more tc-police parameters. Adjust existing
> drivers to reject unsupported configurations.

Hi,

I have a concern that
a) patch 1 introduces a facility that may break existing drivers; and
b) patch 2 then fixes this

I'd slightly prefer if the series was rearranged to avoid this problem.

...