Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220217131234.50328-1-cristian.marussi@arm.com> <20220217131234.50328-5-cristian.marussi@arm.com>
In-Reply-To: <20220217131234.50328-5-cristian.marussi@arm.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Thu, 17 Feb 2022 15:34:44 -0600
Message-ID: <CAL_Jsq+JrLtXUoG10O3kcwYNEbzXXYn0HBLsSfm9R+qLajneeA@mail.gmail.com>
Subject: Re: [PATCH v5 4/8] dt-bindings: firmware: arm,scmi: Add
 atomic-threshold-us optional property
To:     Cristian Marussi <cristian.marussi@arm.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        Sudeep Holla <sudeep.holla@arm.com>,
        Jim Quinlan <james.quinlan@broadcom.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Etienne Carriere <etienne.carriere@linaro.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        souvik.chakravarty@arm.com,
        Peter Hilber <peter.hilber@opensynergy.com>,
        Igor Skalkin <igor.skalkin@opensynergy.com>,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 17, 2022 at 7:13 AM Cristian Marussi
<cristian.marussi@arm.com> wrote:
>
> SCMI protocols in the platform can optionally signal to the OSPM agent
> the expected execution latency for a specific resource/operation pair.
>
> Introduce an SCMI system wide optional property to describe a global time
> threshold which can be configured on a per-platform base to determine the
> opportunity, or not, for an SCMI command advertised to have a higher
> latency than the threshold, to be considered for atomic operations:
> high-latency SCMI synchronous commands should be preferably issued in the
> usual non-atomic mode.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> v4 --> v5:
> - fixed example and removed dtschema warnings/errors :
>   arm,scmi.yaml: properties:atomic-threshold-us:
>         '$ref' should not be valid under {'const': '$ref'}

Seems an old version got picked up for linux-next:

/builds/robherring/linux-dt/Documentation/devicetree/bindings/firmware/arm,scmi.yaml:
properties:atomic-threshold-us: '$ref' should not be valid under
{'const': '$ref'}
hint: Standard unit suffix properties don't need a type $ref
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/linux-dt/Documentation/devicetree/bindings/firmware/arm,scmi.yaml:
ignoring, error in schema: properties: atomic-threshold-us

> - added default: 0 clause
> v3 --> v4
> - renamed property to atomic-threshold-us
> v1 --> v2
> - rephrased the property description
> ---
>  .../devicetree/bindings/firmware/arm,scmi.yaml         | 10 ++++++++++
>  1 file changed, 10 insertions(+)

For this version:

Reviewed-by: Rob Herring <robh@kernel.org>