Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp823704pxb; Thu, 17 Feb 2022 15:51:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIbyFvhW2IEkqcWnMKcoAS/MbYAsRsMVRZMD19P7vmCgQWj63wgqjFq6l6Yfl1A+KeUpXr X-Received: by 2002:a17:90a:6943:b0:1b9:e285:e4a3 with SMTP id j3-20020a17090a694300b001b9e285e4a3mr5585240pjm.153.1645141885141; Thu, 17 Feb 2022 15:51:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645141885; cv=none; d=google.com; s=arc-20160816; b=Syqcgdr9J9EyZxu59oWacxH1lH27Gjc2dAUhwTyIelsra6Vimdxvw8VP388sG/68MQ VgZ8/Jfk6eZWVdDA+x0SbpFW4VABDZW03Nxn1/vHfu0nMq7J4gJvChxHj/T9PKqNRy/n avSrxhh1hWrdDLCpjwPdZNfawermK9rplEMbXMJMRgaW1OyrG+yajnkn3beuW8NTr3f6 5obbRdTDA2SlI8YrXdKzs5qiFm3ua/U357P+8U1g/rKxNuLj1frVHGoEvIJPyb8OB8qT 57XogqnC6GReM0V14FY7SDHmHbIC0tcFnA+Yf0xbQs5cN1XZukJXJkZIpgHfCNmp1g13 PtHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=j3r7Sjy2s/K4ZABbnDEoBuac9NC82bvfdRC+YKUKQe4=; b=o+Dut8UlBGocz80N//9TehNh0fy43lztM7PpvE8UjIhYt9VAIvasdzg+oD4MXx7+tY qvhDe3JfJkVtSxawwPq6OjqBTMQZLp7Gvnb4FJ8qcXGmnIglCoB/ugsbRMB4OgTQjSsS RNsbkrtz4WN6peFe7t80084/lG3cDcsikC2WdmWnhmxeUZ5WbN7dv433qHMk4kqtP4CO ygZVTK6ufZF0mtERKTL4VTXyllbtw/vVkovA7J6D6jp5JJYCM84S8sYfmw1y1oHV7QMx iME+o+MKHvkcMGZzAvt4T4gwi3hj0fqdNHpmzVuuFfnstlEkCcFPKkRNXfB6Yv6CS1mF Ho9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=h+AQsWVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t25si9117281pgv.787.2022.02.17.15.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 15:51:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=h+AQsWVC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 170904ECCE; Thu, 17 Feb 2022 15:23:58 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236738AbiBQHx6 (ORCPT + 99 others); Thu, 17 Feb 2022 02:53:58 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236656AbiBQHx4 (ORCPT ); Thu, 17 Feb 2022 02:53:56 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77AE0184639; Wed, 16 Feb 2022 23:53:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j3r7Sjy2s/K4ZABbnDEoBuac9NC82bvfdRC+YKUKQe4=; b=h+AQsWVCUUGjY2kStTlIVl9afN 6GA6M7563AQ+BVffl31GhaKxA3X7iuULO30vtcqjim8Kw3o03w2CyP214ODVuSn91s+P9OjOKQfaa vrSwGDYoOys3MJh6XPJ2j2bEUSH9bMylpDsVtRnAOfaVxKzREwKz7eOvpnygMs9yuzO28O1hBjBPA lGiemGg4AEJN6tmvA2ClM2eKKMoDVYlm7Uij7vq8coxP7WnkDiIKkU6iQ+RaHVln9jjHheHobYIeT OxLrlnbrXkcMUw70ijgaDU0JVR25z6nPxqL5iJgwNImDaDOvpTQCATnCn9X1GFqFu+7xUqEEA+7w/ hQIUI87Q==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKbbc-009HMh-NI; Thu, 17 Feb 2022 07:53:36 +0000 Date: Wed, 16 Feb 2022 23:53:36 -0800 From: Luis Chamberlain To: tangmeng , Zhen Ni , Andrew Morton , Stephen Rothwell , peterz@infradead.org Cc: keescook@chromium.org, yzaikin@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] kernel/reboot: move reboot sysctls to its own file Message-ID: References: <20220217042321.10291-1-tangmeng@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220217042321.10291-1-tangmeng@uniontech.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 12:23:21PM +0800, tangmeng wrote: > kernel/sysctl.c is a kitchen sink where everyone leaves their dirty > dishes, this makes it very difficult to maintain. > > To help with this maintenance let's start by moving sysctls to places > where they actually belong. The proc sysctl maintainers do not want to > know what sysctl knobs you wish to add for your own piece of code, we > just care about the core logic. > > All filesystem syctls now get reviewed by fs folks. This commit > follows the commit of fs, move the poweroff_cmd and ctrl-alt-del > sysctls to its own file, kernel/reboot.c. > > Signed-off-by: tangmeng Queued onto sysctl-next [0]. This tree is intended to queue up all of the sysctl changes, get them tested. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-next Luis