Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <1d615078-1417-500d-0521-5d8424da7212@suse.cz>
Date:   Thu, 17 Feb 2022 18:02:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] mm/slob: make kmem_cache_boot static
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org,
        cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220217085842.29032-1-linmiaohe@huawei.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20220217085842.29032-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/17/22 09:58, Miaohe Lin wrote:
> kmem_cache_boot is never accessed outside slob.c. Make it static.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Thanks, adding to slab tree.

> ---
>  mm/slob.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/slob.c b/mm/slob.c
> index 60c5842215f1..1179bcad2df8 100644
> --- a/mm/slob.c
> +++ b/mm/slob.c
> @@ -708,7 +708,7 @@ int __kmem_cache_shrink(struct kmem_cache *d)
>  	return 0;
>  }
>  
> -struct kmem_cache kmem_cache_boot = {
> +static struct kmem_cache kmem_cache_boot = {
>  	.name = "kmem_cache",
>  	.size = sizeof(struct kmem_cache),
>  	.flags = SLAB_PANIC,