Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp832431pxb; Thu, 17 Feb 2022 16:05:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJwesx/a++9G3tKBPyPsZKnJxP1vo++jYp7Ju3So5UiAlZKEzbSkEXFycDPlm6qlB+SQL5gF X-Received: by 2002:a63:407:0:b0:373:a770:b1c with SMTP id 7-20020a630407000000b00373a7700b1cmr4035960pge.93.1645142699739; Thu, 17 Feb 2022 16:04:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645142699; cv=none; d=google.com; s=arc-20160816; b=UP8CSPL62xV4HJBd40OG0RQ4SugHkibmU+PIcMRry82UjQbAO/3vLBWC+204R7FNrX Ldpib/mZoUbtOqWPIOZlAMEc6CMRIZk4a2TukalEnIVXNp7PV8VhW+zSOSRmW65TXs5R CgJFGb8lEKMWJRZUXaOnFzPT5z/PN6im05gF3LXEHb597pXBoludfhS25t/F2hb1cScG 1pkdeSV6wOpV6Iv8e3P91qJGSTlyhzhx9kMVZFE6iie3LBQRkjhpHsiD0syA6thh2r6r P5UNt9ha5vRoUvDtABBc/7bDmKdXgBMJsk79V3JdBn3f7c6sxx8lTXLbBjNOldYZhPVO VIjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hCGdZ67U7n7QTxmEpkXTMre/CxFj1dLb8EpsB9Wt9NU=; b=rUgg8Bn6X3FG3dMUXWu1bHcGjsr0GAlytdYbnz2BZ/WwxMHLEAndvbcP4CdrlHaToh zw6YGEc56ohZfH4gaXTJuc72cfyZkyjAbaHjlRTlwyB/qJ4wY0hucizz8huLw3AumBel yRiroC0K5HjQ5MXDd+93QIJMpzXq3an7JWTpMcrPTk2Fo6FJOhhbOxruv09eyLhXXyPs 84y3bPwpBABPORPYwj/31Q5tUsFlbNIwe35i4+PRLHZFa5gq8Tvnn7NrBXCWOHhJl4dd YaBGPYPUFBWjDYTs+MPOiEY7i326MXALfqjwpyfsh6sc7qApdIKo8gC8wUzLTvq6yJdS lSRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GezvIP/F"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id k69si6901688pgd.105.2022.02.17.16.04.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Feb 2022 16:04:59 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GezvIP/F"; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EBAFD2DB757; Thu, 17 Feb 2022 15:32:22 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243087AbiBQQ1H (ORCPT + 99 others); Thu, 17 Feb 2022 11:27:07 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:57860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236819AbiBQQ1D (ORCPT ); Thu, 17 Feb 2022 11:27:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6FA149AD9B for ; Thu, 17 Feb 2022 08:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645115208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hCGdZ67U7n7QTxmEpkXTMre/CxFj1dLb8EpsB9Wt9NU=; b=GezvIP/FDCuCmOONL2/N+znUrvSlf3Dn1YzdVsR8UGtqHkUlHeHjrzXvZ4uMgpgTxfZdQB 5Fdi+oNp1g9Pot3OTRH3VRqxQNJxihltcVv0Bw7qEyr0U+qAbCIbXMp9h+usElW1+8fgAH yT1qx1qbo0kM/mYTRrQVGvDci7EE68E= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-338-PiK3aXcyMfyvswnMJNt5rQ-1; Thu, 17 Feb 2022 11:26:47 -0500 X-MC-Unique: PiK3aXcyMfyvswnMJNt5rQ-1 Received: by mail-lj1-f200.google.com with SMTP id q17-20020a2e7511000000b0023c95987502so47451ljc.16 for ; Thu, 17 Feb 2022 08:26:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hCGdZ67U7n7QTxmEpkXTMre/CxFj1dLb8EpsB9Wt9NU=; b=AcDu8M/Jjb0i9MYtWGjDEsNJNek/i+Hx3kJbRDuD1R/Cqr+octT90ntrQDWHr5lxIz k5KxZ1Mf5a7v1YgRnTy6saqdiHOi3QnSyqqH9VFL93bTnMlG8Ge2D8Cv5XoWUPo0VijB 7FxQYJzCjf35pFEq/ki98F0r3q8/XlFqhKTDvNpEs0L3Da+BXnyRJ9VGdF2N+sPmYiwb L5W9jHLd7MoG27g/PcnSEEKyoDjxrNMC/YfmxEkPq54gjZ544/bpPQlr69m7dqp0bF2I cbrrtT0USwfunjOu6UUel94rnMNMhI+MZyd+kb4VnA/nhdkC2y8mHHHulF1gmqA76Thz n/lg== X-Gm-Message-State: AOAM533AiUi+hMPZrM0tFSClzVa1aIIpoiG7dm4P8azIXrsJP3WaoskG 83F5Ej/I/2ejeMIbaVaImXVmtMMVz/dI80cPBvGnIQTZnBfXuZDUmA+E1uxb6HC2Z95TnjGr+Lv lL6OhsVuYn+mNtJa2vJQnbWQtdVyWwjKdRUFxrMw= X-Received: by 2002:a05:6512:150d:b0:442:aad5:2550 with SMTP id bq13-20020a056512150d00b00442aad52550mr2567895lfb.678.1645115205790; Thu, 17 Feb 2022 08:26:45 -0800 (PST) X-Received: by 2002:a05:6512:150d:b0:442:aad5:2550 with SMTP id bq13-20020a056512150d00b00442aad52550mr2567879lfb.678.1645115205613; Thu, 17 Feb 2022 08:26:45 -0800 (PST) MIME-Version: 1.0 References: <20220209171118.3269581-1-atomlin@redhat.com> <20220209171118.3269581-3-atomlin@redhat.com> <14a1678f-0c56-1237-c5c7-4ca1bac4b42a@csgroup.eu> In-Reply-To: From: Aaron Tomlin Date: Thu, 17 Feb 2022 16:26:33 +0000 Message-ID: Subject: Re: [PATCH v5 13/13] module: Move version support into a separate file To: Miroslav Benes Cc: Christophe Leroy , "mcgrof@kernel.org" , "cl@linux.com" , "pmladek@suse.com" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "atomlin@atomlin.com" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2022-02-17 16:51 +0100, Miroslav Benes wrote: > It is not, but "struct find_symbol_arg", which you moved, uses "enum > mod_license" defined above, so you can either leave it as it is, or carve > "enum mod_license" definition out. Hi Miroslav, I've done this already for v6. I hope to share the latest version for review shortly. Kind regards, -- Aaron Tomlin