Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220210173100.505128-1-robimarko@gmail.com>
References: <20220210173100.505128-1-robimarko@gmail.com>
Subject: Re: [PATCH] clk: qcom: ipq8074: Use floor ops for SDCC1 clock
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Dirk Buchwalder <buchwalder@posteo.de>,
        Robert Marko <robimarko@gmail.com>
To:     Robert Marko <robimarko@gmail.com>, absahu@codeaurora.org,
        agross@kernel.org, bjorn.andersson@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, mturquette@baylibre.com
Date:   Thu, 17 Feb 2022 16:14:36 -0800
User-Agent: alot/0.10
Message-Id: <20220218001439.57B6FC340E8@smtp.kernel.org>
Precedence: bulk

Quoting Robert Marko (2022-02-10 09:31:00)
> From: Dirk Buchwalder <buchwalder@posteo.de>
>=20
> Use floor ops on SDCC1 APPS clock in order to round down selected clock
> frequency and avoid overclocking SD/eMMC cards.
>=20
> For example, currently HS200 cards were failling tuning as they were
> actually being clocked at 384MHz instead of 192MHz.
> This caused some boards to disable 1.8V I/O and force the eMMC into the
> standard HS mode (50MHz) and that appeared to work despite the eMMC being
> overclocked to 96Mhz in that case.
>=20
> There was a previous commit to use floor ops on SDCC clocks, but it looks
> to have only covered SDCC2 clock.
>=20
> Fixes: 9607f6224b39 ("clk: qcom: ipq8074: add PCIE, USB and SDCC clocks")
>=20
> Signed-off-by: Dirk Buchwalder <buchwalder@posteo.de>
> Signed-off-by: Robert Marko <robimarko@gmail.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>