Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: H8FLT5K0SXRVq6TjpSzFLsrmit3jAkvMBS0CHc0UWpNVmAOK3mQcFQOt1VtRgkHEnZZAoWuq56
 p8CyI6ZwqBQQ/ajE/NLD/Tzem97LNHZl6ch9obtC4jZnkWphF3RNfj56x6E3DwiLQbKeiwe2hP
 /GV8FMh3jcgpbox6uQT9SnkK0q0ptsXNmebV/1rpSsNlBBwXOaYgYkwuoC8egoA9adrBhonoqA
 hpBHHRm4pSj6EY3DQYO1StX+2MGbWe9cyy5+e+LPN4w4seCIkxz3vPIhUYNscSqnXBY1/3csXM
 5cuxzTUCuxZGjQ8OagFScVNs
IronPort-SDR: MuBRD4N+c1h4bJTlCrZH15QnuMJ9Fs8g326wsJDrsDMKI+CD8tbk7jOcTRD7nFYd1Ztzc2jHdx
 M3J17G5ncV7rS4PmLEvEP+peksKYAA6DQMTnsYf/7UaiucsTT3xhdFVxoXOkEmSLYWgARuvUyf
 +ISW9RJ/zPsk6reSWMM90EvuTOc9LIntVQiRomUruWD4GBPKouzxlUP8ZaGBz2bfF3zlsYf7MR
 T8Vien4ytzfTYYwuQbr3qDs0Fa6kmAYNQ29oVOjZ6JlMNzZBTncwIt3rYnraC9RusxHcmY1m6f
 A4I=
WDCIronportException: Internal
Message-ID: <5ecf520e-588c-d756-1cb8-2224535b550e@opensource.wdc.com>
Date:   Fri, 18 Feb 2022 13:18:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 00/18] scsi: libsas and users: Factor out LLDD TMF code
Content-Language: en-US
To:     John Garry <john.garry@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, artur.paszkiewicz@intel.com,
        jinpu.wang@cloud.ionos.com, chenxiang66@hisilicon.com, hch@lst.de
Cc:     Ajish.Koshy@microchip.com, yanaijie@huawei.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linuxarm@huawei.com,
        liuqi115@huawei.com, Viswas.G@microchip.com
References: <1645112566-115804-1-git-send-email-john.garry@huawei.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <1645112566-115804-1-git-send-email-john.garry@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/18/22 00:42, John Garry wrote:
> The LLDD TMF code is almost identical between hisi_sas, pm8001, and mvsas
> drivers.
> 
> This series factors out that code into libsas, thus reducing much
> duplication and giving a net reduction of ~350 LoC.
> 
> There are some subtle differences between the core TMF handler and each
> of the LLDDs old implementation, so any review and testing is appreciated.
> 
> Some other minor patches are thrown in:
> - Delete unused macro in hisi_sas driver
> - Delete unused libsas callback
> - Delete unused SAS_SG_ERR
> - Add enum for response frame datapres field
> - Handle unrecognised errors in sas_scsi_find_task()
> 
> I have another follow-up series to factor out the internal abort code,
> which is common to hisi_sas and pm8001 drivers.
> 
> Based on mkp-scsi 5.18 staging queue at commit ac2beb4e3bd7

I tested this series with my pm8001 v5 series on top. Everything looks
good, no problems detected with both SAS and SATA drives tests. So feel
free to add:

Tested-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

Martin,

This series and my pm8001 series have a conflict. When applying the
pm8001 patches on top of these libsas changes, patch 28 has a fairly
easy to resolve conflict. Let me know if you want me to send a v6
rebased on top of this.

Thanks !


-- 
Damien Le Moal
Western Digital Research