Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220217190722.44894-1-ahamedhusni73@gmail.com> <Yg6hcX6XK4Eu0KOR@kroah.com>
In-Reply-To: <Yg6hcX6XK4Eu0KOR@kroah.com>
From:   Ahamed Husni <ahamedhusni73@gmail.com>
Date:   Fri, 18 Feb 2022 10:22:28 +0530
Message-ID: <CAFjpAKqy908scQTRJPkMhEz8OyNiR3-N8XD2hiGa+VBLhUf0VA@mail.gmail.com>
Subject: Re: [PATCH] staging: greybus: loopback: Fix Coding Style Error
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        elder@kernel.org, greybus-dev@lists.linaro.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Greg,

On Fri, Feb 18, 2022 at 12:56 AM Greg KH <gregkh@linuxfoundation.org> wrote=
:
> Did you try to build this change?

I am a newbie kernel dev and trying to understand how things work.
I did not build this change by the time I sent you this, thinking this
is just a style change.
I should have tested the build. I am sorry.

Now I built the changes by setting the following configurations.
CONFIG_GREYBUS
CONFIG_STAGING
CONFIG_GREYBUS_LOOPBACK

My change introduces the following error.
''''
drivers/staging/greybus/loopback.c:166:2: error: expected identifier
or =E2=80=98(=E2=80=99 before =E2=80=98do=E2=80=99
  166 |  do {            \
      |  ^~
''''
I could not fix or find the reason for this error. Please guide me in
this regard.

Thanks,
Husni.