Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Penigalapati, Sandeep" <sandeep.penigalapati@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v2 net-next 1/4] ice: switch: add and
 use u16[] aliases to ice_adv_lkup_elem::{h, m}_u
Thread-Topic: [Intel-wired-lan] [PATCH v2 net-next 1/4] ice: switch: add and
 use u16[] aliases to ice_adv_lkup_elem::{h, m}_u
Thread-Index: AQHYE5SGUyVYYLIpjU2OvOT0tAmHMKyY5rRA
Date:   Fri, 18 Feb 2022 05:18:46 +0000
Message-ID: <MW3PR11MB455479F0312E6C9DD12386659C379@MW3PR11MB4554.namprd11.prod.outlook.com>
References: <20220127154009.623304-1-alexandr.lobakin@intel.com>
 <20220127154009.623304-2-alexandr.lobakin@intel.com>
In-Reply-To: <20220127154009.623304-2-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BBaqI3mdwKeuOtsOb3m1eopImylYlTTPycRmFtpnNZu5CvT2R4xw7M20HPNZ?=
 =?us-ascii?Q?tmVUz/oIVGwQFHbCpXSpLQ9Ha+NnMcrQQ/5oLD3J06hWxiwN6da3Ldx4H4kr?=
 =?us-ascii?Q?EvjtnXb3HjrV6+PVE97L5gZiQw699n3CGDexeS6uMGF18iwKXRIt9/yCfQ2h?=
 =?us-ascii?Q?qzvMFOGqkhFlzXcs5syJNQK1xq9964SudGRlCDOvoLWgan69j2W/5wz3jlVq?=
 =?us-ascii?Q?CIbHd+ffxb+ONMo4tuOy8vWW6IPWJUGhFtPN4bZlJ0WHOZXYHFm3BEztcgNy?=
 =?us-ascii?Q?sXgPm2RUgLVWaZRFnYW2+sJGObHY2oZYLJVXzeuxeeCOaYs+84zLTMBR2gPK?=
 =?us-ascii?Q?5AouYfAOwsjjqwMZHDRcy9hTjOTIGZV/glht4WFSVAL7T+9qCrpuiZ/tRhhD?=
 =?us-ascii?Q?yROc1MguZtxGUPXvAtpSIoJNV53GHuFIL/0bHK71jaG00oiXecivn6g4uELk?=
 =?us-ascii?Q?Cj9BnHGxqc4eUuY5/mF+SERsoX4HJyoN+4Bo1u3tYOV1pTJqFL0I7yJ+L9Zk?=
 =?us-ascii?Q?r4TT+65O+XTJutMll4WaRnGPoWLpkCxbJBb8tW3YzC/RcIPLQ33Bj1wFWPqN?=
 =?us-ascii?Q?6ObQWVyjT/UQsXNDb+FrTc4HsZSoj92ZLJq0ffWkpCL1vzQF8o8dBhF3MLmf?=
 =?us-ascii?Q?GcB/r1hgKlpLrWgrnCC6cLJmwo9YTOiXtlmtGRtiVV2qhDTPDySXN489s1y/?=
 =?us-ascii?Q?C0kVLYeDaa18CKjnwMhZIPKfJjODgmWisT8EYM1cMEJSq8I69khv0PjSJ+gG?=
 =?us-ascii?Q?+VO0ak0NnYavc3umbh0hirHGVAhSopAJle/JJ0XCVs+9sV1SFgfPQsfUyrOO?=
 =?us-ascii?Q?hefD7CVFsziojFRlRrV5QtM/m9KbQ3rjgK5F6Xjcp/ULoDvxVwAvmTdtPjPO?=
 =?us-ascii?Q?N0fn02gkeTwPFOOQuNGQBxk2SjIGwwoPVos6IT+0mrc//hfLHR7ASo6SIg2z?=
 =?us-ascii?Q?vPHgii9eQzFpF48qqWrMO0ZDtYhRnPWzjqdrts+vF/ZdqZoXLbQbq4AaOlei?=
 =?us-ascii?Q?AW227DwHcYdHUlxSl7SSl/fCT3F4tRV8FMfLvxu+ORmJ9jeBsCuc92MW8ktR?=
 =?us-ascii?Q?16BP9Ur5DNOs3d1NRzYEbVz3+PD1u0w+bJzb4TojqjhtCHjU/dl66bcupHSQ?=
 =?us-ascii?Q?o/VRce517461wsFHtSTbYaG+pBowzQV3SM8Y3b5XEePCF/zKSxNz9/wCh7AB?=
 =?us-ascii?Q?WoX6g60P+g9/xJtgwdLuTSA9UUD04AluXA8yehf4RPIwg/7C5wdHOLHZP2ma?=
 =?us-ascii?Q?s6R+lcqU/lxKs0/Pn+MLyuzU6R6+9GAsiBYLnoJjZF/M/v9CD5iAvSgxEchw?=
 =?us-ascii?Q?gbgHVb3ILPH6XjOyZa8m9qLgHlpUIdvn9xMLCdxzyinFruHRsoYl8EhQcQxN?=
 =?us-ascii?Q?n+lfykHvUfKIceoTHyrBR8CzljMH1X9pVkumhLcqSBguaYH8vdOl+mKwQgDh?=
 =?us-ascii?Q?9WiekeHEqUcTyyflVj6SovRBTCqbDIig3FhZH+YQsjv6c3lCFD7SrirSzitX?=
 =?us-ascii?Q?xLX9fqSh7/F4SnshxxiNcbuc+/Na9eo3LI1Ljl8mjefQSLwf7nOi62SpJ092?=
 =?us-ascii?Q?wZ7ejt7kp3I3tnczj/L2aSxqgYQ2h5QcD9gtAekmjQFaqarHgL8uZpwyQoXG?=
 =?us-ascii?Q?RSrFH/fE/NCMy1MYzh4mk6paQAWThDy4givauJ+lcmsXBbVo42zGKlH5ELfo?=
 =?us-ascii?Q?gIG4XQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4554.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61b000c9-f452-47aa-76f4-08d9f29e2370
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:18:46.1557
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kcg/QaNRMH2kvmSwsbaRvxUrOK8dTXgcV9nv3u0SvpyzsV5NqqPmOtb3WHIIXyoK8HegSG8eJW6bZmMoukyxH+/nHObK1oMrcRsvtucTeuk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3568
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Alexander Lobakin
>Sent: Thursday, January 27, 2022 9:10 PM
>To: intel-wired-lan@lists.osuosl.org
>Cc: Szapar-Mudlaw, Martyna <martyna.szapar-mudlaw@intel.com>;
>netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
><kuba@kernel.org>; David S. Miller <davem@davemloft.net>
>Subject: [Intel-wired-lan] [PATCH v2 net-next 1/4] ice: switch: add and us=
e
>u16[] aliases to ice_adv_lkup_elem::{h, m}_u
>
>ice_adv_lkup_elem fields h_u and m_u are being accessed as raw u16 arrays
>in several places.
>To reduce cast and braces burden, add permanent array-of-u16 aliases with
>the same size as the `union ice_prot_hdr` itself via anonymous unions to t=
he
>actual struct declaration, and just access them directly.
>
>This:
> - removes the need to cast the union to u16[] and then dereference
>   it each time -> reduces the horizon for potential bugs;
> - improves -Warray-bounds coverage -- the array size is now known
>   at compilation time;
> - addresses cppcheck complaints.
>
>Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_switch.c | 15 +++++++--------
>drivers/net/ethernet/intel/ice/ice_switch.h | 12 ++++++++++--
> 2 files changed, 17 insertions(+), 10 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>