Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Penigalapati, Sandeep" <sandeep.penigalapati@intel.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>
CC:     "Szapar-Mudlaw, Martyna" <martyna.szapar-mudlaw@intel.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>
Subject: RE: [Intel-wired-lan] [PATCH v2 net-next 3/4] ice: switch: use a
 struct to pass packet template params
Thread-Topic: [Intel-wired-lan] [PATCH v2 net-next 3/4] ice: switch: use a
 struct to pass packet template params
Thread-Index: AQHYE5SFgW5O45u9YES1b6wJ53J4vqyY5wwg
Date:   Fri, 18 Feb 2022 05:19:45 +0000
Message-ID: <MW3PR11MB45544D0038C2B56448258AB79C379@MW3PR11MB4554.namprd11.prod.outlook.com>
References: <20220127154009.623304-1-alexandr.lobakin@intel.com>
 <20220127154009.623304-4-alexandr.lobakin@intel.com>
In-Reply-To: <20220127154009.623304-4-alexandr.lobakin@intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IzBKY2ocDgxVaivq03GHzf/sQtu7Izy/Xol1irbJH7pK9tipv6dol6HcO3EG?=
 =?us-ascii?Q?K2FQnE5Ju3sGrbTD4QcOHec6NhHUP/IXQPjvyoI2zmZH8vXHYO1zFgAjYZfW?=
 =?us-ascii?Q?74c5uU7g5lhB4/Y3LC/OSVfckdn6Q2oQxMRIKX6buaOZ3gHxm9bja/HHCO2Z?=
 =?us-ascii?Q?uGLsZP8PjEFewXiUOnq1+gpMJVmxbekdtngiPeEEYDscjg1v/a9Qp+CcEYIP?=
 =?us-ascii?Q?W+kSouHD0bYS4xkdt/IVM9wCBZwmDHO3b+bzx+sTqyUEEC9NF9T0HtL4iuoD?=
 =?us-ascii?Q?hEgeHp9Vsw0+p1XWh688AJIFYf9jFyiSeJwPF8vXajZymtkrqz1B0/pS+a3W?=
 =?us-ascii?Q?G3Qj7/HXyGLDLA8vE4FzRkFYBWlVtouIWpRA5PMcgeErKgvDFQjxrwPA3jQa?=
 =?us-ascii?Q?JP6LH1GF4ajlaeUXEjF8kuC7Ygn1hOFWt8RoYY3uDPZ/I5SfAvt7EN9eGIKM?=
 =?us-ascii?Q?quvwBA618Z7F1W1jDpIVXV1wixnCZU1lX6migJinC5ZbCJYu+kzYATrPfGid?=
 =?us-ascii?Q?uXc+/dBzvQ7WO7hjPmcvbwwyOQW0HWe7O15OrjFwF85QfHc0qbFE8gRI0uVd?=
 =?us-ascii?Q?VBPFcZfqlip+b2rHgOd6t1NFBWGiKZe6kC0t3y25dAyiWmnc8uK02mud0CFV?=
 =?us-ascii?Q?GwPzVRqatvY74WSt8OMWE6AzTYpBWeegz4dh2L9EkZjdNIhieg+atOGvnJqx?=
 =?us-ascii?Q?vo4DcRbEn0C2QGMpbqN3ao5JwO2bBhWazPpxG8qFlI0KmFi8GpmBbHStNmQQ?=
 =?us-ascii?Q?7S+rOPNlxodjKSYs+zu7dkQYP/sUHyKhR36Uou0oGsgVF/4Rgga6zAMNMfxu?=
 =?us-ascii?Q?jNbk0gStzx4mHy1o6xHdHf3Ftd/eTMRXLbQMnRr+qwdTZpX6h5XL47Wx6d2o?=
 =?us-ascii?Q?89KEA+bWt6pVmP2aR7/U6boZTjg/MwgE9zwFh95SAv8LAt85bGHy1VH2B/JN?=
 =?us-ascii?Q?2Mmx+DtRXdsbn+nuFWu5B0hDHFwcQiNYCsfu9u1HKetW38HXxdS0dHhWisZT?=
 =?us-ascii?Q?OqLClGkyyAivraGKrs7is72uqeZafKhItWujPdX3XzhE8DHg77Kas7CTnFPb?=
 =?us-ascii?Q?AJCFc8olZpvzj9wC+xo5PDzpAnMYi5N/9PwfdZ/qWeJdYVt/SKklg+/n7O6g?=
 =?us-ascii?Q?XxBuP6b4/vyQieMT1BR0LnV3OHeKUPA8xarhBN3jQD8bQTQVnsbKCcgD2ekl?=
 =?us-ascii?Q?o3VB4p39HYSOn77LytQRlezoa4+JqRGF+rqjGpqAGVqSBKM7Mw/TXLnmK2M4?=
 =?us-ascii?Q?kcSv3Ycd16h+4O7zYMMmjd+iZZ0x4rpvgcCyHQgtF93cuVxX6OpWliIHaO9S?=
 =?us-ascii?Q?bq+6WG83RFfrqSgIcVhSF9xHO/j4nx5a6Ut1ZVhgfTDIIQ9sSJo6R8DjTXrM?=
 =?us-ascii?Q?zhTd7K6y2BeWPBbXWkHktRv/XYWyv+n5eOd2n5TDEZHAI6R75Ck5Kru7h5oF?=
 =?us-ascii?Q?JQwzlAMxSguH+ZOG0j0f+pjMN4HHYLiHellf8QbiV7VGs+cBspsXRwt7P8aq?=
 =?us-ascii?Q?YSQ3mahwmDSF7AvftRPrQ7R7yg91522QW4TxT4wB5L0yc5B+r8q9UFqohYcY?=
 =?us-ascii?Q?R5Qdy5eirsRPW4+mhoxOcym2Cb6sIdo8We2T5FJohf8TXnVTZ10GFkqCfx3h?=
 =?us-ascii?Q?u+xjlITbhHTQEUYPkOQvk5EF1FSefIOvDlCeepzdaapOTGk03K4q9+U9MKbc?=
 =?us-ascii?Q?2fYs+A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4554.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82d2e567-721e-4d72-89f1-08d9f29e46c8
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 05:19:45.4532
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8lSXe9S/9pKLYTTlQ9z1uCkLdatede/Nduh/JMqekD4Z2gA1sAaSnric+0rICoD38QoBail/e05vzB1bHH8kwi6xr6mXLNkGkfgldfNNfvc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3568
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Alexander Lobakin
>Sent: Thursday, January 27, 2022 9:10 PM
>To: intel-wired-lan@lists.osuosl.org
>Cc: Szapar-Mudlaw, Martyna <martyna.szapar-mudlaw@intel.com>;
>netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jakub Kicinski
><kuba@kernel.org>; David S. Miller <davem@davemloft.net>
>Subject: [Intel-wired-lan] [PATCH v2 net-next 3/4] ice: switch: use a stru=
ct to
>pass packet template params
>
>ice_find_dummy_packet() contains a lot of boilerplate code and a nice room
>for copy-paste mistakes.
>Instead of passing 3 separate pointers back and forth to get packet templa=
te
>(dummy) params, directly return a structure containing them. Then, use a
>macro to compose compound literals and avoid code duplication on return
>path.
>Now, dummy packet type/name is needed only once to return a full correct
>triple pkt-pkt_len-offsets, and those are all one-liners.
>
>Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com>
>---
> drivers/net/ethernet/intel/ice/ice_switch.c | 173 +++++++-------------
> 1 file changed, 62 insertions(+), 111 deletions(-)
>
Tested-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>