Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp1052323pxb; Thu, 17 Feb 2022 22:46:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJy0tsDV8wlm1+d6lvg96UMhrkihpbmQ8Se7XyJ5Ng4YHswJjNExAD1WalOxpQlPNJh8vz89 X-Received: by 2002:a17:90a:ca09:b0:1b8:bec1:9a3 with SMTP id x9-20020a17090aca0900b001b8bec109a3mr6921062pjt.241.1645166813417; Thu, 17 Feb 2022 22:46:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645166813; cv=none; d=google.com; s=arc-20160816; b=fwccvMnB2yj5V7sIdWt85giEu95IARrIM2by9qstaACgaRAxrdIDizdYHT+CZkImsb 1zjrru6bj+tbhEOjXq1Pydo0+09iXTNIwrY3oM8ghHiVAwdFwq21qcv/PFC6ciu56qPd nAayuCD0j+XYoZQ/OEHU+gGbYeFBI3XsGxjAznfiNwKpPaM8mnDaMAtQ6WDyQrklSgXE rEXlC1DldCFxWRNdCdKb4RNItDliP8hhr1bpfXeIN6vlPMJYS0dyE47z9yU85sXWHuLt E2orniZ8sczJQ+HSgt1OtNz+kPAeh7qLmJgHD0C8TCGHG010OAntYhIEMRNzWlWS1a+k wVzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=i6WeLJsZhsc9iHREf3MLonWYSuo/Yma9O/bhsAdRZs8=; b=n/7/qe+ZzMo7ojQTJu+PoCkRp3711L4FABWQjMduJgvKFUpsFYTzfOdSH+9uKqh2BU WXRe419McU05r9jZlA1Ep7aYfre7YmLZShydcHe1K5vApuD5nz9JAmtdT68EQoVophqE JbN2PLk5/lEJkNxnL7ay83Z0aMJGnvuX4R3IIjKz3KTm6TSn0cpNUJ42Z6EVqUSOK7i/ fUIl2COA4yyo7HOc36ldZxCfaxzj6RwoJxzPOA3E0vAnVHyWan8IMIMAYzRJDVXYf8ZZ EPcEuoxuuUDoxINO5DL5oOUtMe1V/47/UJbcQSdMmHdFf8JTjI6TOgSrJLgoV0GKBPjo afcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 69si3537781pgh.188.2022.02.17.22.46.38; Thu, 17 Feb 2022 22:46:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231267AbiBRGaO (ORCPT + 99 others); Fri, 18 Feb 2022 01:30:14 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231174AbiBRGaE (ORCPT ); Fri, 18 Feb 2022 01:30:04 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB3041CFA38; Thu, 17 Feb 2022 22:29:48 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 229CB67373; Fri, 18 Feb 2022 07:29:45 +0100 (CET) Date: Fri, 18 Feb 2022 07:29:44 +0100 From: Christoph Hellwig To: Arnd Bergmann Cc: Linus Torvalds , Christoph Hellwig , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, linux@armlinux.org.uk, will@kernel.org, guoren@kernel.org, bcain@codeaurora.org, geert@linux-m68k.org, monstr@monstr.eu, tsbogend@alpha.franken.de, nickhu@andestech.com, green.hu@gmail.com, dinguyen@kernel.org, shorne@gmail.com, deller@gmx.de, mpe@ellerman.id.au, peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com, hca@linux.ibm.com, dalias@libc.org, davem@davemloft.net, richard@nod.at, x86@kernel.org, jcmvbkbc@gmail.com, ebiederm@xmission.com, akpm@linux-foundation.org, ardb@kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org Subject: Re: [PATCH v2 07/18] nios2: drop access_ok() check from __put_user() Message-ID: <20220218062944.GE22576@lst.de> References: <20220216131332.1489939-1-arnd@kernel.org> <20220216131332.1489939-8-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220216131332.1489939-8-arnd@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 16, 2022 at 02:13:21PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Unlike other architectures, the nios2 version of __put_user() has an > extra check for access_ok(), preventing it from being used to implement > __put_kernel_nofault(). > > Split up put_user() along the same lines as __get_user()/get_user() Looks good: Reviewed-by: Christoph Hellwig