Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 17 Feb 2022 22:48:23 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Bastien Nocera <hadess@hadess.net>
Cc:     William Mahon <wmahon@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        William Mahon <wmahon@google.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add mapping for KEY_APP_LAUNCHER
Message-ID: <Yg9BN1wU87t5ddoC@google.com>
References: <20220217053354.1.I3a7746ad05d270161a18334ae06e3b6db1a1d339@changeid>
 <93e5dc0bbeb0b44c9b225946b3ab81d3af3a1789.camel@hadess.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <93e5dc0bbeb0b44c9b225946b3ab81d3af3a1789.camel@hadess.net>
Precedence: bulk

On Thu, Feb 17, 2022 at 11:35:24AM +0100, Bastien Nocera wrote:
> On Thu, 2022-02-17 at 05:33 +0000, William Mahon wrote:
> > The App Launcher key is used to bring up the Launcher menu.
> > 
> > This patch adds a new key definition KEY_APP_LAUNCHER and maps
> > 0x0c02a28
>  
> Is this a typo? It's not the same format as in your other patch.
> 
> KEY_DASHBOARD as used in the Mac keyboard drivers looks like a good
> match for KEY_APP_LAUNCHER. If not, it would be good to explain why in
> the commit message.
> 
> See 437184ae8bd1ef923a40b009e37801deae66ad55 for the KEY_DASHBOARD
> addition.

I agree that the spirit of KEY_DASHBOARD is what I think we want here,
but IMO neither KEY_DASHBOARD nor KEY_APP_LAUNCHER are good names for
this. Maybe we could use KEY_ALL_APPLICATIONS (and alias
KEY_KEY_DASHBOARD to it for compatibility)?

Thanks.

-- 
Dmitry