Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Feb 2022 08:47:51 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     William Breathitt Gray <vilhelm.gray@gmail.com>
Cc:     linux-iio@vger.kernel.org,
        Robin van der Gracht <robin@protonic.nl>,
        linux-kernel@vger.kernel.org,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        David Jander <david@protonic.nl>,
        Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] counter: Stop using dev_get_drvdata() to get the counter
 device
Message-ID: <20220218074751.3xjsxwy7s63jshwv@pengutronix.de>
References: <YfzPcyusGwAOkys6@shinobu>
 <20220204082556.370348-1-u.kleine-koenig@pengutronix.de>
 <YgHKekl9rJ2jH5j4@shinobu>
 <b9099ac3-a5fa-1aba-92a3-05a7212525ab@linux.intel.com>
 <20220217160308.oo3fmghapnvmummz@pengutronix.de>
 <Yg7de1ZlUJoNGYNa@shinobu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gk6av76w7atazn34"
Content-Disposition: inline
In-Reply-To: <Yg7de1ZlUJoNGYNa@shinobu>
Precedence: bulk


--gk6av76w7atazn34
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Fri, Feb 18, 2022 at 08:42:51AM +0900, William Breathitt Gray wrote:
> On Thu, Feb 17, 2022 at 05:03:08PM +0100, Uwe Kleine-K=F6nig wrote:
> > On Thu, Feb 17, 2022 at 04:48:50PM +0200, Jarkko Nikula wrote:
> > > On 2/8/22 03:42, William Breathitt Gray wrote:
> > > > On Fri, Feb 04, 2022 at 09:25:56AM +0100, Uwe Kleine-K=F6nig wrote:
> > > > > dev_get_drvdata() returns NULL since commit b56346ddbd82 ("counte=
r: Use
> > > > > container_of instead of drvdata to track counter_device") which w=
rongly
> > > > > claimed there were no users of drvdata. Convert to container_of()=
 to
> > > > > fix a null pointer dereference.
> > > > >=20
> > > > > Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > > Fixes: b56346ddbd82 ("counter: Use container_of instead of drvdat=
a to track counter_device")
> > > > > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> > > >=20
> > > > I'll pick this up and apply it to my tree.
> > >
> > > Perhaps late but I hit this same issue, patch here fixes it and I wan=
ted to
> > > confirm it.
> > >=20
> > > Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> >=20
> > I wonder if this patch is scheduled for 5.17. Currently it's not even in
> > next ... :-\
>=20
> I've got it in my tree. I'm sending a pull request for the Counter
> patches for 5.17 next week, so they should all be merged after that.

That's good. Still I think you could make live easier for your users to
find fixes if your tree was included in next. And in MAINTAINERS.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--gk6av76w7atazn34
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmIPTyQACgkQwfwUeK3K
7AkP9gf/S6BMwB67/1roz71SeE8tT9n/ekVqdJlZwHY39kowGvEe9yhKjiDb6qqQ
25OVlDPItAE91aBCgcwRsuouDm7NFUJrATH0jrLEU+4PxR22NIkiLcfyHPHNTac/
dlZYjooIj+QGCPuZgwa0VGhG7b/O0pGV1z6UQrp7ujkBHTZ2VaPOkdpnX8QVMtLa
pM4YKvDZUfxqT7YEhUQNqfl7RJM24cpBrnVvnFUGak0quLGiN6Os/bc+ldKKmdpT
jZr8GvA08EHO6XMg+RW01Zd1JX02MnspiQlpRxPRz1iMc4BNZ4AOYBLsqNovcXb+
oagqCoL0D80XZMk4XRROHPQuqUP9Iw==
=JzKJ
-----END PGP SIGNATURE-----

--gk6av76w7atazn34--