Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   SeongJae Park <sj@kernel.org>
To:     Yuanchu Xie <yuanchu@google.com>
Cc:     Shuah Khan <shuah@kernel.org>, Markus Boehme <markubo@amazon.de>,
        SeongJae Park <sj@kernel.org>, rientjes@google.com,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests/damon: make selftests executable
Date:   Fri, 18 Feb 2022 07:52:54 +0000
Message-Id: <20220218075254.11467-1-sj@kernel.org>
In-Reply-To: <20220218001017.3500673-3-yuanchu@google.com>
Precedence: bulk

Hello Yuanchu,

Thank you for this patch!

On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote:

> The damon selftests do not have the executable bit on. We fix that by
> setting the x bits on the .sh files similar to other existing shell
> selftests.
> 
> Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases")
> Signed-off-by: Yuanchu Xie <yuanchu@google.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/debugfs_attrs.sh                 | 0
>  tools/testing/selftests/damon/debugfs_empty_targets.sh         | 0
>  tools/testing/selftests/damon/debugfs_huge_count_read_write.sh | 0
>  tools/testing/selftests/damon/debugfs_schemes.sh               | 0
>  tools/testing/selftests/damon/debugfs_target_ids.sh            | 0
>  5 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_attrs.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_empty_targets.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_schemes.sh
>  mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids.sh
> 
> diff --git a/tools/testing/selftests/damon/debugfs_attrs.sh b/tools/testing/selftests/damon/debugfs_attrs.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_empty_targets.sh b/tools/testing/selftests/damon/debugfs_empty_targets.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh b/tools/testing/selftests/damon/debugfs_huge_count_read_write.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_schemes.sh b/tools/testing/selftests/damon/debugfs_schemes.sh
> old mode 100644
> new mode 100755
> diff --git a/tools/testing/selftests/damon/debugfs_target_ids.sh b/tools/testing/selftests/damon/debugfs_target_ids.sh
> old mode 100644
> new mode 100755
> -- 
> 2.35.1.265.g69c8d7142f-goog