Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Feb 2022 08:28:50 +0100
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     alexandru.tachici@analog.com
Cc:     andrew@lunn.ch, davem@davemloft.net, devicetree@vger.kernel.org,
        hkallweit1@gmail.com, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
        netdev@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v4 4/7] net: phy: Add 10BASE-T1L support in phy-c45
Message-ID: <20220218072850.GA12479@pengutronix.de>
References: <20220207092753.GC23727@pengutronix.de>
 <20220209151220.15154-1-alexandru.tachici@analog.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220209151220.15154-1-alexandru.tachici@analog.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Wed, Feb 09, 2022 at 05:12:20PM +0200, alexandru.tachici@analog.com wrote:
> > On Sat, Dec 11, 2021 at 10:07:49PM +0100, Andrew Lunn wrote:
> > > > +		ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE);
> > > > +		if (ret < 0)
> > > > +			return ret;
> > > > +
> > > > +		if (ret & MDIO_PMA_EXTABLE_BT1)
> > > 
> > > 
> > > This pattern of reading the MDIO_PMA_EXTABLE register and then looking
> > > for bit MDIO_PMA_EXTABLE_BT1 happens a lot. It is not something which
> > > is expected to change is it? So i wounder if it should be read once
> > > and stored away?
> > 
> > What is the state of this patches? Will you be able to make requested
> > changes and send new version?
> 
> I will come back with a V5 where I will add the requested changes.

I tested your patches with TI dp83td510. With some minor quirks on TI
side it seems to work fine. So you can have my:

Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |