Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Feb 2022 18:11:46 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
Cc:     linux-iio@vger.kernel.org,
        Robin van der Gracht <robin@protonic.nl>,
        linux-kernel@vger.kernel.org,
        Oleksij Rempel <o.rempel@pengutronix.de>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        David Jander <david@protonic.nl>,
        Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] counter: Stop using dev_get_drvdata() to get the counter
 device
Message-ID: <Yg9i0lvLAurmp3M+@shinobu>
References: <YfzPcyusGwAOkys6@shinobu>
 <20220204082556.370348-1-u.kleine-koenig@pengutronix.de>
 <YgHKekl9rJ2jH5j4@shinobu>
 <b9099ac3-a5fa-1aba-92a3-05a7212525ab@linux.intel.com>
 <20220217160308.oo3fmghapnvmummz@pengutronix.de>
 <Yg7de1ZlUJoNGYNa@shinobu>
 <20220218074751.3xjsxwy7s63jshwv@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RXQcv7FYYhz4E3ZR"
Content-Disposition: inline
In-Reply-To: <20220218074751.3xjsxwy7s63jshwv@pengutronix.de>
Precedence: bulk


--RXQcv7FYYhz4E3ZR
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 18, 2022 at 08:47:51AM +0100, Uwe Kleine-K=C3=B6nig wrote:
> Hello,
>=20
> On Fri, Feb 18, 2022 at 08:42:51AM +0900, William Breathitt Gray wrote:
> > On Thu, Feb 17, 2022 at 05:03:08PM +0100, Uwe Kleine-K=C3=B6nig wrote:
> > > On Thu, Feb 17, 2022 at 04:48:50PM +0200, Jarkko Nikula wrote:
> > > > On 2/8/22 03:42, William Breathitt Gray wrote:
> > > > > On Fri, Feb 04, 2022 at 09:25:56AM +0100, Uwe Kleine-K=C3=B6nig w=
rote:
> > > > > > dev_get_drvdata() returns NULL since commit b56346ddbd82 ("coun=
ter: Use
> > > > > > container_of instead of drvdata to track counter_device") which=
 wrongly
> > > > > > claimed there were no users of drvdata. Convert to container_of=
() to
> > > > > > fix a null pointer dereference.
> > > > > >=20
> > > > > > Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > > > > Fixes: b56346ddbd82 ("counter: Use container_of instead of drvd=
ata to track counter_device")
> > > > > > Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutron=
ix.de>
> > > > >=20
> > > > > I'll pick this up and apply it to my tree.
> > > >
> > > > Perhaps late but I hit this same issue, patch here fixes it and I w=
anted to
> > > > confirm it.
> > > >=20
> > > > Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > >=20
> > > I wonder if this patch is scheduled for 5.17. Currently it's not even=
 in
> > > next ... :-\
> >=20
> > I've got it in my tree. I'm sending a pull request for the Counter
> > patches for 5.17 next week, so they should all be merged after that.
>=20
> That's good. Still I think you could make live easier for your users to
> find fixes if your tree was included in next. And in MAINTAINERS.
>=20
> Best regards
> Uwe

That's a fair point, I'll update MAINTAINERS and set up my fixes branch
for inclusion in linux-next.

Incidentally, it looks like this is the only fix I have merged; I'll
submit it now by itself so we don't have to wait until next week.

Thanks,

William Breathitt Gray

--RXQcv7FYYhz4E3ZR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmIPYsUACgkQhvpINdm7
VJJCMQ//Wdh681Ssq3mGlMHywQtFBbf0m1/a5uYyzOjnvlCKcAGWyYnwGuFh195T
GSVHd+k8KszChljN2lSr2EQ6010sTslEt6eeg77KkglYZGJYzmHw4IO8oFvGCWtT
4AbGpEoL/NzXzhx4Gog5Xqui6bM6amoElVi4usUn5rk+n4Fdy3qA0UWM9nqotAn3
/nSYSxTllY5L3ysSseVsmFS7xJwYuKFz0j3SUBMs0rsZo2NKWoQrRFdEslQGADql
DvX5umL21rticnD0HJpasqeXT156/tdjmw/r7THcwo84fgHEuxyGZOfNrOyDYuJU
3irJENsE5fPJMstm3UozR2ePtAtya44zRQtGpogMxgqmEcd/fd8kdBB0lrm9ekwn
JELHRFgshNQuHdBm4R4whQglvTgJNt8RtrU8zsaDFxw4PlPIwvxOlJg0FLstYZ6b
putyrukmCmu+Gd+cybYyZkSKGcghBSCrgmJTTMLFk9VVahou+tC4kTDt5Z797f1G
kXX/cpbyVOMBZ/OOXmhEAdzZgnXr2PrlDIuAQG9KIvUcOuU39k58C9OVwCjgBSMd
VtSNEF5ZClbpi+MQUBOQXW6BkVWpwAh5DBAZNJOL9mpqJnX8Pbg9tBBEgsXnvmcF
8WW9cyuzOaz0DLXLIlvdOyNdoMs6QuAmNYSiDRUwkATiZa1qnzk=
=7/fD
-----END PGP SIGNATURE-----

--RXQcv7FYYhz4E3ZR--