Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <bfe385f9-b075-12e7-43c3-7957bf1b54bc@redhat.com>
Date:   Fri, 18 Feb 2022 10:43:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with
 mirrors
Content-Language: en-US
To:     Peter Gonda <pgonda@google.com>, kvm@vger.kernel.org
Cc:     Sean Christopherson <seanjc@google.com>,
        Marc Orr <marcorr@google.com>, linux-kernel@vger.kernel.org
References: <20220211193634.3183388-1-pgonda@google.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20220211193634.3183388-1-pgonda@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/11/22 20:36, Peter Gonda wrote:
> -	WARN_ON(sev->num_mirrored_vms);
> +	WARN_ON(!list_empty(&sev->mirror_vms));
>   
>   	if (!sev_guest(kvm))
>   		return;
> @@ -2049,11 +2071,9 @@ void sev_vm_destroy(struct kvm *kvm)

Note, the WARN must now be moved after "if (!sev_guest(kvm))" (before, 
num_mirrored_vms was initialized to 0).

Paolo