Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp1212476pxb; Fri, 18 Feb 2022 03:06:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxEioaswC7/7W7eMCr/Xg1n2xbGQQnwhxYBxq+8C6gGsA+N7ps7xSM10D2Lns/ffn1c/xVV X-Received: by 2002:a50:c44b:0:b0:410:cebf:161d with SMTP id w11-20020a50c44b000000b00410cebf161dmr7497601edf.259.1645182381664; Fri, 18 Feb 2022 03:06:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645182381; cv=none; d=google.com; s=arc-20160816; b=Y3ZnB/kXbBBEtiReplSbPwTVHh+wK51A/IP94xLcw6TtekqJcM0v32VIQb+olCSnvp gAeQ72cWJmjwVTU0GZ01A8dB0/VoDwJzlr8ff2WtzSEjfap19Mcj8FJt4p2bThpxZKc8 H4DXd8PMPly6PraRI7pZIow8ASaxGpiEojeKRosfPvUbpE0wcIuBiYcCGACpZl4g0raU V7+F3V74iB29jtq/cO+H27ehLgmPWeBx3eYRC+qREb1sPPUHfsxr6Id15JvSy+I+CfqD jwkxondeGlOkcI3e6oMISYwKG0XdyQRKJ3TsG6Bu9BvvfPlzNGDMRCWiN57t1T/huMtB l2aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xp8kbsKiIe7/saJ33XFFtFHA8P4vDlm2YHen9DygBY8=; b=0hlCcUk7OLdWFSoJ5lsWRcAhIYZAhISn47Hrrvwr8Oy7aeizpIv/xBBbjyLns1oJFX 9KeeSZ8/oLg7KOcjJ44hWAoROFExqOYEr8//xMJyEn4CNWz6yt6/pGNdK4BzhKmm9AIk D8p4gb4se35+TIuxJhUoE4Su0Gbs3y8WQt9TMmhq3iyarMkCO6LMtWCnsGcMfDf4RzRc fN5O68715ILZ1hmLNIuNN9fjAIFWMhbog9+V0srm/SjfWDonRpbcBycEGnsRJZzS7k0Y QVvDJAY88ELohYeBOGlanQmmVnddHuzNaOYvVdGkXnw1dnPzbqUy0fgzToqBZUusyEi4 tECg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw21si5177857ejc.311.2022.02.18.03.05.58; Fri, 18 Feb 2022 03:06:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codethink.co.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233648AbiBRJj0 (ORCPT + 99 others); Fri, 18 Feb 2022 04:39:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232871AbiBRJjY (ORCPT ); Fri, 18 Feb 2022 04:39:24 -0500 Received: from imap2.colo.codethink.co.uk (imap2.colo.codethink.co.uk [78.40.148.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8AC236685 for ; Fri, 18 Feb 2022 01:39:07 -0800 (PST) Received: from [167.98.27.226] (helo=rainbowdash) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1nKzjA-0005DK-49; Fri, 18 Feb 2022 09:39:00 +0000 Received: from ben by rainbowdash with local (Exim 4.95) (envelope-from ) id 1nKzj9-005E3m-R8; Fri, 18 Feb 2022 09:38:59 +0000 From: Ben Dooks To: linux-kernel@lists.codethink.co.uk, Johannes Berg , linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Emmanuel Grumbach , Ben Dooks , Neill Whillans Subject: [PATCH] rfkill: define rfill_soft_blocked() if \!RFKILL Date: Fri, 18 Feb 2022 09:38:58 +0000 Message-Id: <20220218093858.1245677-1-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If CONFIG_RFKILL is not set, the Intel WiFi driver will not build the iw_mvm driver part due to the missing rfill_soft_blocked() call. Adding a inline declaration of rfill_soft_blocked() if CONFIG_RFKILL=n fixes the following error: drivers/net/wireless/intel/iwlwifi/mvm/mvm.h: In function 'iwl_mvm_mei_set_sw_rfkill_state': drivers/net/wireless/intel/iwlwifi/mvm/mvm.h:2215:38: error: implicit declaration of function 'rfkill_soft_blocked'; did you mean 'rfkill_blocked'? [-Werror=implicit-function-declaration] 2215 | mvm->hw_registered ? rfkill_soft_blocked(mvm->hw->wiphy->rfkill) : false; | ^~~~~~~~~~~~~~~~~~~ | rfkill_blocked Signed-off-by: Ben Dooks Reported-by: Neill Whillans Fixes: 7cf800f46e07e6b75a43036c4389d6ca717fd017 ("iwlwifi: mvm: don't feed the hardware RFKILL into iwlmei ") --- include/linux/rfkill.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h index c35f3962dc4f..373003ace639 100644 --- a/include/linux/rfkill.h +++ b/include/linux/rfkill.h @@ -308,6 +308,11 @@ static inline bool rfkill_blocked(struct rfkill *rfkill) return false; } +static inline bool rfkill_soft_blocked(struct rfkill *rfkill) +{ + return false; +} + static inline enum rfkill_type rfkill_find_type(const char *name) { return RFKILL_TYPE_ALL; -- 2.34.1