Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7f5341e5-9d00-fca6-9def-b78282fc86ba@intel.com>
Date:   Fri, 18 Feb 2022 11:32:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking
Content-Language: en-US
To:     =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>, <intel-gfx@lists.freedesktop.org>,
        <dri-devel@lists.freedesktop.org>, netdev <netdev@vger.kernel.org>,
        "Lucas De Marchi" <lucas.demarchi@intel.com>,
        Chris Wilson <chris@chris-wilson.co.uk>,
        Eric Dumazet <edumazet@google.com>,
        Chris Wilson <chris.p.wilson@intel.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>
References: <20220217140441.1218045-1-andrzej.hajda@intel.com>
 <20220217140441.1218045-7-andrzej.hajda@intel.com>
 <Yg5gJfSJCCaY5JYs@intel.com>
From:   Andrzej Hajda <andrzej.hajda@intel.com>
Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298
 Gdansk - KRS 101882 - NIP 957-07-52-316
In-Reply-To: <Yg5gJfSJCCaY5JYs@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dHBJYUJlUDcwc0Y3bHBrSXFwcWRMTFRvUFhUZlVWVTNIS3h3VGpsM1RwckJh?=
 =?utf-8?B?L3dVc1FON3VBSmNFaU5oS2xOaG9wdFBoajJmY3NMS2JXOG1zdm04b1hYN0Fh?=
 =?utf-8?B?OUh3YWE4eDY4R0hxd0hvM3hoclVFTG1RSnpyeUg1dEFuSy9PWlQ1eDI2VExh?=
 =?utf-8?B?ZzJYZGxPVTdkRzN6K0FkQXVmYW5WZnR5ZGdRMTE1RnVjc1M0dklEcmtvWThr?=
 =?utf-8?B?cm9RT1BiN1haREV6WHJRczk1ekZqQ3R3YnhqTkxoRE9OTlJEMkZUYVowM1Uz?=
 =?utf-8?B?N0JuZjArRWVLOGttNktxQ3VsVkp4dkFlL1VEanY3dWdsZjBxNXQ4VndRS1do?=
 =?utf-8?B?dnhwNHlWQ3VwVDdXTGp2Wml5SXJnTVY2THFRM1B4dXh0OERCS1FCdlNLbXpZ?=
 =?utf-8?B?TjRMcTEyZm40eW1wc05aVEt1bGU4dTBLQmNGdWt2Ui83aGJvTC84QUE0WmUw?=
 =?utf-8?B?Sk14KzMrQ01pbEoxbDh3V2xSMXlKWk9HdGtWajM1ZERzbWYrSFJ4Q1VPK0cy?=
 =?utf-8?B?eEFMOXc1NVlYaDJXR3cyZDVabUc3dGs3Q3dxalZnMTA5M2g5Ymo3cW4xZ01y?=
 =?utf-8?B?UDFCL0w4R0ZaL3NkeGRNT1VGUUgvY1JtQitNdUc1K2xna0RPNGs3cGhobmdp?=
 =?utf-8?B?ZmluOXdwZm1CYVE2ZUNOWHB3WExqTnpEU0I2SmdsbFgvZldFWmpRaDFPVzBO?=
 =?utf-8?B?bVpkc1ZmTzNLVVllRThVTTZ2OWJrS0d2UGlCdGxhcUJCcTNDd1cwR1R3bDN5?=
 =?utf-8?B?QnhRVHRPSTY5RXlLaVRzZTk1SXkrVE9rYWFyemFVQXhTUHhXZXFnbkpKLzBw?=
 =?utf-8?B?VkhEdVkwTThNNVU0cy9BWXNnMG1OcXBNMkVtRXlCa2NKUWRnREU5VkdBWXdU?=
 =?utf-8?B?RHE4NG1RVC8vWWRQSXZNeXE0MkpRRFcrQ2FsbGR5UElKRWZjWUxZYXZCd0g5?=
 =?utf-8?B?NS9jZ0NsTEMvbWFXcnArdGZ2eVVzbVBGSjlQK2luNyszbHZwanlySHM5c1Q2?=
 =?utf-8?B?S3pvay9EQ1l2bjhNM2lqMFpTSjdnUGxqcm02bmYyUkNaUGZxVFpPdUlUSUNX?=
 =?utf-8?B?bzNmdXptK0RaWTdacm0wSjNLcVlNeVZkZjUzS1JiUGZITTlkSzlpaFdOZ3Zt?=
 =?utf-8?B?b3c3RklYWE4rcGxWd0pqNFl4NUtPZmZwdmczY1BueVJvZmEzYXJXaFUxb05u?=
 =?utf-8?B?OXlTZU0vajVubFpwbWEzNDdONzJhN1hwS3BsVnBWRkh3clBKVE52RGkzY2JO?=
 =?utf-8?B?ZGlZZU40em9ia1Q2S2JMSnh6ZGF6bVl2bmlIOWRScnd6SHNjTXo1azAyTW9C?=
 =?utf-8?B?d3RVREwrbzJ4R2U0WXhEZGhWMlhHVndORThYK21QMFBJNkdsUk01NVRZb0Z6?=
 =?utf-8?B?dlBPNVlhcmFyYkpYL1U2c3ZPU1Z3L3NvaUxqSDBKdU1yRVBsQVYvUisrQ2dP?=
 =?utf-8?B?dTV0aWNadCswaU1kSG1KckpmZkdMZzZ2aUlZeEdXNG5HREx3eUlnVENuUVdw?=
 =?utf-8?B?b2tPb05zd0JSNXFDZ1ZBNzdRWUpKVXdpZmUyUE9wWVZqdFIvQXFGN1VBRlIx?=
 =?utf-8?B?WVdTMXBwYjBma3V2ejhkMlZKY3NOVzBPL2pLaU43REYxWit5dUViUWhTZFpI?=
 =?utf-8?B?ZjNwY1lzc2ZyWTJvSVN1T3BtS1dWUUJQN3BnOEQ2K2FaeVhXVG1OOStUdGo2?=
 =?utf-8?B?WjRSd2ZRUzZpWTE3a2l5RGdWOTEvejB2ZEZTWk5UdlhHMnhMckpvRWNtenJG?=
 =?utf-8?B?ODF4K29qTXdmeEFYWVdLakgyQ3Bkc2pLQWZkRTVQc3ozbG42a0Iyd0lWdGJV?=
 =?utf-8?B?L0U2MG02R1VCbUQ3cDY5cFR2bFoyWWRzbThmL0NNZ1lXQyszRDhKY2dUNURM?=
 =?utf-8?B?WUZoZkdhYWhSS0dUWG9OeGxkaWpWNzNBYTNWdk1icnlVU2sxSTk1YlZCeG9y?=
 =?utf-8?B?Y08vd1ZUaHkzNUhnS1A2VzZ2ZkN1N0prSDFCeFhhTkZhMjVHRWdSM2dmUklj?=
 =?utf-8?B?SHlpYmhpWlE3ejFhVzkvRlNWdEFNK3JVTzh4d3FkWWp4WTd5eU1FTTJybTNS?=
 =?utf-8?B?ZG4za0pVZjNyMkRGSnUxY05wYUpwZFFVQXhwdWdzMFlmd1Q1Z2hjQkU3WDY0?=
 =?utf-8?B?cjUvb1FFbHdPY3MyOEhNTEQxa3N3VVhGNWZ1WTh4TldjUnZ1c3VBdVVCOVlL?=
 =?utf-8?Q?1vU+fGdNNQAd6NUFmqJCcMg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d4423cc-5b72-4563-4510-08d9f2c9eadd
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3180.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 10:32:09.4384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w7hfOIGMzf24HlDhdwgVDG9uXH85PYTSLZmnLDd1BwnWN7PwOXKEJTc/C8zrnMbu75Oo0BWtXy9KiBUWgsiZeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5509
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 17.02.2022 15:48, Ville Syrjälä wrote:
> On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote:
>> -static noinline depot_stack_handle_t
>> +static intel_wakeref_t
>>   track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm)
>>   {
>> -	depot_stack_handle_t stack, *stacks;
>> -	unsigned long flags;
>> -
>> -	if (rpm->no_wakeref_tracking)
>> -		return -1;
>> -
>> -	stack = __save_depot_stack();
>> -	if (!stack)
>> +	if (!rpm->available)
>>   		return -1;
> no_wakeref_tracking != available

ups I missed this change, will be more careful in next iteration.

Regards
Andrzej