Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
To:     netdev@vger.kernel.org
Cc:     Taras Chornyi <taras.chornyi@plvision.eu>,
        Mickey Rachamim <mickeyr@marvell.com>,
        Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
        Volodymyr Mytnyk <vmytnyk@marvell.com>,
        Taras Chornyi <tchornyi@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH net-next] net: prestera: acl: fix 'client_map' buff overflow
Date:   Fri, 18 Feb 2022 14:29:11 +0200
Message-Id: <1645187351-8489-1-git-send-email-volodymyr.mytnyk@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YgjHRzPXPLsrnHPh9vloNnZrjjeDwLqMQpY6eD4re6ld3nE8nk7rX685dJXS?=
 =?us-ascii?Q?MFEv/1lK5TKKPyi+Hhp27vUvdq0/t9fhXTkT2/EvqVWnjFqNljvmEF9BxXZx?=
 =?us-ascii?Q?6BIGtDC5eBw2VXiPdiMxMcTZEikwlGxHoDLOHAJ+4N7FtCUKIyTFmKRAu+N7?=
 =?us-ascii?Q?cqovTMlrfIDBi1sByOeIVwvnFC/lVIQiCYAT+6WxtggHTV9Hbx0oopJykKMP?=
 =?us-ascii?Q?8uWBvDj6MGYzoc96dP18gJx9Ql7/JEGUe7iA//VTVvR+bA4Qs8V/GPGJviQN?=
 =?us-ascii?Q?JDmttir6KQ7plBHbWT7mFuVcGkOjiI6wdvuu/Db72t/hAizAcXGUvQ964ZZh?=
 =?us-ascii?Q?pDExboxwZrkOXJ5A67bwTamtIsRsb4awuSP793fEVCNaV7UrhojzoowsSyau?=
 =?us-ascii?Q?+txoU8LFiANjoMfCOCtHZp/jJdTwhk2YSJTkiYmWzhIEcrXmasWd7N5zHgqr?=
 =?us-ascii?Q?efXMR5ZXJ02pe1f/h9oRUIt2cm9dr0/n3tdYEsFDhKHo3bGUqI1MxZsvYv7c?=
 =?us-ascii?Q?1iZwd8OKBTShQfKE6GFYdzeQUWJZYX+jN65qUiDoeDBr9u4BhDzvlDhjsH42?=
 =?us-ascii?Q?t97FwFvGw8SGXqFRlul4oUJnEsjE5keVqBSWnawaZBI2yCUeQieMOX2OpaTj?=
 =?us-ascii?Q?qHqX5waJN2haJQHB1ztMJSZ2WH7tKupgJ+32imG3nrEPo0C2G7guekKRZXH6?=
 =?us-ascii?Q?U4Vbs3BFvCyCS7LJsZP0yWxYzbfbflKPdVhhPlSlnNaH5NTxIjwPo7R1fHqF?=
 =?us-ascii?Q?mul7At2jHLpAJnE62ufembx6oGTR3U6r6Sn836fCBaB+9huoJeVV0PWwDdo+?=
 =?us-ascii?Q?DqxScerKZfs+WBW7bp1m9uwvPZqpXUd6G/ekc7Wq/WjhotSCu3aj/yn+AAMB?=
 =?us-ascii?Q?94V5Q6jF4jw131G8ZapazIjaDRFxDLEX3X9/cg/GGXWFoxUxCiFO5Gs5X6Do?=
 =?us-ascii?Q?QctcPp2kYHBpWY8YigVPSnsqWqW1lyZwBUfpnFo+MsjhjrsqRyBC1PtKKWnQ?=
 =?us-ascii?Q?6Yi69ua+vsaXACdZMsucpGd8YQsfDdOuu6epYARJ5VFjyUrI87rz570VP59b?=
 =?us-ascii?Q?bTd5lSt8lIMohZvej5yujFaWM/3IoPc5upvTu9Xx6bFJe6/BSnpU9Ct60K3E?=
 =?us-ascii?Q?I+rn2ky+QwiFFrW3nymIY2rxYPfdI0Y3tZIhbAZEWZAfhJlMUwTlCgtIlGbG?=
 =?us-ascii?Q?kVpPZ/0NpeZ82+9K4zT54foeo2MvnOezFZlzjdVpukGCulUJiYcktEPY90r6?=
 =?us-ascii?Q?NpdRp9iegh15vu33+ikXw8BbU+ekatvZmvB6GtDtD22Y3byLq0R8pEtRYeHs?=
 =?us-ascii?Q?nW/sjgJkokoZjBoenuRJk9X5K2oLrRBwEmo7lCx2txnHSE9STAvJvybdRRyF?=
 =?us-ascii?Q?K91dcd75OiW061PwRLmbm+3r2HytiM4dgazwKY7uDXcBxzuX/cxj2ssjLruN?=
 =?us-ascii?Q?qNxZhqw2aHM/d3UefH0iTqoaI2xv+Tdr4asIOsqyWycEyPQDgyk6+OKPY0/S?=
 =?us-ascii?Q?6wePFrm9HQqu3VDkn7P01YmQruzMEwcntMfb53IQiGbU2k8oWV3FyqWQZJap?=
 =?us-ascii?Q?64HzmOJIVu4A/Xn2nvk6KaQdWtMn1gS49JXzQeRkcTwle4R6OSE18bSJussP?=
 =?us-ascii?Q?mS+Keof8gLIbIIPVnS2mutQRUCreUIJNYz/aK846fCooDDhD5NM7NEpHU7lc?=
 =?us-ascii?Q?6MxBVw=3D=3D?=
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: f6903b9c-ef44-461e-c5c6-08d9f2da4954
X-MS-Exchange-CrossTenant-AuthSource: VI1P190MB0734.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 12:29:19.9688
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WmVEpgCPfF0g2Zckinr4hhREFqwqPJUUXV5y3/HBTROkWlOAvJHryfDCUVK/p5Y0+5ELPz/pOSDMnBcsDQVwirsRE3d7a1cughq/2Z6dbEY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0571
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Volodymyr Mytnyk <vmytnyk@marvell.com>

smatch warnings:
drivers/net/ethernet/marvell/prestera/prestera_acl.c:103
prestera_acl_chain_to_client() error: buffer overflow
'client_map' 3 <= 3

	prestera_acl_chain_to_client(u32 chain_index, ...)
        ...
	u32 client_map[] = {
		PRESTERA_HW_COUNTER_CLIENT_LOOKUP_0,
		PRESTERA_HW_COUNTER_CLIENT_LOOKUP_1,
		PRESTERA_HW_COUNTER_CLIENT_LOOKUP_2
	};
	if (chain_index > ARRAY_SIZE(client_map))
	...

Fixes: fa5d824ce5dd ("net: prestera: acl: add multi-chain support offload")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Volodymyr Mytnyk <vmytnyk@marvell.com>
---
 drivers/net/ethernet/marvell/prestera/prestera_acl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_acl.c b/drivers/net/ethernet/marvell/prestera/prestera_acl.c
index 06303e31b32a..e4af8a503277 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_acl.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_acl.c
@@ -97,7 +97,7 @@ int prestera_acl_chain_to_client(u32 chain_index, u32 *client)
 		PRESTERA_HW_COUNTER_CLIENT_LOOKUP_2
 	};
 
-	if (chain_index > ARRAY_SIZE(client_map))
+	if (chain_index >= ARRAY_SIZE(client_map))
 		return -EINVAL;
 
 	*client = client_map[chain_index];
-- 
2.7.4