Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Kavyasree.Kotagiri@microchip.com>
To:     <michael@walle.cc>
CC:     <Manohar.Puri@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <alexandre.belloni@bootlin.com>, <arnd@arndb.de>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <Nicolas.Ferre@microchip.com>,
        <olof@lixom.net>, <robh+dt@kernel.org>, <soc@kernel.org>
Subject: RE: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291
Thread-Topic: [PATCH v4] ARM: dts: add DT for lan966 SoC and 2-port board
 pcb8291
Thread-Index: AQHYHaYU1qtS5sG/10aA2sqGSWL+96yLj0MAgAD4oLCAAAQRgIAAFAoQgAARrQCADJaDQA==
Date:   Fri, 18 Feb 2022 12:28:06 +0000
Message-ID: <CO1PR11MB4865B205DF4490D37E96524792379@CO1PR11MB4865.namprd11.prod.outlook.com>
References: <20220209111318.21112-1-kavyasree.kotagiri@microchip.com>
 <20220209184600.1230365-1-michael@walle.cc>
 <CO1PR11MB486534A2987684CC7402CE06922F9@CO1PR11MB4865.namprd11.prod.outlook.com>
 <97bcfa4417d5f8c41cc6aa1e411c8747@walle.cc>
 <CO1PR11MB4865E913D083C1D80D4E1F80922F9@CO1PR11MB4865.namprd11.prod.outlook.com>
 <b98f40575f88a0bbf205d628f73cccac@walle.cc>
In-Reply-To: <b98f40575f88a0bbf205d628f73cccac@walle.cc>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?90xxLg6iNzQpxCTehte42yVhZC0KgCsCBe+JmjnhPAdrrNt6h6fxn7BO1Z50?=
 =?us-ascii?Q?IL9M5l+HsyHOHBuaqBAfDqzDEy399TeUMJLAhqADA3NP5++KTWR19+5cXWBB?=
 =?us-ascii?Q?3Au2JjgOds1qUKNQK8gymJ+6zqil43QRJ2VkZ/u+s18WCgsn32GD2ZREGfyB?=
 =?us-ascii?Q?e8oYTYk4BwFlL8mtF1Udx9toPltOXPzfIUcaEdOPn4s0OXiW4Eu7mee2zKR/?=
 =?us-ascii?Q?d3CSMVSYRkTzT22KNnadW+CR0ygq0WcDJ8dcVbtrRi+XRz7O7nKVPASjpWg2?=
 =?us-ascii?Q?IPB2yE8OUmdydoot/j/hIFKPCUUfVwc5ik1nxFzIXKNc+zlrsHBc+pPrdXf2?=
 =?us-ascii?Q?dIZdVo6vBi4Qj8+shPumQ+5g9yCdYyuIg+UZ3w6sVFPtjlGvNC09S4Mhf7m4?=
 =?us-ascii?Q?70afHkWi15CuDDRhzrgiACmEB4IR6wfbpwXfgcTg9pQMtl4SdIKaHdHLa3Eb?=
 =?us-ascii?Q?IFyvPNbc4LPn07NSaM1Ix0gDQ3cEyymgjeA84zc5D4zRtGVgrhyKdtB7BK23?=
 =?us-ascii?Q?/MIR0N9terrnCxpLU3u+Y1ZONH7G8duzzLIgqeBJ9BbWIhKZp/Is2Y87vFS4?=
 =?us-ascii?Q?Bk2L0+3MdExPcgEURArmeyEJsZ8UQpWMVvpBSCWhHI1pAFRZVaP/tvddUSoo?=
 =?us-ascii?Q?5pJ3X0A0cq60Y6F2F4wMC3RSs7yChGdb5/XihR/ZbjG2BSaBBx7rLdtsuwHe?=
 =?us-ascii?Q?niN5xsbKOYpb8O5W5lubo/0stXZRCE/E27Ax47ej9k/gH9jwFo/SrXyg6/vf?=
 =?us-ascii?Q?qBRsbKcYq9V+8V26KU0dLclXQC3Z94f4ZluYmGJPMvUEByuxJXP7k8iZaAwu?=
 =?us-ascii?Q?Acb+UhQX/9iSANYLGiEU3PluQkKoa977AkYqg7jjSO53DkgSV7vFT0H31gh8?=
 =?us-ascii?Q?MIv6kyd2otmrSo9ARCC5rIYrTTJpkDT3rHwII+HyEHBGDG4LyMcqVayXquF+?=
 =?us-ascii?Q?N1kXIOLHax0DUYJtGpLkgc6TOkWLWu1MyRDSLdrRQRzIJxVy+0sVhcZCzBk9?=
 =?us-ascii?Q?aGMzlxGf69zjYcCeyKF7sfKJG8jGdVHr93lmKVKE40beYxKa6qsR8x3j0L01?=
 =?us-ascii?Q?f9E/QbrBXMVOU0xzzZFvrACJDztPs2T2Lt4flDmoCIcC+4s06vhlXDs2Xfgf?=
 =?us-ascii?Q?AI7mtZ2yFh7v3wRij/sMOl4g1tKqU8dGnXofaXWxYWscfV+x3ljkCVxoji5T?=
 =?us-ascii?Q?n6Na4bJzAqb11P3/ptC3WTibs66bd8Vi4ddDEenAnA9XnFZhhd30+4eG4R2F?=
 =?us-ascii?Q?I7aHRpKg7nOR9aSsypjGbHPMsa6aOcLhuEPBpT+fN20hhzCISvYFlL9Dv7je?=
 =?us-ascii?Q?cu4OGuXja25NCeH7qGcbYtf5wseJZiIl2s3Y/0rfWpeGWBrw3dv+Vgw8iWvP?=
 =?us-ascii?Q?yxi3okIpRF03mhSEL/laNe4ZlVxYyQrStV3G17iH9sahPV50wd/8ynqPdVjM?=
 =?us-ascii?Q?KbKKYB1el30ro/CwO7keoTZ/4+PfmidZ6poIdXCEjhrOx9TMv94PyPfFY01v?=
 =?us-ascii?Q?nh13Mr9wXD9iMt83mTSUNhUofou/9NnWmcOOB8MKl5pMr/LR+qfFjeAVmxUm?=
 =?us-ascii?Q?E0Lz5ByWHOe17yRLss2xiMljo8GjSErFvVzw0o0BSCueOQ2xzds6ncrX9YAz?=
 =?us-ascii?Q?0aYl1j6fGdbRVBbd9lzFBMXDDXAaKBHmPwaJEuGMtudKDnBMMAHKcXYkEli1?=
 =?us-ascii?Q?HRYnvLslzoNkNshsN0wX2TQ/j7vDsxpyJP+5IMVwVnzqQbBI?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4865.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d88acbc-0273-40e7-a85b-08d9f2da1da4
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 12:28:06.2821
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mDlrhxyFumXh4yranC41nIK9MCMRZI41QKqxIjkBp20sQsMkvh/m0RBWmswbb58VyQDfQb9xe5yggHFUh2j3uqYBYiDRIjCPVneElRtx4WEMXBR/6gD+XnHysOAaGnBy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1774
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> EXTERNAL EMAIL: Do not click links or open attachments unless you know th=
e
> content is safe
>=20
> Am 2022-02-10 12:52, schrieb Kavyasree.Kotagiri@microchip.com:
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> >> the
> >> content is safe
> >>
> >> Am 2022-02-10 10:40, schrieb Kavyasree.Kotagiri@microchip.com:
> >> >> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know
> >> >> the
> >> >> content is safe
> >>
> >> >> > +     clocks {
> >> >> [..]
> >> >> > +
> >> >> > +             nic_clk: nic_clk {
> >> >>
> >> >> What does nic_clk stand for? If I had to guess, it
> >> >> has something to do with network. But..
> >> >>
> >> > NIC clock is the clock used by AXI, AHB fabric and APB bridges which
> >> > connects all the peripherals.
> >> > It is named so because the AXI fabric is based on NIC400 IP from ARM
> >>
> >> Ok, thanks for clarification.
> >>
> >>
> >> >> > +             watchdog: watchdog@e0090000 {
> >> >> > +                     compatible =3D "snps,dw-wdt";
> >> >> > +                     reg =3D <0xe0090000 0x1000>;
> >> >> > +                     interrupts =3D <GIC_SPI 38 IRQ_TYPE_LEVEL_H=
IGH>;
> >> >> > +                     clocks =3D <&nic_clk>;
> >> >>
> >> >> Btw. can we disable all nodes by default and enable them
> >> >> in the board dts files?
> >> > I would like to have only board specific nodes enabled in dts files
> >> > and rest of them in dtsi file
> >>
> >> And how do you know which ones are board specific? E.g. I would like
> >> to add our board which is also based on the lan9668. Maybe I don't
> >> want a watchdog (or whatever node). Of course I could use
> >>
> >> &watchdog {
> >>    status =3D "disabled";
> >> };
> >>
> >> But IMHO opt-in is better. At least thats what we are doing for
> >> the layerscape over on arm64.
> >>
> > Basically, I am disabling only the nodes which have pinctrl settings
> > in dtsi file
> > and enable in dts to make sure there are no conflicts on pins on the
> > board.
>=20
> Thats not what I'm asking. I would like to see *optional* nodes
> disabled by default. Whether the watchdog is optional might be
> debatable, but what about the usb controller and the qspi
> controller? They don't have shared pins AFAIK, so according
> to your rule, they will be enabled by default and each board
> which doesn't have anything connected on these pins would have
> to disabled it.
>=20
> Please keep in mind that this .dtsi will also be used by boards
> not manufactured by microchip.
>=20
I agree with you - "disabling optional nodes in dtsi"
I have gone through all the nodes.
Confirmed and moved enabling optional node watchdog
to dts file.

> -michael