Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp1466918pxb; Fri, 18 Feb 2022 08:20:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhwBKngMTFGMIYSRgBsqZfBomXzVI6sqdF/l6ovYXC5hgAcVAMMQlynjGwWA0BLV63iGAU X-Received: by 2002:a63:de46:0:b0:364:cad7:bf3b with SMTP id y6-20020a63de46000000b00364cad7bf3bmr6949310pgi.491.1645201206081; Fri, 18 Feb 2022 08:20:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645201206; cv=none; d=google.com; s=arc-20160816; b=jePO2hrOZdsfC/3y+gGWsbqE/JblW7uv4APmO+fjMBdtTZ5zGGk9eY7hjqfckHqv8/ te7QKaX0gDdqi2qC6L+iidb56dza7jRredvrXy9wfD1HosR8ct7+acvCkOB3xqqV41/3 L6lFJ23fd7ZvF54m2YJNRoJWaJAsAXSMdSTB0iAfevgm+4+0isjrKIcMrFIbrQYD8tPn uv39CDO0oNmA0FCKRGIGrBa/Bu3eQsAK1CSH+YHtpdlCUDzrNiF+XtBVcsOY2n5ksEP5 hzrI/cJa57hh3cRkYeXqdmS0/CPMhldlpFdDeAps653f0voZaGPxouZS9dqiTWxxeRFZ EKMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=doT7bK7EPrJiz241mVjN8JSE6X0c4y1Cn7yH47MmQuY=; b=o5fFmzSiuebXARgINFhjlONM+tQ1l6pfMJYijye8RtB15QR57DUCgyBsOaefTk1HRA p/qK247ajp801Q54BxGPligA39qUhImoFGJBdYUVT+QfySnzOviHHEv+2isUo/f/dEuT 2VmQ79z7+xtxUoepPbDAE2teiQz9PxXkjFOylNEK279ybbZtbGL58pfa2fcsYEXHPOMB Mrk39ai2s4VANhvjhigGo2EytMooZz08oBYI8BdQYzccgnMmf9CufPwIcS+SefgASF4G EML3Mysjs+eWAUt4qvwiEsVFhpEwCLchgYVOnwc0ozcX5ZBL+zGrGfgGSG22qSUHatz+ gbUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=f7IrV8Co; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nl17si4264513pjb.178.2022.02.18.08.19.48; Fri, 18 Feb 2022 08:20:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@paul-moore-com.20210112.gappssmtp.com header.s=20210112 header.b=f7IrV8Co; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237135AbiBRPos (ORCPT + 99 others); Fri, 18 Feb 2022 10:44:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231462AbiBRPoq (ORCPT ); Fri, 18 Feb 2022 10:44:46 -0500 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB6C022B709 for ; Fri, 18 Feb 2022 07:44:29 -0800 (PST) Received: by mail-pf1-x42c.google.com with SMTP id x18so2606426pfh.5 for ; Fri, 18 Feb 2022 07:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=doT7bK7EPrJiz241mVjN8JSE6X0c4y1Cn7yH47MmQuY=; b=f7IrV8Co4YLWgbQabeAxKnaaARwhRRuipRCEkgrAJCQqP2XFBjrXQKuLiqPrbblMp4 1I0PyweE1qWbuBRwiem9GlWvoesOq6Y1GB8AnDJbzrRXaD1VWQKp8irajqq+k55dCKAi CseUDopHDjNGPOjBaX9WvpduIweYhYqPDAMXxxYv0yiDD8iPLrA7BZIetCe3CCIYdVYV ASZLZRL6vD/Zv40jqnzmkhX/ZXHdMbZSSn8xdx8/UI1a++gVGYKlWrJhfahzStHzBbVt iFKohUn9z3TIl5lLqD6/ZqoBkVkbxJ6dRJy+TTq14nDy33ykAI0H/nBHragcZH98I9mN Pgvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=doT7bK7EPrJiz241mVjN8JSE6X0c4y1Cn7yH47MmQuY=; b=T8bXt/YviUCX7d1FpIUrEM6TH0sPTiOcPeyy+DX5ttJNSEl/U2dIRkvYLtXLiMQbaW 1hsN8ypARWkVnx5T2la2oeYFTF+c27/w8yeNnSIdCNKR15OPk1XbK7R38XCrhKXfKNVp x9dKFW2mDuJZwMLwSmBa5We9BXEUVi4wh5u0ZuyvAlgeP0GsMbtErQo9pmi7V2TkUDrL y7oCgQiLsz8btV3zprwxFDvamFagWFqSV7BvsenUITBhpOqcpay9KZgLJY6WH0VsgKOz bxM5zvnOZSYvaWEkJpvRsiP4fhFQIgefob9XyxCpeLplHopGd37+fFkLhD77/w/nuUPv 4WFw== X-Gm-Message-State: AOAM533Y8e4Ql1EbBRAuX864bw3g9Ef0xDOOO6FtSzlb8m1XAMMTZKZS 02jUCTHeGBdclP23LKWPtHaE48UQ8iGb2735w8Pt X-Received: by 2002:a63:da4d:0:b0:36c:2302:1940 with SMTP id l13-20020a63da4d000000b0036c23021940mr6764465pgj.261.1645199069118; Fri, 18 Feb 2022 07:44:29 -0800 (PST) MIME-Version: 1.0 References: <20220217142133.72205-1-cgzones@googlemail.com> <20220217142133.72205-5-cgzones@googlemail.com> In-Reply-To: <20220217142133.72205-5-cgzones@googlemail.com> From: Paul Moore Date: Fri, 18 Feb 2022 10:44:18 -0500 Message-ID: Subject: Re: [PATCH 1/5] selinux: drop return statement at end of void functions To: =?UTF-8?Q?Christian_G=C3=B6ttsche?= Cc: selinux@vger.kernel.org, Stephen Smalley , Eric Paris , Nathan Chancellor , Nick Desaulniers , Ondrej Mosnacek , Serge Hallyn , Yang Li , Austin Kim , Lakshmi Ramasubramanian , linux-kernel@vger.kernel.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 9:22 AM Christian G=C3=B6ttsche wrote: > > Those return statements at the end of a void function are redundant. > > Reported by clang-tidy [readability-redundant-control-flow] > > Signed-off-by: Christian G=C3=B6ttsche > --- > security/selinux/hooks.c | 2 -- > security/selinux/ss/conditional.c | 2 -- > security/selinux/ss/ebitmap.c | 1 - > security/selinux/ss/mls.c | 1 - > security/selinux/ss/services.c | 2 -- > 5 files changed, 8 deletions(-) Merged into selinux/next, thanks. --=20 paul-moore.com