Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?ISO-8859-1?Q?J=E9r=F4me?= Pouiller <jerome.pouiller@silabs.com>
To:     gregkh@linuxfoundation.org, dan.carpenter@oracle.com,
        xkernel.wang@foxmail.com
Cc:     linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        Xiaoke Wang <xkernel.wang@foxmail.com>
Subject: Re: [PATCH v2 1/2] staging: wfx: fix an error handling in wfx_init_common()
Date:   Fri, 18 Feb 2022 15:09:49 +0100
Message-ID: <1989597.O86Mz80lD7@pc-42>
Organization: Silicon Labs
In-Reply-To: <tencent_24A24A3EFF61206ECCC4B94B1C5C1454E108@qq.com>
References: <tencent_24A24A3EFF61206ECCC4B94B1C5C1454E108@qq.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?aTTIxJ8YwMaIy7gE4UlyaVXVakQ3+GgzzHhf33Uy48Ad6HoUo5QrAvoqhR?=
 =?iso-8859-1?Q?zinjQwqKOUGKcs4HSbcT+AEN7987I3sj0WioCDnSJZf9rxYlqkjHFFZPcR?=
 =?iso-8859-1?Q?tbNYhbZLP8Ct6yDB9+TZdiG03Su1Oo5V2t76VfFjt6RlIkKKiWo3cP62Ry?=
 =?iso-8859-1?Q?IgfIWTqbHvNd0pwgYVGT2Tw8WbzKfTp+ZE1k/z8dpewFI8aj8OiNDQFeAF?=
 =?iso-8859-1?Q?TFdwD+WgQoTl71O/nKRllnDL231K0DJQGBEx6r8grXa/L5c5HoqlsJ+2Ku?=
 =?iso-8859-1?Q?+8r8uioZLnB0hF06Fp3CUNFdmTy3JPlI2b1oN4rBXqfqh/CPlmyibrVN2T?=
 =?iso-8859-1?Q?vS33h9csR/FxW1EgoTsRJwdsW+/CeGsPAD/aaGn1W4bGGEjUZq2CTZo4N1?=
 =?iso-8859-1?Q?zNOiDrSEdu/CHaIbMPACX7x3dwKAmGgu+gLxCotZREo9enMmLgydPOjsea?=
 =?iso-8859-1?Q?mOam45jbGhLBtYZ8YpqKA+zkEeHK/SXB/+gEAr5mvbBhROCSeGAXVvVq1g?=
 =?iso-8859-1?Q?ZNCGsw2Hv5Faofe7Hfg4n1lxE3pMzh1qSQA8x71nnavqNiQGAHx/YUCILa?=
 =?iso-8859-1?Q?OFbrQVagwuaicNJMzEtc6cSF46yCbCMfyGpIiKp3vWgjc1AZNpGCXF3hd+?=
 =?iso-8859-1?Q?WweD4Q0150i4pgQFP4bSKiW33G6yWqXGnjPi5Qs2pLKj+/4bn0ObkWP2mh?=
 =?iso-8859-1?Q?0rl+G+IkXiKMQ02dve/E1ZvreNcXcJXY3xGg/ZePYVGYlDngJKhGrfUbRw?=
 =?iso-8859-1?Q?NnuIVoiURRizN2T5+X2biG19pIC0sCSIFz5LwgWpP54Ely7ACs6QakC3Q6?=
 =?iso-8859-1?Q?2khf4OkaxTVCh2O/vSTgpN690BSJXOI4/fxt5YLxXPg8puk7RyijuvqO1T?=
 =?iso-8859-1?Q?pxKaQjxz1HoyiCumzZBJmUnRlOfsyC3yrlSY6he/l7FQJxQp12O1vRAy2w?=
 =?iso-8859-1?Q?nJmrr2JYgX+HHOGPkOMBNnv57894Rw1EsE1RzeXEb4WoCI3QV3Xwcp1ULJ?=
 =?iso-8859-1?Q?Xc+cLTuBs/DQcFcZciVRLMYElBXy8sAz5AdJaY03RkxV4vXSil3wrzYn0g?=
 =?iso-8859-1?Q?vxYaoCRdOD+jvo3yBn6rc9FSHChBTopNiDQaEOl/YuFBO9LzVQgrGeH3JK?=
 =?iso-8859-1?Q?39q8SKIgsNombIJi9t+44+mvdJ0tsj7nZwdBmzr+qKG+w0Hk+ClkxsACGK?=
 =?iso-8859-1?Q?XvDUxeR2Ef+P1XqejuhiMMOlYHwB0iQmFuXEZ+z+wavJ3pkmOnioqrq+HB?=
 =?iso-8859-1?Q?ww5K75T0y+uX7UteQCWdJLouj7I4P0MXUNUjCHHl7Y7hXP6Yaeh5aJY66t?=
 =?iso-8859-1?Q?RRC1x9hyWochIeGkmJpoUeTlOYLOZMvPWy/pT3sRyOChhBKKU5zCtz00E4?=
 =?iso-8859-1?Q?hYPEjqUDPe/rWK4V4/3VnxvKyaXWH413xODH3Om9CZJgIuvtx4nCYkrXGu?=
 =?iso-8859-1?Q?t+U/9tf9QkaEsKWo7unOJb3jIHz4IDSN4jUkXp9DetbXSW5tGzdgqhqHu1?=
 =?iso-8859-1?Q?hDnZ7B/yUBp3Zsrr+ddOObdM+oQf+oXEx5Aq8920FtduSK37hWlhcT5JIJ?=
 =?iso-8859-1?Q?jivky+ilIz4PSJD171rJ00iCk3yjWKeiVTjQY7e+CT5t6hS7MXR/ITZV4D?=
 =?iso-8859-1?Q?NAFdCtk7ivJVLgD3EGZw7jBsPeQTj8HFBxXWOJ+MfDaSV8X4Cx7H6RjtRn?=
 =?iso-8859-1?Q?VYsQorJG4Hg8yNJmzpU=3D?=
X-OriginatorOrg: silabs.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba6e7cbb-429f-4d18-86c7-08d9f2e857de
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 14:09:57.1280
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kMRHDXH1vhcz72WYU0beybW18VzZnhMh9yXYcyzsyskQjqDI7eoD9AZXIx64RrEUcB8aC3qUAdtAlDR5Qcnsmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5939
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 18 February 2022 14:59:45 CET xkernel.wang@foxmail.com wrote:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>=20
> One error handler of wfx_init_common() return without calling
> ieee80211_free_hw(hw), which may result in memory leak. And I add
> one err label to unify the error handler, which is useful for the
> subsequent changes.
>=20
> Suggested-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
> ---
> Changelog
> v1->v2 restore the wrong modification of a return statement.
>  drivers/staging/wfx/main.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/staging/wfx/main.c b/drivers/staging/wfx/main.c
> index 4b9fdf9..9ff69c5 100644
> --- a/drivers/staging/wfx/main.c
> +++ b/drivers/staging/wfx/main.c
> @@ -309,7 +309,8 @@ struct wfx_dev *wfx_init_common(struct device *dev,
>         wdev->pdata.gpio_wakeup =3D devm_gpiod_get_optional(dev, "wakeup"=
,
>                                                           GPIOD_OUT_LOW);
>         if (IS_ERR(wdev->pdata.gpio_wakeup))
> -               return NULL;
> +               goto err;
> +
>         if (wdev->pdata.gpio_wakeup)
>                 gpiod_set_consumer_name(wdev->pdata.gpio_wakeup, "wfx wak=
eup");
>=20
> @@ -328,6 +329,10 @@ struct wfx_dev *wfx_init_common(struct device *dev,
>                 return NULL;
>=20
>         return wdev;
> +
> +err:
> +       ieee80211_free_hw(hw);
> +       return NULL;
>  }
>=20
>  int wfx_probe(struct wfx_dev *wdev)
> --
>=20

Looks right.

Reviewed-by: J=E9r=F4me Pouiller <jerome.pouiller@silabs.com>


--=20
J=E9r=F4me Pouiller