Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp1549635pxb; Fri, 18 Feb 2022 10:02:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKsFAhCeAFaOgaDIpEZSPQgYNBvOtBg7jKHRKT4FACyKTd1/0LbnOZOgmgq6WBi8AQ6rON X-Received: by 2002:a63:90c8:0:b0:365:5cc7:e776 with SMTP id a191-20020a6390c8000000b003655cc7e776mr7146251pge.13.1645207338762; Fri, 18 Feb 2022 10:02:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645207338; cv=none; d=google.com; s=arc-20160816; b=tBYmi5wxF4DGnjZTLZhtArGSt5wYUAsauVSL5Srm1E7XX3qm9aAAFG659GtlSkkSf3 HD2owJ1RT7a/ihXQILfuX5tQrDUpEe21go4/tkqlP6ABHc3lKTWFg4eXhQOXfAfs4InI 7a0b8kdkH26VvWqH24LnhVOoak4WKZ/Yw8H349GTrjwbdoV/ElhLwWAuMp0QrYlBgU5a p1Qs8OkNm9hYn0VRdkDNY9LBvFgIl5z8SVzIgMEvc9Tr7A4jcGCnlO8FLB0/bnlpJAvP eJuPYhYAqBbThvDsF7a+MbgKNItDTmnndyO25AXEm4Hqvjuq3NPPoifWPFZbATn7cIcL 5lgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=M0SlSKIcsWyiz7ehxMXiqsXBhMS43McGwa2Yt7SSuQs=; b=ILUuBlg1QDtmF+gUtHXQQlkCF6N15Xvibp8TMd85hVjSulJ4BzEDvJyZB3R7aGRMMc eavK6oN3KbXI3yE4C3o1cjpI8JTBwGmqSLDGiSX0op58qK707tMmfavEmtp+DzsMd2rz suH6bmyCm69BNe+yB2H+0LYGbuVDGIk8VwuOhx83FGUo5Jpdg1UXY6OaVd+M4gkfBWNQ LA6Z+tP98dRanXBrKu/uinfnYMIfCrrrBnLONK9LPI6BFUKfn82KJSfQBMVWxDjj45wu sSgbVgYLPfPlPLa6px7VQFepmFprgbXRFTM8XA3LZyOKIkaCqNN5u+p+0aGu/3OAJDXb Tpbg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q3si23090726pln.403.2022.02.18.10.01.59; Fri, 18 Feb 2022 10:02:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237522AbiBRQKx convert rfc822-to-8bit (ORCPT + 99 others); Fri, 18 Feb 2022 11:10:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237518AbiBRQKu (ORCPT ); Fri, 18 Feb 2022 11:10:50 -0500 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B7D6313C9FD for ; Fri, 18 Feb 2022 08:10:33 -0800 (PST) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-56-O3XU_dwdNqmADcxbKhNOfQ-1; Fri, 18 Feb 2022 16:10:31 +0000 X-MC-Unique: O3XU_dwdNqmADcxbKhNOfQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Fri, 18 Feb 2022 16:10:28 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.028; Fri, 18 Feb 2022 16:10:28 +0000 From: David Laight To: 'Hyeonggon Yoo' <42.hyeyoo@gmail.com>, Vlastimil Babka CC: Christoph Lameter , Matthew Wilcox , Christoph Lameter , Linux Memory Management List , LKML , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Subject: RE: Do we really need SLOB nowdays? Thread-Topic: Do we really need SLOB nowdays? Thread-Index: AQHYJLAyvH6iV8tqykeD7oCpMSL3UayZeSGA Date: Fri, 18 Feb 2022 16:10:28 +0000 Message-ID: <7829ee15074448d5a7cec1a0e3c352d4@AcuMS.aculab.com> References: <20211028100414.GA2928@kvm.asia-northeast3-a.c.our-ratio-313919.internal> <20211210110835.GA632811@odroid> <20211215062904.GA1150813@odroid> <54c6fff8-8c79-463b-a359-96e37bd13674@suse.cz> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hyeonggon Yoo > Sent: 18 February 2022 10:13 ... > I think SLUB can be memory-efficient as SLOB. > Is SLOB (Address-Ordered next^Wfirst fit) stronger to fragmentation than SLUB? Dunno, but I had to patch the vxworks malloc to use 'best fit' because 'first fit' based on a fifo free list was really horrid. I can't imagine an address ordered 'first fit' really being that much better. There are probably a lot more allocs and frees than the kernel used to have. Also isn't the performance of a 'first fit' going to get horrid when there are a lot of small items on the free list. Does SLUB split pages into 3s and 5s (on cache lime boundaries) as well as powers of 2? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)