Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Feb 2022 10:01:19 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     zhengjun.xing@linux.intel.com
Cc:     peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@intel.com, jolsa@redhat.com,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        irogers@google.com, adrian.hunter@intel.com, ak@linux.intel.com,
        kan.liang@linux.intel.com
Subject: Re: [PATCH] perf tools: fix failed to use cpu list for uncore events
Message-ID: <Yg+Yn16Xyzqc2kRr@kernel.org>
References: <20220218093127.1844241-1-zhengjun.xing@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220218093127.1844241-1-zhengjun.xing@linux.intel.com>
Precedence: bulk

Em Fri, Feb 18, 2022 at 05:31:27PM +0800, zhengjun.xing@linux.intel.com escreveu:
> From: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> 
> The 'perf record' and 'perf stat' commands have supported the option
> '-C/--cpus' to count or collect only on the list of CPUs provided.
> commit 1d3351e631fc ("perf tools: Enable on a list of CPUs for hybrid")
> add it to be supported for hybrid. For hybrid support, it checks the
> cpu list are available on hybrid PMU. But when we test only uncore
> events(or events not in cpu_core and cpu_atom), there is a bug:
> 
> Before:
>  # perf stat -C0  -e uncore_clock/clockticks/ sleep 1
>    failed to use cpu list 0
> 
> In this case, for uncore event, its pmu_name is not cpu_core or cpu_atom,
> so in evlist__fix_hybrid_cpus, perf_pmu__find_hybrid_pmu should return
> NULL,both events_nr and unmatched_count should be 0 ,then the cpu list
> check function evlist__fix_hybrid_cpus return -1 and the error "failed
> to use cpu list 0" will happen. Bypass "events_nr=0" case then the issue
> is fixed.

Thanks, applied.

- Arnaldo