Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c237f6d1-4219-0e6d-6aca-9c29d060bb4f@suse.cz>
Date:   Fri, 18 Feb 2022 19:54:14 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] slab: remove __alloc_size attribute from
 __kmalloc_track_caller
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Daniel Micay <danielmicay@gmail.com>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Nathan Chancellor <nathan@kernel.org>, linux-mm@kvack.org,
        llvm@lists.linux.dev
References: <20220218131358.3032912-1-gregkh@linuxfoundation.org>
 <a5ab4496-8190-6221-72c7-d1ff2e6cf1d4@suse.cz> <Yg/eG4X7Esa0h1al@kroah.com>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <Yg/eG4X7Esa0h1al@kroah.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/18/22 18:57, Greg Kroah-Hartman wrote:
> On Fri, Feb 18, 2022 at 06:14:55PM +0100, Vlastimil Babka wrote:
>> On 2/18/22 14:13, Greg Kroah-Hartman wrote:
>> > Commit c37495d6254c ("slab: add __alloc_size attributes for better
>> > bounds checking") added __alloc_size attributes to a bunch of kmalloc
>> > function prototypes.  Unfortunately the change to __kmalloc_track_caller
>> > seems to cause clang to generate broken code and the first time this is
>> > called when booting, the box will crash.
>> > 
>> > While the compiler problems are being reworked and attempted to be
>> > solved, let's just drop the attribute to solve the issue now.  Once it
>> > is resolved it can be added back.
>> 
>> Could we instead wrap it in some #ifdef that' only true for clang build?
>> That would make the workaround more precise and self-documented. Even
>> better if it can trigger using clang version range and once a fixed
>> clang version is here, it can be updated to stay true for older clangs.
> 
> It's not doing all that much good like this, let's just remove it for
> now until it does actually provide a benifit and not just crash the box :)
> 
> This is only 1 function, that is used in only a very small number of
> callers.  I do not think it will be missed.

Fair enough, added to the slab tree:

https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=for-5.17/fixup5

> thanks,
> 
> greg k-h
>