Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Nick Terrell <terrelln@fb.com>
To:     Qu Wenruo <quwenruo.btrfs@gmx.com>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: v5.17-rc3 compile failure on aarch64
Thread-Topic: v5.17-rc3 compile failure on aarch64
Thread-Index: AQHYI9msiKPjLIK4aEiPohfL7+V0rqyZ8dWA
Date:   Fri, 18 Feb 2022 23:10:51 +0000
Message-ID: <F85853B6-A81C-4AD9-972C-747CAD6391B8@fb.com>
References: <85bfe02c-9432-c5b0-04e0-8096adf37b93@gmx.com>
In-Reply-To: <85bfe02c-9432-c5b0-04e0-8096adf37b93@gmx.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aa1M51tFGqcAlqnOwsA5OXxp8E0fzrNnT7lpklSfayHdDw4aeTr13gEObnmY?=
 =?us-ascii?Q?X4Pc/qS2URLevW3MF1hlFz2BAiMg6IysEbqdiEXYm0J0pS8YW4xIB20AA4kR?=
 =?us-ascii?Q?SwUwyiWmhEVSdGfnN94/bNnsEXNrl2D6Ark6ehJwXqqM5mX9u+r8/ZzTpbbU?=
 =?us-ascii?Q?xiWRxjo924MHSpxTlK8trGgCIy8/sn7zZKfqTk9opcxHRlK8EFcUlpyV1scM?=
 =?us-ascii?Q?0HNGb3ETQU4R1P91ZJOW83CcTaKn9ndLr+tFMoycIa4eSD1TOOPnTeoLBS3/?=
 =?us-ascii?Q?Dj633wQ5O0CYW4hPVjvZWvTYlY/mm3Fq6mJpmdv4Z7SVVLLwt79PQbCh2+Xz?=
 =?us-ascii?Q?20ukX9ntxp6hHgTUXfixfZ53f22DLrPeu+grKW5K7y8XBw24rg+k/QMDe9jN?=
 =?us-ascii?Q?hD8YcJpXtGN4glLu644pNckKGS0k/atgNuCyMf/3XPmzVgoLkrkLhv5MjPNw?=
 =?us-ascii?Q?hoL9bxAVmh4hNZGd2uRebao/RIbv4N1gR3HgVQYjchcACUs2KpHK9KNZR8Sr?=
 =?us-ascii?Q?YRzeE5hLUObmypec7D53te24KQm25ubn8njxV93ZVy1zi/p3epqO17x08LfH?=
 =?us-ascii?Q?PFyQjwAFmZgyqUSUZlvOP5OvraBcjZ1mk0/eahV+ZBRpUiiuJJGtrFLqfdba?=
 =?us-ascii?Q?VQV7CoOwJkVme/Jeo6gcA+SXHHSyJZLJNUnMlu22Gn3DviB7aaJiq8TDrKr/?=
 =?us-ascii?Q?8ax5fGICebwD7+es7BKP6YUQSnPD6Ebku0F0uV6W7BY3YqgPRLFeu6vrI6KF?=
 =?us-ascii?Q?A1ldVLf/kM/n2Q7Gv7ptxybHz5cmJlw9+5yNfF9w2nZd1XpbV4RDoDAY9Xcb?=
 =?us-ascii?Q?3T0JXLiEgK49atQWbBNdPjqan25hJhz0yssTy+V59gTJ1aN2QBQb70hOy03t?=
 =?us-ascii?Q?gideL1TOLjw+ZPMhPM3DYrmDltkxs+jqcmGTE81BBTGNCBcf60XM3YQMwwpg?=
 =?us-ascii?Q?v+405QifkC6br7KnxZxpT0ZL7gRKumzv7+aAJ+BN5BlELIGR/PC0c+gspDwX?=
 =?us-ascii?Q?Q+azbg7rOx+5Q6YUZitUJ2NAYHybZRFYL1nGHyLhy/Z6xKRSPVQuzzgDAUEl?=
 =?us-ascii?Q?UhHBcYWthLDynzBv7gQKTH+4pa2dvKWB9+tiRKJay7FYINnUYWX67thiepcJ?=
 =?us-ascii?Q?O8/ZVBbuOKxvJhlwVVD4/K6sAvd4XFVI7TmPoqw0P94N8ubrWFZVC5xLuqjR?=
 =?us-ascii?Q?bRNbPm2/SU6/2xZ5ApTKX/zdChJGXlI7tQm1sGZlt3KglaTNs5Zie3oB9CkT?=
 =?us-ascii?Q?lsgv/kPBMU8dU/ucSMN+wgXA+f6FIEoi0dAMC7J8faFPOnVnSl4QFxWJVXp8?=
 =?us-ascii?Q?wDkjsH1/PUejj2pZQjEZu7l18JLxFKq1aT25NIEd4zaTi8+dUm0z3NnEEPuy?=
 =?us-ascii?Q?UnTL/Db5k0qabeJW9uBNRXBVM6zKf24CVT2/fIaKa3rJARgVAw78YGa1S+DI?=
 =?us-ascii?Q?K6kPvcNQ4tYynNNpA0gFkzhkmHWG/ombfId9/GciVms3+g6N8tJHb9eHMFE+?=
 =?us-ascii?Q?qTD8s6r/nM7piwvHA7HfZ6wzW+YpPECdQtzwBUn4IeSjJeQ5tvYEZNjPvWTO?=
 =?us-ascii?Q?cakM9nhO70jFDPnIYbjhTzDXyv5Q50dtdo11bE7NPufx3t1AQhu8XE7331vV?=
 =?us-ascii?Q?cQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24011BDB68AF6A4AA43E9F467B1BA287@namprd15.prod.outlook.com>
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3667.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74eefb59-335d-40cf-5e25-08d9f333e848
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 23:10:51.4480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Kh3KFWAl8/Sl+yQPUtYNfxJYp99mdjBLyGSPKottgrHv+tBNL7xx3u2J258iJD2B
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR15MB4229
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: Po_7wVPpv4JCeaeqyw5_wWriCx9uDIV4
X-Proofpoint-GUID: Po_7wVPpv4JCeaeqyw5_wWriCx9uDIV4
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-18_10,2022-02-18_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=fb_outbound_notspam policy=fb_outbound score=0 priorityscore=1501
 mlxlogscore=803 lowpriorityscore=0 impostorscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 mlxscore=0 spamscore=0
 clxscore=1011 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202180142
X-FB-Internal: deliver
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 17, 2022, at 12:37 AM, Qu Wenruo <quwenruo.btrfs@gmx.com> wrote:
> 
> Hi,
> 
> Recently I found v5.17-rc3 kernel failed to compile on my aarch64 setup,
> it failed with the following error messages:
> 
>  AR      lib/zstd/built-in.a
>  LD [M]  lib/zstd/zstd_compress.o
> ld: __patchable_function_entries has both ordered
> [`__patchable_function_entries' in lib/zstd/common/entropy_common.o] and
> unordered [`__patchable_function_entries' in
> lib/zstd/common/error_private.o] sections
> ld: final link failed: bad value
> make[2]: *** [scripts/Makefile.build:484: lib/zstd/zstd_compress.o] Error 1
> make[1]: *** [scripts/Makefile.build:550: lib/zstd] Error 2
> make: *** [Makefile:1831: lib] Error 2
> make: *** Waiting for unfinished jobs....

I'm not sure what's going on, but maybe I can provide a hint to people
more knowledgable about the situation.

These objects are included in both the `zstd_compress` and
`zstd_decompress` modules [0]. That may be relevant. Back in 2018
we used to avoid having duplicate objects in different modules,
but then kbuild added support for it, and it was cleaned up in commit
dc35da16 [1].

It also may be irrelevant. Zstd was updated in the v5.16 kernel, but hasn't
changed in the v5.17 kernel.

Best,
Nick Terrell

[0] https://github.com/torvalds/linux/blob/master/lib/zstd/Makefile
[1] https://github.com/torvalds/linux/commit/dc35da16a2e23db04822f0129cd5b28b7b0e72b4

> But the same code base compiles fine inside my x86_64 VM.
> 
> The aarch64 environment is an VM running on RockPro64 or RPI CM4.
> 
> With a little older gcc (v10.2.0) and bintuils (2.35).
> 
> While for my x86_64 VM it has newer gcc (11.1.0) and binutiles (2.36.1)
> 
> I'm super happy to upgrade my tool chain for my aarch64 VM, but I'm a
> little concerned if there is something worthy fixed.
> 
> Thanks,
> Qu