Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 2/2] selftests/damon: make selftests executable
To:     SeongJae Park <sj@kernel.org>, Greg KH <gregkh@linuxfoundation.org>
Cc:     Yuanchu Xie <yuanchu@google.com>, Shuah Khan <shuah@kernel.org>,
        Markus Boehme <markubo@amazon.de>, rientjes@google.com,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220218082428.11699-1-sj@kernel.org>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <9a7f8d0b-3f0f-8584-6c12-423b0d5a979d@linuxfoundation.org>
Date:   Fri, 18 Feb 2022 15:20:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220218082428.11699-1-sj@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/18/22 1:24 AM, SeongJae Park wrote:
> On Fri, 18 Feb 2022 09:01:11 +0100 Greg KH <gregkh@linuxfoundation.org> wrote:
> 
>> On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote:
>>> Hello Yuanchu,
>>>
>>> Thank you for this patch!
>>>
>>> On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie <yuanchu@google.com> wrote:
>>>
>>>> The damon selftests do not have the executable bit on. We fix that by
>>>> setting the x bits on the .sh files similar to other existing shell
>>>> selftests.
>>>>
>>>> Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases")
>>>> Signed-off-by: Yuanchu Xie <yuanchu@google.com>
>>>
>>> Reviewed-by: SeongJae Park <sj@kernel.org>
>>
>> This type of change does not work outside of git, so why not just make
>> the tool that calls these scripts not care about the executable bit like
>> we do for other scripts?
> 
> Actually, we made kselftest receives scripts having no executable bit[1],
> though it still prints warning.  I guess Yuanchu wants to remove the warning?
> 
> To remove the warning, simply making kselftest (runner.sh) stop printing the
> warning message might make more sense.  Nevertheless, it's also true that
> letting some scripts have executable bits while others not looks inconsistent
> to me.  That's why I left the warning message there.  Should we remove the
> warning from kselftest and remove executable bits from other selftest test
> scripts?  Or, let the inconsistency be?  I have no real opinion here, so just
> wanted to hear others' opinion if possible.
> 

I don't recall why we decided to add the check in runner.sh - let's keep them
consistent with the rest of the scripts. If we get rid of the check, we can
make the change then.

thanks,
-- Shuah