Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Feb 2022 20:44:19 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Marcin Wojtas <mw@semihalf.com>,
        Jeremy Linton <jeremy.linton@arm.com>
Cc:     netdev <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [BUG/PATCH v3] net: mvpp2: always set port pcs ops
Message-ID: <20220218204419.63962fbc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <CAPv3WKe-=+zqkNKD1rkk0uU6t5Z=aixeHD+fp8tZqbGn0sgyZA@mail.gmail.com>
References: <20220214231852.3331430-1-jeremy.linton@arm.com>
        <CAPv3WKe-=+zqkNKD1rkk0uU6t5Z=aixeHD+fp8tZqbGn0sgyZA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 19 Feb 2022 00:49:27 +0100 Marcin Wojtas wrote:
> wt., 15 lut 2022 o 00:18 Jeremy Linton <jeremy.linton@arm.com> napisa=C5=
=82(a):
> > Booting a MACCHIATObin with 5.17, the system OOPs with
> > a null pointer deref when the network is started. This
> > is caused by the pcs->ops structure being null in
> > mcpp2_acpi_start() when it tries to call pcs_config().
> >
> > Hoisting the code which sets pcs_gmac.ops and pcs_xlg.ops,
> > assuring they are always set, fixes the problem.

> > Fixes: cff056322372 ("net: mvpp2: use .mac_select_pcs() interface")
> > Suggested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

> You can add my:
> Reviewed-by: Marcin Wojtas <mw@semihalf.com>

Perfect, thanks everyone!=20

It's now 5a2aba71cd26 ("net: mvpp2: always set port pcs ops") in net.