Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2023703pxb; Fri, 18 Feb 2022 23:35:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJyazHkVHeT4SpRInzsmy6hCW78XuRzQrX5FA5ifPCu3CIS9/otADtw6ThmFeLGFS8A7F+gc X-Received: by 2002:a17:902:9045:b0:14f:14e7:f3aa with SMTP id w5-20020a170902904500b0014f14e7f3aamr10345403plz.69.1645256133729; Fri, 18 Feb 2022 23:35:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645256133; cv=none; d=google.com; s=arc-20160816; b=yWm1rOPKjHQ/zjdHLDZuF686kiHtruQpp6eB9Hwa9rGijDoFR2gXex/clr99nL0FAr F2WTkmKZjBISQFbQA4Q8bs2dUBsFYKU94bCuTkpkDp69vr9pBVJvjEkhwqRm3XKylG7N 40s3W8jBPMPgGMaaRvl97eFADJKGL6V9pGz0jvdTy7Dpr89EdR3AyVOfzZinjofw8tv9 bwUJCd2OOllik8sksvsOv9fEDwzuL2EopWuUqNPag4MbDp7VgABt2ZnuLs+UoaIXjGzm FEsP1zneGWPFGmwUID3iUStaGC1q0TRj7NcnO7lMqE+ge1OYZB920nUDSsw2Cfu+nnO3 1EmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=N2mb/fnXiK+55Vayu1WQaDGcQm6fHIlg0WJV5p4N/HY=; b=0ioqBqkL/zn38hb0CuIOursC8Fy74FLy4InmU5KDpwyjXkYLTKFcbwGwB19WW2k6b/ tQEaB6u6tif4kHLqQ/jLvHOZNQgPZ2f66LohxI/cZrcFrI0ed6eSt3Kyd+51Q3FLZme2 7ujjEJtGR7sp53xkTKRPev88b1z8zYcJlwqFKzPVAm7h90qGZ+pQzpnpwAURtaruatPU GKuPn32ZthwSi2ZKKVcwJcFeXoExyue3c/ANxVhfXzYCVwyCaLqRHfrtz20Sy2kj60um pdWMsZHFlrVeA9U9NV6KTOiqWeOqZvy2BD6/QEi/fUIw0L4F2dIow6IrjA1Tpel/bCNA XHaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=vhpvpYAs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m14si14360795plg.97.2022.02.18.23.35.18; Fri, 18 Feb 2022 23:35:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=vhpvpYAs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240400AbiBSAec (ORCPT + 99 others); Fri, 18 Feb 2022 19:34:32 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236378AbiBSAeb (ORCPT ); Fri, 18 Feb 2022 19:34:31 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 192CA177E6F for ; Fri, 18 Feb 2022 16:34:14 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id u5so8403279ple.3 for ; Fri, 18 Feb 2022 16:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=N2mb/fnXiK+55Vayu1WQaDGcQm6fHIlg0WJV5p4N/HY=; b=vhpvpYAs72r/uoSL/BUaAusH6XKA4rAULu6qjHWYo27jOy1C6kM9j5tc1Az/Esg0n+ FIOoL1tgzkQ9bIQz2F3q90+Bps0EPIorHHEdHbZIVqHLPyPSB73rdhlXru65MTfByH59 Newd+wujsKTxWviQyz6zZe1F9pjl4rRdCaGC92BJL9pgI6PbUqQjZx/sgR1F83Px1HYs UUdtOicItV1IdSw8I9tgzri27OuyH8j/3J+hd8TKLNaRGWCfo+74ClOd90Qrmng3KlOd b2PRktm+Sm6qOC1/T9BNb9qvzmS8jeA4BSScIvYwNokGxI37wp3LhcFPjWjivHq3pn4V Sudw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=N2mb/fnXiK+55Vayu1WQaDGcQm6fHIlg0WJV5p4N/HY=; b=gvy6GD44DTbD4OelRSXKU4N+Ap/OPd/fFjx+tsrI88xAbwqJ2YNavJ2lmimvKw+i7N 98bfo8PJuC1mltPQb/d/X1sB2nTwaJePljMxtuwvtB3qcXZuwxaKLWCTYY0da79RA8b2 CwZK90s514TwRx2PJqrZ4x2nxA/aAG3eEoqcEzfQxEw+mSW8h8ivU9SuYQfm9HWOO+Z7 NXwJqeYgIQfqdaA7Dgj2E61HcOQLU4PZDU7fhZVq+yPTQXeK8xd6bpgpZzDmsfuG8ut4 e8OfTxD+ej3HlGgXs0CIFc+qkOAZS7yMnGi8edEQRHIGiDYQjdNeMopkqZk9MBRrvHak OcNg== X-Gm-Message-State: AOAM532IXSXGYqi4NQDv4uKT0+T5Tl0yxoiFxWKxxrC9Jiyjp7/0Bj96 LGXPdK8lSC2GgzAr6NLU4vdlzQ== X-Received: by 2002:a17:902:d683:b0:14c:c0a9:34f3 with SMTP id v3-20020a170902d68300b0014cc0a934f3mr9482203ply.109.1645230853581; Fri, 18 Feb 2022 16:34:13 -0800 (PST) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.gmail.com with ESMTPSA id h16sm4149298pfh.40.2022.02.18.16.34.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 16:34:13 -0800 (PST) From: Kevin Hilman To: Rong Chen , Ulf Hansson , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , 1131046452@qq.com, linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: 45581586@qq.com, Rong Chen Subject: Re: [PATCH v2] mmc: meson: Fix usage of meson_mmc_post_req() In-Reply-To: <20220216124239.4007667-1-rong.chen@amlogic.com> References: <20220216124239.4007667-1-rong.chen@amlogic.com> Date: Fri, 18 Feb 2022 16:34:12 -0800 Message-ID: <7hiltbitiz.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rong Chen writes: > Currently meson_mmc_post_req() is called in meson_mmc_request() right > after meson_mmc_start_cmd(). This could lead to DMA unmapping before the request > is actually finished. > > To fix, don't call meson_mmc_post_req() until meson_mmc_request_done(). > > Signed-off-by: Rong Chen Reviewed-by: Kevin Hilman