Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2076879pxb; Sat, 19 Feb 2022 01:27:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrL1PN3ATCfbEVZ6jbbukmAeaj7E04OdPlrZdcr93U80UEWZ2QfeYAMgQcPurhHMIaBUeb X-Received: by 2002:a17:90b:4a4f:b0:1b8:7240:1a47 with SMTP id lb15-20020a17090b4a4f00b001b872401a47mr16721352pjb.84.1645262848000; Sat, 19 Feb 2022 01:27:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645262847; cv=none; d=google.com; s=arc-20160816; b=IHdblL5nLVKjDUjhFgRg70DNbUwtq7EHIVDbhRWELF7Wtrim0lD53lCYRGVsQ5D8z8 jWJCbVErwV6wZCA/gpZgIxg6Ays4UNRIOq/GmFfP3GwsUHzsPRyt6E+6PA4jdxogKTA+ zlTbK2yG3GbWDStHLbLrGaWy5fWLaii14D5+atxvpdYmDLm5MF4dsm0EDCVwwMuojWDJ n8HAYYwifAiTBYcyRYU8W8SSXSMsl9PKLhf6aaiqzEI2SVj9kAdUj9jPDqN2uHyD17HZ 7d16IiU+MsXGArWd1u5l0eOZsaKb7CCTeuLJPv6g/5MjXJiSy5Vr3lFlzVDPJVUoBovS p1hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=ClO/R9JRyaaM8bjM+2BOla/lLPUNMsID41a68FPN8DI=; b=McZ0kP60xmlMrJWc0Gz5SiAXDIsmrRvg1GmO6OvSyOqj8fjwO7LQ4OZNLi6bU6PMHW ewzL4fgmwixP21aFFQ1xPA/+gMU4HpFfaUdLYuMhlI3ACzZQOmMd14OmW9BDNYItr6b6 FXwicQhrMeSmGp/KvUvQqKtsBZGTV04GRL+EgBC20QcCkK9uXT1FHkmtiN9Mo22QWr+W Wty+ijHH3TOSPGcFamBqEKPZ1zxvh2TzEtwGd5JIVv++qIfgUzKFO5wqhmXE1KeDPOtQ 2BKNxAVVibbElQ8X+agHdaaoEmKdd1qHL2hkz8eI28Vvq23W1iHXNQZ31JWpAqBBJqSA gLSg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bo7VjF24; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o4si24385315pls.567.2022.02.19.01.27.13; Sat, 19 Feb 2022 01:27:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bo7VjF24; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240865AbiBSA5m (ORCPT + 99 others); Fri, 18 Feb 2022 19:57:42 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240796AbiBSAzl (ORCPT ); Fri, 18 Feb 2022 19:55:41 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3346127B992 for ; Fri, 18 Feb 2022 16:55:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645232117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:in-reply-to:in-reply-to:references:references; bh=ClO/R9JRyaaM8bjM+2BOla/lLPUNMsID41a68FPN8DI=; b=bo7VjF24UMdbtxaHprk33A1muHj9fywR2QlB7yzGXmWhC5zbtB3W0JAeoba/AZEqKJcXQ+ XJrGg/e2DLr1zaLHGI/kDrIXaZuNAtpGCmhjCrrCjywFvJW378Q4M8CFZJ5eI2wyEq0z5R lvQwOpkiYsGfxMM9clWvUYl+RYyAmew= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-86-a-TIrPYBP8-42XIzhwQwjA-1; Fri, 18 Feb 2022 19:55:12 -0500 X-MC-Unique: a-TIrPYBP8-42XIzhwQwjA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D73291091DA1; Sat, 19 Feb 2022 00:55:08 +0000 (UTC) Received: from MiWiFi-R3L-srv.redhat.com (ovpn-12-39.pek2.redhat.com [10.72.12.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id 190B262D4E; Sat, 19 Feb 2022 00:54:49 +0000 (UTC) From: Baoquan He To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: [PATCH 12/22] staging: emxx_udc: Don't use GFP_DMA when calling dma_alloc_coherent() Date: Sat, 19 Feb 2022 08:52:11 +0800 Message-Id: <20220219005221.634-13-bhe@redhat.com> In-Reply-To: <20220219005221.634-1-bhe@redhat.com> References: <20220219005221.634-1-bhe@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma_alloc_coherent() allocates dma buffer with device's addressing limitation in mind. It's redundent to specify GFP_DMA when calling dma_alloc_coherent(). [ 42.hyeyoo@gmail.com: Update changelog ] Signed-off-by: Baoquan He Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- drivers/staging/emxx_udc/emxx_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index b6abd3770e81..673f8de50213 100644 --- a/drivers/staging/emxx_udc/emxx_udc.c +++ b/drivers/staging/emxx_udc/emxx_udc.c @@ -2593,7 +2593,7 @@ static int nbu2ss_ep_queue(struct usb_ep *_ep, if (!ep->virt_buf) ep->virt_buf = dma_alloc_coherent(udc->dev, PAGE_SIZE, &ep->phys_buf, - GFP_ATOMIC | GFP_DMA); + GFP_ATOMIC); if (ep->epnum > 0) { if (ep->direct == USB_DIR_IN) memcpy(ep->virt_buf, req->req.buf, -- 2.17.2