Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp2095894pxb; Sat, 19 Feb 2022 02:03:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNHqqGAtZgT7Le8oipJ5EQLAsJG7zTA9NZe8ZCKvvKbOs5RdJQjzSyo/UK/eTRI1uFaZbe X-Received: by 2002:a17:906:53c3:b0:6cf:742d:84de with SMTP id p3-20020a17090653c300b006cf742d84demr9225773ejo.576.1645265027927; Sat, 19 Feb 2022 02:03:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645265027; cv=none; d=google.com; s=arc-20160816; b=iLf8lN1CsjdbFxw8oTp4An21OWpGuZ7/qCg3tEb3nVMrBMTvgLH4EdHVL6sNNSr/WW azVGjerdlJBtQGJSnLJcgn06G18GneR9m6p/QaqAE1LvotDSEx92UEE9me1uf797zKKp ra4n6rhiPSzcKMVnpSJVqjnTbOQrxeFlY2paHrGk0OlwBZRF/nao8sBsFAYSmijiex6g NsJt6Nh2pwfp6hq2n4MxnsuhIYi4wIlnIr0YHSNJoPf1Vw/ZDv+zyhBhH9ILdnq8F3oG wuc1sxKBwMps6x2PQd+agBDHmeg4/WVEIz9+2PB3TOtpZTXbM145RyubZs5Wo3QIoaXy rPNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=5+WQby+kVGdWOo13Lr0QKkoN72UpKQRKpDotJ1w+RJ4=; b=t+Lm3mURSysEUxMTPiN5x3GdMwalN/mvjubir7kDYLpiKWtahoB4KPtcX5F5Cf/thS +RIkdrGfI2pqFMEkrRGjJ0pE+DHca4h9JOw6TjX4DifPj6gTtHevstn9ZRZ21W1ptltr biEDtJZ0Mzmx1B7q5CRnZVF0C8VdLHhU8b26P5jn7LKH2mMGbIshxYkoE4wmILQgcwt/ 1UEYm/Z3XCWSOTxBSHZ38mjovwO3DEZ2uEbXgnwcA7jKRipc6SZWztOjPF/PC7OIxeDM qA9kdKzCpLrvjZN7t9cGE7FIfcPWnzRrFoOIcqJEIxju1U7ndz/MCTfB9kvxJ8M0er0u JO0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id my3si5342111ejc.849.2022.02.19.02.03.24; Sat, 19 Feb 2022 02:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241575AbiBSHOn (ORCPT + 99 others); Sat, 19 Feb 2022 02:14:43 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbiBSHOj (ORCPT ); Sat, 19 Feb 2022 02:14:39 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE4F12553F; Fri, 18 Feb 2022 23:14:20 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 17D7968BEB; Sat, 19 Feb 2022 08:14:18 +0100 (CET) Date: Sat, 19 Feb 2022 08:14:17 +0100 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hch@lst.de, cl@linux.com, 42.hyeyoo@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, David.Laight@ACULAB.COM, david@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, steffen.klassert@secunet.com, netdev@vger.kernel.org, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, michael@walle.cc, linux-i2c@vger.kernel.org, wsa@kernel.org Subject: Re: [PATCH 19/22] ethernet: rocker: Use dma_alloc_noncoherent() for dma buffer Message-ID: <20220219071417.GE26711@lst.de> References: <20220219005221.634-1-bhe@redhat.com> <20220219005221.634-20-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220219005221.634-20-bhe@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 19, 2022 at 08:52:18AM +0800, Baoquan He wrote: > Use dma_alloc_noncoherent() instead to get the DMA buffer. > > [ 42.hyeyoo@gmail.com: Use dma_alloc_noncoherent() instead of > __get_free_pages. Looks good, Reviewed-by: Christoph Hellwig