Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 19 Feb 2022 00:46:18 +0100
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Mark Brown <broonie@kernel.org>
Cc:     alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
        linux-kernel@vger.kernel.org,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Huajun Li <huajun.li@intel.com>, tiwai@suse.de,
        Takashi Iwai <tiwai@suse.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [PATCH 0/1] sound: add quirk for Huawei D15
Message-ID: <20220219004618.07cb69a9@coco.lan>
In-Reply-To: <c17173cb-290c-9ecd-54e3-b74f9d4e9061@linux.intel.com>
References: <cover.1640351150.git.mchehab@kernel.org>
        <164519450743.1836505.3912962145996830275.b4-ty@kernel.org>
        <c17173cb-290c-9ecd-54e3-b74f9d4e9061@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Em Fri, 18 Feb 2022 12:11:59 -0600
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> escreveu:

> On 2/18/22 08:28, Mark Brown wrote:
> > On Fri, 24 Dec 2021 14:09:48 +0100, Mauro Carvalho Chehab wrote:  
> >> Based on my tests, Huawei D15 (Intel) uses SSP0 on es8336.
> >>
> >> Add a quirk for it.
> >>
> >> Please notice that, currently, only the internal speaker is working.
> >> The topology for the internal microphone and for the headphones
> >> is wrong. Enabling/disabling the other two quirks (GPIO and/or DMIC)
> >> doesn't cause any audible results, nor change the devices listed
> >> on pavucontrol (tested with pipewire-pulse).
> >>
> >> [...]  
> > 
> > Applied to
> > 
> >    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> > 
> > Thanks!
> > 
> > [1/1] ASoC: Intel: sof_es8336: add quirk for Huawei D15 2021
> >       commit: ce6a70bfce21bb4edb7c0f29ecfb0522fa34ab71  
> 
> I'll probably revert this change in my next update [1], I have a set of
> changes where we can detect which SSP is used by parsing the NHTL
> information in platform firmware.

Mark,

Yeah, I tested Pierre-Louis pull request from:

	https://github.com/thesofproject/linux/pull/3338

and indeed this quirk is not needed anymore for the speaker to work.

So, once his new update gets merged upstream, feel free to revert
this one.

Pierre-Louis,

When you submit your next update from PR#3338, feel free to add:

Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org>

and my Acked-by at the revert patch:

Acked-by: Mauro Carvalho Chehab <mchehab@kernel.org>

> 
> I am still trying to figure out how to detect which MCLK is used, and
> once this is done I'll send the patches upstream.
> 
> [1] https://github.com/thesofproject/linux/pull/3338


Thanks,
Mauro