Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Pop, Cristian" <Cristian.Pop@analog.com>
To:     Jonathan Cameron <jic23@kernel.org>
CC:     "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: RE: [PATCH v4 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc
Thread-Topic: [PATCH v4 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc
Thread-Index: AQHYJKuGBC8orEy7d0+Yjvi6QunEM6yZNd2AgAAglCA=
Date:   Fri, 18 Feb 2022 14:48:01 +0000
Message-ID: <DM6PR03MB386657B1B6A6D21D5026A257E7379@DM6PR03MB3866.namprd03.prod.outlook.com>
References: <20220218095048.86826-1-cristian.pop@analog.com>
 <20220218120355.4b7c33e1@jic23-huawei>
In-Reply-To: <20220218120355.4b7c33e1@jic23-huawei>
Accept-Language: ro-RO, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3oKpv6/GcQfbUUxHwf1C5h0I0YodKZU/MvX/7q/9MwB2yLIQd3RSp20AQhMp?=
 =?us-ascii?Q?9yX8Ns4YVWlcIx+4XW29+gVCiL08s3VnKOsGBvOHqn10PqOIDEB5SxZGocm4?=
 =?us-ascii?Q?b2cw8gVa7mgkreF7toqw1FUHrA8fsv9I5gmVe8Z8MFZIWUNXrX6sgrytnxHa?=
 =?us-ascii?Q?FftMOudTozzCmL5R/2pCiJNavmPEr1B1SJE7EWvlrqoqwUjqWbb7uF6uNa1W?=
 =?us-ascii?Q?4U2KAEJJ5OkVbCYY0sFXWhpiXRZrxkbKw6KgWNr171BY9scpggeLwdlSUDh3?=
 =?us-ascii?Q?Zi5pCBZqICG9LEAfg3t+oI1Ibu5ty+3T/pNCEsSHpv0VPJMraHZXgrdgJ7mu?=
 =?us-ascii?Q?rcVwIxPDbJemVTOiccbRSqEO4RMrqA1bMwJXmxoc4oHhzqIDhWepMPwzyc+w?=
 =?us-ascii?Q?Npn76krzLcxklMaZObZG0gGUzSW9wJN4c2AOHkNVCx01OLPLyH3ego+9tCip?=
 =?us-ascii?Q?EMcrt9iOYtn02R6Qqgn/++/EJzgYEQsrPjVQwf0zb2T0/3zUg2O4IdQAd8KR?=
 =?us-ascii?Q?o7juE4cMayMDVaOfppUi4U86/MFHCz93EhBMUx96h9WN4HeEhCy+B8EjY4Ps?=
 =?us-ascii?Q?LCODmawC3ETz0hVOFYrptMSy9/67bvtjVm2fLTYY0IoqRinHvbAqTtDflhgt?=
 =?us-ascii?Q?72qzg5s8F6Pwkqpzo02yphR0TjOi8gB5XceGdwA8P9VpJO7/RWUfALVEfX3p?=
 =?us-ascii?Q?JoIreMQLEveCjsCjjdIjsn/pzXOHCK8jT1TgV5TWwQZs741Vpc4RbhW260Qs?=
 =?us-ascii?Q?jU8XnZlpDU7GPIilnhF2sOy0oaSOhwDX6hAJF3Z3ZG7eJ6aKEQnHCiASLk1F?=
 =?us-ascii?Q?DMA2E64v0orAAViAbXvI+az0LMBpbp2Djb+E3+kRJn2pDpJTCsfWZa6Lj3z8?=
 =?us-ascii?Q?ZYnc4YT1oaMSMmMp8KxTFDE2w1lSc2jEDH5igCmmhHFoHzazf0KnoBppkl50?=
 =?us-ascii?Q?Vr7lGp3ZhpfmwCFRGjDPPrk037A8nKbGHWLGFnXWGOkQd0E7NFEkjTxx0rxZ?=
 =?us-ascii?Q?gzC53QK/KKeCpq+/e8EQndpRAaaK2llYa4c8ZskwJN4gefL3ZNKPgBNKv+4I?=
 =?us-ascii?Q?SWv8Odp04soR79HC9dkmktlJK+QaDlubKQzX1Wc41PNoaEgQU2O4Pfyf96Ok?=
 =?us-ascii?Q?NYY4In/9e5v9uEEbw2ukC67G5LAor69dZvFf0N+pnwqNjes4df+S4Y0CAG08?=
 =?us-ascii?Q?24ZtOe/Cb0iP+zrJzohdC22FUHLmFHHK2EFEoLYAywgdxMcEoHciPcFqQUdP?=
 =?us-ascii?Q?Pp4JfYotL7XH+CmzuQ+XXQwEuW/vi33cI4zNKB1tVVuPXvHkM5kYVEfj7T7K?=
 =?us-ascii?Q?jgHCsEmneZ1RnWLyPJuzsQq5yiCctEEOUU9WDeGUgkQE00b04nYeikqZme4H?=
 =?us-ascii?Q?s1wJWtO/IPbuTrVpIYGi4W404dkd1693GIsdAzDYxTFg+lHqr6f96d89IWFq?=
 =?us-ascii?Q?LW617lluStA4RZfkQ/EAcuDkLGCOGkkFKNteTU9wwTWeyxvBCjaSq9da21Bp?=
 =?us-ascii?Q?6B+JlIHm8gD5Qy/J7LBytNFFSWeZxXn4KmvKxZkcFA0sVQ76MSKLNfG0hHQe?=
 =?us-ascii?Q?9q7byEh9Ie7ZdsC8D1uB4gxpM2TMwTbjOSWcIsavUm02CXt18IXoj/3Cytus?=
 =?us-ascii?Q?9A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB3866.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b32d477e-60b1-42a6-b037-08d9f2eda957
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 14:48:01.0965
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 4v2/ompzwVYD1yWU7vU8InnNnLL2VQI64oYO/XJib6j6JDQedXDl74jy9mWqxZGX36ohSMQM+CGZLSogwcjXOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3145
X-Proofpoint-ORIG-GUID: mp3We9ZzLZ0zJJ4j--1PV2yCpQC9MnqL
X-Proofpoint-GUID: mp3We9ZzLZ0zJJ4j--1PV2yCpQC9MnqL
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513
 definitions=2022-02-18_05,2022-02-18_01,2021-12-02_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxscore=0
 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0
 priorityscore=1501 clxscore=1015 spamscore=0 mlxlogscore=999
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2202180095
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Friday, February 18, 2022 2:04 PM
> To: Pop, Cristian <Cristian.Pop@analog.com>
> Cc: linux-iio@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; robh+dt@kernel.org
> Subject: Re: [PATCH v4 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc
>=20
> [External]
>=20
> On Fri, 18 Feb 2022 11:50:47 +0200
> Cristian Pop <cristian.pop@analog.com> wrote:
>=20
> > Add device tree bindings for the ADMV4420 K band downconverter.
> >
> > Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> > ---
>=20
> Change log?  Also, looks like this crossed with a question from Rob on v3=
.
>=20
In v3 there was a small change only, which I forgot to mention:
 - Add '$ref: /schemas/types.yaml#/definitions/uint32', for 'adi,lo-freq-kh=
z'
Robs question on v3: '-khz is not a documented unit suffix. Does neither hz=
 nor mhz not give enough resolution and range?'
The 32bit values in case we use ' -hz' property suffix, wont accommodate 17=
.5GHz for example.
For '-mhz' suffix, resolution is not good enough.=20
I propose adding reference type '$ref: /schemas/types.yaml#/definitions/uin=
t32' for '-khz' suffix.

> Thanks,
>=20
> Jonathan
>=20
>=20
> >  .../bindings/iio/frequency/adi,admv4420.yaml  | 55
> > +++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
> > b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
> > new file mode 100644
> > index 000000000000..35a3fb3fd339
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yam
> > +++ l
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> >
> +https://urldefense.com/v3/__http://devicetree.org/schemas/iio/frequen
> > +cy/adi,admv4420.yaml*__;Iw!!A3Ni8CS0y2Y!p1wBxz-
> QqJYCDNk3gYSMGaJoHbPGC
> > +RWOE04vh6kN2kHC84mPrBdIq_Pf1CgD3Z8knw$
> > +$schema:
> > +https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.y
> > +aml*__;Iw!!A3Ni8CS0y2Y!p1wBxz-
> QqJYCDNk3gYSMGaJoHbPGCRWOE04vh6kN2kHC84
> > +mPrBdIq_Pf1CiGygmUGw$
> > +
> > +title: ADMV4420 K Band Downconverter
> > +
> > +maintainers:
> > +  - Cristian Pop <cristian.pop@analog.com>
> > +
> > +description:
> > +  The ADMV4420 is a highly integrated, double balanced, active
> > +  mixer with an integrated fractional-N synthesizer, ideally suited
> > +  for next generation K band satellite communications
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,admv4420
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  spi-max-frequency:
> > +    maximum: 1000000
> > +
> > +  adi,lo-freq-khz:
> > +    description: LO Frequency
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > +  adi,ref-ext-single-ended-en:
> > +    description: External reference selected.
> > +    type: boolean
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    spi {
> > +      #address-cells =3D <1>;
> > +      #size-cells =3D <0>;
> > +      admv4420@0 {
> > +        compatible =3D "adi,admv4420";
> > +        reg =3D <0>;
> > +        spi-max-frequency =3D <1000000>;
> > +        adi,lo-freq-khz =3D <16750000>;
> > +        adi,ref-ext-single-ended-en;
> > +      };
> > +    };
> > +...