Subject: Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port
From: John Rose <johnrose@austin.ibm.com>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: Jeff Garzik <jeff@garzik.org>, Christoph Raisch <RAISCH@de.ibm.com>,
       Jan-Bernd Themann <themann@de.ibm.com>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       linux-ppc <linuxppc-dev@ozlabs.org>, Marcus Eder <MEDER@de.ibm.com>,
       Thomas Klein <tklein@de.ibm.com>, stefan.roscher@de.ibm.com,
       netdev <netdev@vger.kernel.org>, Nathan Fontenot <nfont@austin.ibm.com>
In-Reply-To: <1171491906.30473.3.camel@sinatra.austin.ibm.com>
References: <200702141536.28665.ossthema@de.ibm.com>
	 <1171491906.30473.3.camel@sinatra.austin.ibm.com>
Content-Type: text/plain
Message-Id: <1171559098.20758.70.camel@sinatra.austin.ibm.com>
Mime-Version: 1.0
Date: Thu, 15 Feb 2007 11:04:58 -0600
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 963
Lines: 20

> Second, the probe and remove functions do not communicate whether an add
> or remove was successful.  Combine this with the lack of port
> information in the adapter sysfs directory, and the userspace tool has
> no way of verifying a dynamic add/remove.

One way to communicate a return code is by making the sysfs interface
file read/write, and having the read callback give a return code.  For
an example of this, you can look at drivers/pci/rpadlpar_sysfs.c and
rpadlpar_core.c.

It would still be nice to have some way from the adapter sysfs directory
to list/examine logical ports.  Symlinks would work, but it would be
even nicer to have a new kobject per port with attribute files for
logical id, state, etc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/