Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        john.garry@huawei.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] scsi: hisi_sas: Remove unnecessary print function
 dev_err()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq18ru6fhcd.fsf@ca-mkp.ca.oracle.com>
References: <20220215020524.44268-1-yang.lee@linux.alibaba.com>
Date:   Sat, 19 Feb 2022 20:38:01 -0500
In-Reply-To: <20220215020524.44268-1-yang.lee@linux.alibaba.com> (Yang Li's
        message of "Tue, 15 Feb 2022 10:05:24 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JE8v7/+aXyCE3EF3qOB7oANMDqMAKBfGbtHS6VAzfSO4DXt/TaimqTiRZD6+?=
 =?us-ascii?Q?duqorZ+tdz1i2o5xDSbiFrNUEsp2/lhlj7h22zo3+Qq4+OUjl5jJNntbdqEJ?=
 =?us-ascii?Q?hGjZBJ7Px2to178QTryRntkDun7zutAT0EZXKYTgwmXhG/+ht5RUxcF3I1SD?=
 =?us-ascii?Q?pHmhDlbsQUy1azILm2MHjV41Dvh4pjelkIWI4fVVtOM2aWBGrl0RlEkNgves?=
 =?us-ascii?Q?DmWYhZDNcYbbTvdkjshVvqSfP2jP1pL1th7Xupes7DoHmoaCNMQR6ZdCK2U6?=
 =?us-ascii?Q?r3HeDSvksJ0KTsocZ5jnClHiEp6li0KSBTmUh/5UPUWsDUMCS4f8Ll1U9Z2l?=
 =?us-ascii?Q?r2naOkpilufo2vA9evOlgH/iq8PCBxIWPHEgvMvk05yzeAMfdKPoMhb2Vke6?=
 =?us-ascii?Q?GU+ZhamdYzbCjJxuciTE6Ib4yfpLWOmm6PGMEoqoL5+TDty1jZyMq654PO+3?=
 =?us-ascii?Q?3OTodnABnzClBdanGkDE2FLuI/fUPAiWGSascpTsSxauoUUJp/IdScKqFpCy?=
 =?us-ascii?Q?rShwTEm2oiE0INaghlE+H8ciXKKOKzIZOi2GnmAYTjmL4RusQF3YJWZWyPSA?=
 =?us-ascii?Q?KLUsRKdmqNq1OqZ3fUVHR+PyPwNcLKJ9fYQwkUnyrv2bPkIJJ4bpBuEwJGJN?=
 =?us-ascii?Q?WeR5TOl3+V9hK/XU4LeCPGh3HS9DXawHCn654Mndqen1VS62O0obqJ9G/FIn?=
 =?us-ascii?Q?5DZx2j/pzuSI3LsEkjbPhA2EUACPSBAyKZpQCG7hntMzh7X/E2a3VD+IajG6?=
 =?us-ascii?Q?QmE8F4bmal6QSmCjlMMS+VxqmBTaSjSzHfiNahFJJGFIn12/wxucFuXnMzyu?=
 =?us-ascii?Q?CLf6+Nqrr+Dd8ymvX3DxVjaqkZrP6pVP7KgNm7NwQVO8av6qv4RZhRJ8EhA+?=
 =?us-ascii?Q?y1nG58DpnYMRuRPP8vZem7+YXdchmt96CGw2qojbvigDHqevbd+UD76pdcBN?=
 =?us-ascii?Q?l73myNGx7IjAm7gVMmAZctDMqbo1GgZhljk5yquzivc6x0OuEpff26y2lFCn?=
 =?us-ascii?Q?nlMwAbqSlP/ZYzZDt3c+zGy0Z3zLPN9o66I+/4vX2gZ/y7VTd3c2Tm8VwMzM?=
 =?us-ascii?Q?Uh8KsaQ3tvbknXYMAChJIyJKeTJyKLjxxnpyNAuqlJDJtqD+11+RWyDMfJAv?=
 =?us-ascii?Q?Pz/ttTg3MuSZDS/Np8U1JJ09qHSbzvgehn+HcdVwwLAP/UPPRMkGW0eSupgm?=
 =?us-ascii?Q?nC5x62VTF8/bztoa33ljSQX+eVcsCAqHI+0DMHCj8v0m0fWrulO3wY4hPnyU?=
 =?us-ascii?Q?mH7IGm6u683PZ86/eTM4tQJyqhZdJbSxkx2EyQJzN5YwS1Ve3uxzsLpSZLnx?=
 =?us-ascii?Q?V4/cctiWlP036B+WkivvCOzgClnR1aKcElQw5uBJ+BRMpC7xcgFbV5YJyMo+?=
 =?us-ascii?Q?Keciwb+jugAzf5kWPyGSLhs3ZTudsrz7n704xKxYpU7GlUsMLNyCvRUF+43Y?=
 =?us-ascii?Q?v+kwK7/7gx/aDbxeQnM8jw5zGnqYf48rDNqz3EsJc25c4S6tud4VI/t+kCbW?=
 =?us-ascii?Q?AP8cLgSFBFkGcXqjI5TOvZYDI96J/Na7jq7snmyjo2IlFFLtgtTgW3rqPVjQ?=
 =?us-ascii?Q?+b8n4SozNJSUmQaE0m9xCqTvPH4t+t4UAH+A5/K5kkaQ/8qtgoxVRWgnLzzL?=
 =?us-ascii?Q?XNRiUcrHDl7DKpkJe9icCKRE+zAuOe1wiVMRtjVPT5VJDbxcfZSsrA8JXJuM?=
 =?us-ascii?Q?oIJPNKRYVd3yEiYbBWfQmceUJL0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 741a08d8-214d-45a4-19c3-08d9f411a2ad
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2022 01:38:03.1604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9vkfTx/Wt41LY3+ZRKvb0g5jG3gbI4OalSwF0jXne34psxhHnwQN2R5ex2JoeVzdEphRskWTrlwd4u/+YKoc5M9Jia3XpCLqpKf4FZRbSIw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4502
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10263 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202200008
X-Proofpoint-GUID: gEQuD9QcCx_cl3-P0cAY7cYPnaB1o4Mh
X-Proofpoint-ORIG-GUID: gEQuD9QcCx_cl3-P0cAY7cYPnaB1o4Mh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Yang,

> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering