Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0eeaa0b7-7ae6-c244-cfcd-86333d8f9b8b@amd.com>
Date:   Fri, 18 Feb 2022 17:29:27 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] drm/amdkfd: Replace one-element array with flexible-array
 member
Content-Language: en-US
To:     Felix Kuehling <felix.kuehling@amd.com>, cgel.zte@gmail.com
Cc:     alexander.deucher@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Changcheng Deng <deng.changcheng@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20220218030943.1905838-1-deng.changcheng@zte.com.cn>
 <cbc80795-af46-21fd-dc9f-ce932be76d4f@amd.com>
 <ea7d5e53-c008-4833-a24c-a17522ce96b5@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <ea7d5e53-c008-4833-a24c-a17522ce96b5@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVRMamRqNnpTNUdhS3huTE12dDVuYlJ1b2pOY045T2lIS2p0d3BxMHl2K0wy?=
 =?utf-8?B?RnkyYzVuVStHL0gxQjk0VVhTNkNPK04wSDhJTTZoYVRrNCswRENDWWNQcDcv?=
 =?utf-8?B?bGlqMjMzeGRmcVNIQzRjdTE3d0xnSlJETlZsZ3BiVUZ0ZnFsOWtRaWtpZWhO?=
 =?utf-8?B?aFpUZzIyVE9UNHB2T0FTNlFGNHZBbWtiS0pmWThQaHJGV2w3Yk5wUGw0WmYx?=
 =?utf-8?B?KzZycHJEZFlSN3FBVThMS09SNUYwY0FEeEdzSFdrUVQ0VDdOQVIxcDFDNGxZ?=
 =?utf-8?B?UGV3UVRNbDd2NmROMWxJMVRETzRFOG9FMmRJNTZkeG1Yd3BVQTI0Q0cvb1Vw?=
 =?utf-8?B?aUNITENnSFVCWmVDYUdxRDBFUjM4a1dGREM4TDNUTHlna2lWMU9KWHhDYkVt?=
 =?utf-8?B?TzVJV0J6bXdkZ1NCL296cSsxVUNQMTdlVmVSOXRpQit5Uy9ITUo5MTVIc2g0?=
 =?utf-8?B?OTFZV1NYcVhkdG5sZkM5MVpEMHByVVRzaUg3M1pMbm5XSDlvZVlzT3JkcFZz?=
 =?utf-8?B?S3Y0TEpDaGxnTHArb0M0MEpSZGo3QWZNc1dtcktwQUxTeVBHSlpNbUkvdHJr?=
 =?utf-8?B?RHZ5MG4xTGI2QzJXUkw3bjJUSitSYkJLdDR4bno4TGpxRk8wYnZIUVFENEVz?=
 =?utf-8?B?RUxEY0NiMmxDa0NPY0ZwTFFMei9DbnJqeHRrS3RZUXhkdlBjaXJSRGF3SXRp?=
 =?utf-8?B?MUxmY3FKa004RHVVZEFWaXRuK1VGaVhqQ28vNTJhVVVUSC9KbEV0bjA1WDJB?=
 =?utf-8?B?K0UxZnRUMUpaR3kzRDU4N0c5V1ZrRUtTN05MeS9xTERMTnU4WDJUaGdaeFgz?=
 =?utf-8?B?VEZwWW5xYWhQano2YVNvR3J5ZUU3UEhkQitnbkJ6NldlU3p0MzFNOHVVSThj?=
 =?utf-8?B?czZjandMdTBJeVJ0a0RiTW01ay8vc0xIZTdCaVAwWVl3d1ZPT3d4eGRieDlo?=
 =?utf-8?B?eXdJM25KaFFaSkVLRmQ0VitqamJpSXluZkdFWFkvWDFZakpmTGhNT29XWllT?=
 =?utf-8?B?SFRaUGFJRkZMWitvVWlXU0tQZHdlZDVCRlhscFQzRlp1WXFYOTVvY0EwR1p4?=
 =?utf-8?B?enhNb3o5RlJFK05OcnAxbERBMnRSQXNuc25tL09CZDlNYk9OdUMvSVJESDd4?=
 =?utf-8?B?RklYZmZsN3VBN3AxWTFrNFFTQ0hFYXRSQUZTa2UrdkVuUVhRYWpvN0N1S0ts?=
 =?utf-8?B?cU9iQTNoM05uRzlKSzBBWWxsN1lWTEI2UFFKaVNHRVJwS3A0dUV0M1ZBRmNR?=
 =?utf-8?B?UHlEa0lrTU5KVVFNaUR4S1JaeXg4aXJINEN0TXNqTnU4c1Zya09jUjczZlJX?=
 =?utf-8?B?Mm9wRW1zT3cxZnBqNzdSK0dGcG9yNHZzZ29hYW85bjUrWVJNY3YraXN5akhI?=
 =?utf-8?B?Tkx0NmU5dzR5V2pqcjVBNkh1YXNIVEhjNHRrdUFIT1FhTjJOYm4yK2ozb3NW?=
 =?utf-8?B?YzYzNVpwdUhzQnF1MUhIS3RLbW9hWlVjZUljRUlKaG5MNTlSTEYva0hOaDFY?=
 =?utf-8?B?Wk5DZElxWi9iUGcybkpjd2s3UVIwM01OWXphQ1FYNXpiQSswQk4vNk5qM1RG?=
 =?utf-8?B?YWh6VU53ZEJIRFBKTDltOWFRdFBHWE15L0JLU0FLaCtwTy9qMHpWT0o2T2NI?=
 =?utf-8?B?UHRNT2ZDbStnOWhiWWNLNEhBSUV0aHM5WUoyTjkzSTVqekVLUmY2ZUtRQ0lB?=
 =?utf-8?B?RWlHemUrZExVVDRSYmNIbjV6cEYrZDRmbDNlT2Y3Ry9kenl2UytDTjlTTjk1?=
 =?utf-8?B?a01rOVlDNzJ5bHBGUVF1eU9XdVNhVDFvYmoyalJESXVFUDBkSGtCVjdRWGVY?=
 =?utf-8?B?ZmZEUXZuVHZkVndCNENhQUlaUUpzMW44ZVhBLzNWWERNRGlnVlpzYWhCdzNs?=
 =?utf-8?B?WldZdXFWVUJoN2Z1cFVTcDRyVExHWEo1YUxwbHZjaHVtMTNqcWhnNmR1anJX?=
 =?utf-8?B?bGcrOG1Uc2JtU2h4Wjh1cmNiM1NoNGRXY0NrdXcway95czZ3WGlLd3lHcms3?=
 =?utf-8?B?NHVEdk84U2RIV0x2ZnFiK3BQOElLdGowaVNyMTVTQjlPaFJnK2FxYnd3bVA4?=
 =?utf-8?B?UUZFVlAwNVBuZkVwS2IzWDFYNXB5UGxQTHpLZ2doL0N4ZStXaVUzajBXRnVU?=
 =?utf-8?B?OCtORHR1cU9ZYmdLbEltNjVBQWdsWTJ0S3ZJTUt3OWtxMG9nUEdjRWNENE1C?=
 =?utf-8?Q?cPdAane9G8Ju/i5bY9BEXVA=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9665614f-e6e8-44d6-9459-08d9f2fbd929
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2022 16:29:34.5760
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2qNKS6WB684UNov05ByzQKkRMhSAeFtX1v4UL9noI0odm5A8qlAfYBN5ZVFi1rH7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4845
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Well in that case somebody could argue that we should probably remove 
the structure altogether.

Regards,
Christian.

Am 18.02.22 um 17:15 schrieb Felix Kuehling:
> It looks like this structure isn't being used at all. So I'm OK with 
> this change, in case we ever use it in the future.
>
> Regards,
>   Felix
>
>
> Am 2022-02-18 um 02:47 schrieb Christian König:
>> Felix need to comment as well, but I don't think that this will work 
>> that easily.
>>
>> By changing the entry from 1 to 0 your are also changing the size of 
>> the structure.
>>
>> Regards,
>> Christian.
>>
>> Am 18.02.22 um 04:09 schrieb cgel.zte@gmail.com:
>>> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>>>
>>> There is a regular need in the kernel to provide a way to declare 
>>> having
>>> a dynamically sized set of trailing elements in a structure. Kernel 
>>> code
>>> should always use "flexible array members" for these cases. The older
>>> style of one-element or zero-length arrays should no longer be used.
>>> Reference:
>>> https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays 
>>>
>>>
>>> Reported-by: Zeal Robot <zealci@zte.com.cn>
>>> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
>>> ---
>>>   drivers/gpu/drm/amd/amdkfd/kfd_crat.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.h 
>>> b/drivers/gpu/drm/amd/amdkfd/kfd_crat.h
>>> index 482ba84a728d..d7c38fbc533e 100644
>>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.h
>>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.h
>>> @@ -310,7 +310,7 @@ struct cdit_header {
>>>       uint32_t    creator_revision;
>>>       uint32_t    total_entries;
>>>       uint16_t    num_domains;
>>> -    uint8_t        entry[1];
>>> +    uint8_t        entry[];
>>>   };
>>>     #pragma pack()
>>