Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible
Thread-Topic: [PATCH] ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible
Thread-Index: AQHYJitP/nu5LcwZQ0S52dNHzV9R7aycC/4Q
Date:   Sun, 20 Feb 2022 07:53:16 +0000
Message-ID: <OS0PR01MB5922D806D40856485CDD612086399@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <3d67f0369909010d620bd413c41d11b302eb0ff8.1645342015.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <3d67f0369909010d620bd413c41d11b302eb0ff8.1645342015.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rrg1Fh0WlJ9LXFatbMZ6fRPi6uLTan4q0HD0x1pE5njci3fY01qkZ6vpsj9W?=
 =?us-ascii?Q?+m3IOwqxpytXUk01V7rDpS8BpSGHrQdKJyPFTrgCCZnnGVdyYI0AihTfloKz?=
 =?us-ascii?Q?XmGiVSyNMc0v2hkvTJU3fdMSLNmUyq54oEM9F/G3UCDCOlzKHVkHnWzY9NRW?=
 =?us-ascii?Q?LUc6+9kT/iSGA5wBSsKJwK2caNEetMEVRfL+o03CX3cJ1I7HG8/Y1UPQ8mRz?=
 =?us-ascii?Q?fctY5rSKMgpNeSM+cwfFcV+cwlECVwGsexA2Z3n7EDAvHCy0NwywmpT9Jdnc?=
 =?us-ascii?Q?TEa04Z+De1V8SWel4zsbzYlVJA+ZiXv0ZJnJMox5OEYubSLY4xkhgYpw0iLY?=
 =?us-ascii?Q?V6I6uNj/graXDVav8GVMYWT5uul1Kn7rGQWHsZpffy3pFQQoxSbH9kJKvzNo?=
 =?us-ascii?Q?44WVBnX3k1eEWKff9uS43Y2ZhoK12jfGE7LZlpRXNnLQkz9nRCgzYOyO9jan?=
 =?us-ascii?Q?b3Pse4qnDK8m3UTC55x5FKJ1AuXmeXSIhleK+87CYaZUTj61UBwuq8m1jOUs?=
 =?us-ascii?Q?CD8xKDUNWCmDwkZ6rSdojufFxkQpaTPQDUe0QZYF6yYohHCfzDZJrzf36Dy7?=
 =?us-ascii?Q?HmUp/gXTILQ+CI8czkFrtj8EJuPovOYI/ymXClzrZamXG6xj7syRJbUn0m2p?=
 =?us-ascii?Q?HFOr6UjOqe83K1W++RgiaFcl+m2J1DwSD2gHlnkVQjfqhKr0mQjDhzW3qe8V?=
 =?us-ascii?Q?otDR1xpOhVBm43HA1WlM0Wckx/ItN91g6gP4hlkHCjKxcILRPFMBz09REfwz?=
 =?us-ascii?Q?ePiiq4N+5lYdpi35/iiroVqi+byc4MUaly3pIEXKa08o2QpaQj6sz7R4gzzY?=
 =?us-ascii?Q?7h1aIvswfvBCucU2NmUgW+bCv3bhZJgEjpjnpxtbx/Q84mzfHVnbeE4Vq/q8?=
 =?us-ascii?Q?WHrmXse52WzG9sH8DVwk/6MVKep81KTQC7+WIfHREqE7ejvsB83Af7URdtPp?=
 =?us-ascii?Q?spa46e84jxy07Thm5j98sIWSbSQJkSVlX0M9IOEcNIeenaeBwTHHKnFRAp97?=
 =?us-ascii?Q?opj56w/FdrKAhqqy7k1qSXNuFJyC5kCk+ERv6jqy8+sy9zBEHJndCyHBY6Kg?=
 =?us-ascii?Q?+PMThRKPPpdzX53TNtyZB3JPdG6H037yGBrKyimyCE93q+Vb0g/QKEIV5Ebv?=
 =?us-ascii?Q?/5HgDTMEv1k+Jm/aQ4ztdVXUcDNDZJeu5NWe2QUMVQ9i+mbxnpQTf0wivwsv?=
 =?us-ascii?Q?0jnOfh/UJoftzizduoD/3bapwLgILEpC3cOiHwQzF99Vd9gBCxjEz5O2BgnQ?=
 =?us-ascii?Q?xODv8UOZzBYjduXRe8jZK8uDbyGwkekKg0dpNP3fPoSuYB7HjAI9XPT4QGh6?=
 =?us-ascii?Q?PTleIr2/hHclldknZRChwLQ5ts27dbyH4aKgvC0aL7V2TN80W3S7iVePbm0v?=
 =?us-ascii?Q?6BxWmVfF7VU+c+tzNd/zbpvUQddGoGXkknREXwU4NacEItuCfbN5MFXXgUEf?=
 =?us-ascii?Q?OH/twlOFuRQDAw6i6HCGM191rQ7IgyyRdt28YFJSLW9ovk48JJSgaDMLFC7w?=
 =?us-ascii?Q?80OOcb4EIeqpvicgQJhmbEbo/gqzP9Ys0I7UFx5lWQSxVfoYi9HHqagrDZDp?=
 =?us-ascii?Q?5PLuyDymJbSVpVC4hQNmzV59LdmmWT+o66LMGrblnRMeMn0Hhys0jG2GH+ri?=
 =?us-ascii?Q?37dHBQBMUO45jUeob9cQOP6Sh/568Q6X9tjq5XHL9T0vuBfvGhBIW0W9LrNq?=
 =?us-ascii?Q?tLP6aw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85738381-bc24-450b-568d-08d9f4460dba
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2022 07:53:16.4200
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OQPn3v/8nDLRU/F2jNlwJjOtVs67AXUooQqH1yX840HEUtgVsrmx2QSekllL65i033XGorrQfSQJC27Y3DVwTevfFI0XX2L9xQk0v1gXJTY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB5418
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Christophe,

Thanks for the patch.

Just a  question, As per [1], former can be allocated from interrupt contex=
t.
But nothing mentioned for the allocation using the patch you mentioned[2]. =
I agree GFP_KERNEL
gives more opportunities of successful allocation.

Q1) Here it allocates 8K instead of 1K on each loop, Is there any limitatio=
n for netdev_alloc_skb for allocating 8K size?
Q2) In terms of allocation performance which is better netdev_alloc_skb or =
__netdev_alloc_skb?

[1] https://www.kernel.org/doc/htmldocs/networking/API-netdev-alloc-skb.htm=
l
[2] https://www.kernel.org/doc/htmldocs/networking/API---netdev-alloc-skb.h=
tml

Regards,
Biju

> Subject: [PATCH] ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible
>=20
> 'max_rx_len' can be up to GBETH_RX_BUFF_MAX (i.e. 8192) (see
> 'gbeth_hw_info').
> The default value of 'num_rx_ring' can be BE_RX_RING_SIZE (i.e. 1024).
>=20
> So this loop can allocate 8 Mo of memory.
>=20
> Previous memory allocations in this function already use GFP_KERNEL, so
> use __netdev_alloc_skb() and an explicit GFP_KERNEL instead of a implicit
> GFP_ATOMIC.
>=20
> This gives more opportunities of successful allocation.
>=20
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/net/ethernet/renesas/ravb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c
> b/drivers/net/ethernet/renesas/ravb_main.c
> index 24e2635c4c80..525d66f71f02 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -475,7 +475,7 @@ static int ravb_ring_init(struct net_device *ndev, in=
t
> q)
>  		goto error;
>=20
>  	for (i =3D 0; i < priv->num_rx_ring[q]; i++) {
> -		skb =3D netdev_alloc_skb(ndev, info->max_rx_len);
> +		skb =3D __netdev_alloc_skb(ndev, info->max_rx_len, GFP_KERNEL);
>  		if (!skb)
>  			goto error;
>  		ravb_set_buffer_align(skb);
> --
> 2.32.0