Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 3/3] net: tun: track dropped skb via kfree_skb_reason()
To:     David Ahern <dsahern@gmail.com>, netdev@vger.kernel.org,
        bpf@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
        rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
        joao.m.martins@oracle.com, joe.jin@oracle.com, edumazet@google.com
References: <20220219191246.4749-1-dongli.zhang@oracle.com>
 <20220219191246.4749-4-dongli.zhang@oracle.com>
 <29ff2768-ca3f-6a09-1df8-d703f85ecfac@gmail.com>
From:   Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <bc0e5a09-e139-0753-26f8-5bc5634a020d@oracle.com>
Date:   Sat, 19 Feb 2022 21:40:43 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <29ff2768-ca3f-6a09-1df8-d703f85ecfac@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkE1MkJPOWNPR3JDUFdPcVE3Zkc1OXJmYUhocFZlQjVndkY3SGtlUXR5V1R1?=
 =?utf-8?B?RU9rRnIvSTJMN0lsc2JGR09jdHZNNkg1Y3VXeWtsNWFkcHJ6UStKVkFIOExV?=
 =?utf-8?B?aXlZUWltMzJPS3ZPTVVMMkZubmc0NXFQWTJhcGNCOC9rb3VJS2hQdVduQTd3?=
 =?utf-8?B?bFFydytsbHNKTDU2UVFGcWxZd0g3TzJDdTQraTNWQ2tnb05VRzl6c2M5WFl2?=
 =?utf-8?B?OVFKcVFDVUpRcGVMVU1HZWl5V20xZDdiMkU2RHdZaGNEZCt0eVNVVXBvbXpL?=
 =?utf-8?B?NFNtY29adkhMSTRZaGp4UlVTS0VQZkpVQVN3Nk9WcWdEK0dMOUMzcWZob0JV?=
 =?utf-8?B?ZjduMVZ4YStobk9zdE5ZMEYyRlh1SE5raTIvRmZJa2JOZDd5NmhwWVpRaHg5?=
 =?utf-8?B?RkhMVWlzZGRoelg4dDc1MmJ4N3U4ODg3Mzh1QjlSVFhNcENRakhob0grR0FT?=
 =?utf-8?B?RFhEYjlFbG9GN2hFeXFNSk5oUS9oVG41OE5uREFyYUxMTmxVRlVxMTdyYWFH?=
 =?utf-8?B?UXU5dkFSUUFhM01VSGtaU1BYMVFDZWRyQ0N0Z2ZUcUNja3FlRk1vWTAzeFNx?=
 =?utf-8?B?aFRXL09hNnJTOC9mSXVnakErWjZ5cm9GTmZjQ0VPM2hyVyswcmk5Y3VQQndj?=
 =?utf-8?B?ZWsrdGh5bWxRTFYxbG10b0E3TnBtYmFyeklWYUxBSWcvbkM4MElOWmdGdTY0?=
 =?utf-8?B?akRDdEkxVENwSWtReGFzL3BiV01Lb3RXL1VXSm9YU3VuQ0w2WitrWmtBdHNo?=
 =?utf-8?B?TjdGRFNZaUNVZUdZV2w1QTNVczkwVUtjZlRrUkx1YXI3NXdQcVN2aWRmRFZi?=
 =?utf-8?B?RGdaR3BZQWNJSGNCamE0MVY4UjU5WVRvRUNtNUp2b0pvczBBT1hzODZYaWlR?=
 =?utf-8?B?Q0lUTWdIQnBqSXZVQmFWai9ZRUhNUkRIdlhPZkpaSDBLSk1ZWFEzemtqaFFF?=
 =?utf-8?B?clhCZERiZUg3dGhvMnBBV3RGNUhMWEtzUFAwTWZKSm5LbU1vdzlpQ1pFMkJS?=
 =?utf-8?B?L1ErMlduNlhxVCtNL2tqZjZEUk5HbWRqWVRmSldER09tdUF5Wm10bTJja3pI?=
 =?utf-8?B?ZlZ5R0ttT2pYbVBBTjQ2SVJuSlB2bTdJZ0p3MFZ3Ni94WWMzR0lsWnRyRE9H?=
 =?utf-8?B?RU9DbXZ6RmdvQ1VLZnUvNjloSGdnTHprMUdLbHE0ZXVwQ1VkOVR4MUd6MCta?=
 =?utf-8?B?T0NVM0ZISURtVUJQVzVFRFVySFlyaWVnY09NRUFQcktRdUZ5QjVidDFZbDdM?=
 =?utf-8?B?NnExN25PT2ZjeXZMNWNGR1l3RDRGeGwrcGc2OFVkUzhvWnk2dk1xL1JPNkJH?=
 =?utf-8?B?Z1o2TzJPVjh4dkJBREdNczhXYlpnazZvWEtRVGVEUXJCVy90eFcrMVhmak41?=
 =?utf-8?B?ajEwUTVLSXhpT0F0YVNBZGJ0OEppZ2hVOVFuNE1UZ2NlSzNiNjh2VUtVLzJV?=
 =?utf-8?B?RzR0aG9URnEwS1lPeTA0NEh3OHhrbUczYkIxLy9xblpIVitGZ25remQ1ZHVa?=
 =?utf-8?B?enRkRUFrZVZaejFpZ1ROTVpCRTBVbGE5WkZTSGdCbWxWTXZ6c3IxWEJKaTBi?=
 =?utf-8?B?N0F4YkJsaE9tM2RWOWxxUk4wRGN6bS8renkvVDRoeXY1NEVzd2dkQ3ZEMHpR?=
 =?utf-8?B?dVlvUkR6RW5TcnJlaGx1MjcxVERFSzNwbDVjWHhVckNWbTVCb2RHUXVjcllm?=
 =?utf-8?B?cERsUXJwTHMvQXRsM0NiNTJucVo1akRHUC9wamRFUDNLVVFMVGlHVXdZZUp4?=
 =?utf-8?B?SXVDQXRISzVKQjM2R1g3cUE0UXFJL284RS91U0FZZFdNUW9MUmptN0RtSHRw?=
 =?utf-8?B?bjB2QjVZK0dEZThjZ1VUNFF0SFhIMXFSdEZ2dCthYzVWNHU2OGZFb0hQb2VE?=
 =?utf-8?B?aVF6ejV5a1FaS1JvZ3NiVGJKSHNTVGtONE0zNG1tQWRTQnQ4N0pLdnBFaUVj?=
 =?utf-8?B?RXJhQlFhYWxaNzlGUXpxbDFvRHhIWndmZnF0WW0ya2RSRG94UUtHMnpWQzdY?=
 =?utf-8?B?V2R2K0k2NHhIMXhMaWFha09kVGV2bVM4MGJNRFBlc1VzelNoSkNPQjBVT1p2?=
 =?utf-8?B?MFdYN29xVjFpbkhIN1F3UXhzSUZqendOMmhBQzEvWm9HOGpMcU9EQU9BNFZo?=
 =?utf-8?B?bTlTQlNwbFkxakdEZnNQZXE5VDZ2VldXQlhYZ25BejRSRkcyVThmTVN3a0Zp?=
 =?utf-8?Q?NFi3/OPmvU66S5IcWBcVvUoPewzA4OI5wT761Ex9wN95?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8868ef8-44e2-4830-da05-08d9f4338a03
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2022 05:40:44.7372
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RHHaxeUNMcVA0270eC+aLvpiXYW8ezjwJLjaM5WCCJXjSCLJAqxOgfFMSFXUf5rZt2l8ViZE7zWc/W9C1T3scw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4136
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10263 signatures=677614
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2202200037
X-Proofpoint-ORIG-GUID: vtFxWzf1YWjcGsUlMJgg4qyHa7LutTt6
X-Proofpoint-GUID: vtFxWzf1YWjcGsUlMJgg4qyHa7LutTt6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David,

On 2/19/22 2:54 PM, David Ahern wrote:
> On 2/19/22 12:12 PM, Dongli Zhang wrote:
>> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
>> index aa27268edc5f..ab47a66deb7f 100644
>> --- a/drivers/net/tun.c
>> +++ b/drivers/net/tun.c
>> @@ -1062,13 +1062,16 @@ static netdev_tx_t tun_net_xmit(struct sk_buff *skb, struct net_device *dev)
>>  	struct netdev_queue *queue;
>>  	struct tun_file *tfile;
>>  	int len = skb->len;
>> +	int drop_reason;
> 
> enum skb_drop_reason
> 

As mentioned in previous email ...

According to cscope, so far all 'drop_reason' are declared in type 'int' (e.g.,
ip_rcv_finish_core()).

I will change above to enum.

Thank you very much!

Dongli Zhang