Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3308673pxb; Sun, 20 Feb 2022 15:58:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJyWHGOsU5k8xpI3RDey3BGA/7vs1yp36B5mnQM3Pxn0Ed/hgDz1SxfxqG5uiTdJl6bYj9PY X-Received: by 2002:a17:906:ad8d:b0:6ae:9bd6:1e9a with SMTP id la13-20020a170906ad8d00b006ae9bd61e9amr14142295ejb.337.1645401524159; Sun, 20 Feb 2022 15:58:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645401524; cv=none; d=google.com; s=arc-20160816; b=lu7Kc3/EvR3YqIwLbcLP9vcUv6TtAlUCWbjPDXQCIS3GRoomjqpGCR1UXq233poyfQ TggpCqtO3LDdAcrN5kTBT5yXNqkhqw7O/Z63yxJdUbz7a/CgOVqrJX4ZYz2rUyj/Tx4W CfU5Ny/dhsoqURjUnmhvXQu3empdFz2RlekF0N9oUNa2I857M5HnVqVBLfucQ3sia2or HtDIf7yeAwp2hZIsDXJZQi+4CLDZykoAqO0pucbJLiznce35P/BQeqoVjSeei+wbTmxi 4WTsbR2yCuXm76fIWnUWrpyrrahe7IcEvrn2I+JcT/poOUd/SQo2EZZXYh8RbQvGubX0 ywJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=CV6HbcwliU0IroxaUrTuSWAErmjUDg/duewdt/Iw9ac=; b=UbbPMDZNlsqsKETiWuTBQAQXhJ+enNOYhR/ybnR+T1jHR5QzinraEhygA9p65HIWoz pguW2id0/6qlMDNZcUfXtg5H5eoiHPkmPsaNL4ohSAHSw3K0un3DBbzCKuxrH0FGp9Pi 2ytHgP6FXKJDPJWyCj3GW0jvvjOOhPaOsSiGb65C/1BhlHYAUvP2fMh9KOhAnRlzk1Gb 72OXw7/vKbtqDyhuOr8kRY9AsLQRZH2OQtCBLwPNbyJZPBLKCZMNc4P14H0csOQozRgW Mf4ejH2E6oDFHST7huP+vqzeI+RhHfhjdKunbYYVANMBHp1TCS8qjXUFJh0BMuBWjT8L nqPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQz1Ufsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ne40si9242436ejc.219.2022.02.20.15.58.22; Sun, 20 Feb 2022 15:58:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RQz1Ufsm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241298AbiBSENP (ORCPT + 99 others); Fri, 18 Feb 2022 23:13:15 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:38838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232992AbiBSENO (ORCPT ); Fri, 18 Feb 2022 23:13:14 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56FA9E98E3; Fri, 18 Feb 2022 20:12:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE10C60018; Sat, 19 Feb 2022 04:12:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F912C004E1; Sat, 19 Feb 2022 04:12:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645243975; bh=6KkYYqoGjahK/UfJGfOIukayZSuSwHiDxr1L4Yg+7/Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RQz1UfsmsuxnNg8ilQqILcyrhkkouStDQOxRxgrMQG5X/Fng40tFLkTTa4OSbBB9L q72Qii/G5KSVbKq6urMz5bBvNqycKMXQp6UNbGy877FrmXyS/jCEtoqexg+h+1wpw8 ErCKEgWMdbICMFMZtZf6pEMU2KeemErkT14JdU6RxLp9OKm00PbFn17Q+O0wJkFICU Q3sea5mlZIzmZ+3n6Kv6OVZ+Ohl7YEk5CW7DwU4HxuziAoUrp4d08zIRdxS7ZmAeTV 3ZkOwv0QdnFQ2dx3Ix2VSNqNmstKxGy1l2YiIF/+zqrKuwCmk2rjAW6Ic0K95kh/y/ IScd/zTAuV+FQ== Date: Fri, 18 Feb 2022 20:12:53 -0800 From: Jakub Kicinski To: Jeffrey Ji Cc: Eric Dumazet , "David S . Miller" , Brian Vazquez , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jeffreyji Subject: Re: [PATCH v7 net-next] net-core: add InDropOtherhost counter Message-ID: <20220218201253.45874082@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20220207235714.1050160-1-jeffreyji@google.com> <20220207195139.77d860cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 18 Feb 2022 13:31:03 -0800 Jeffrey Ji wrote: > Hi Jakub, I'll remove the MIB counters & instead add counters to > rtnl_link_stats64 and rtnl_link_stats, does that sound right? Yup! I'd ignore rtnl_link_stats, actually since it's legacy and just add it to the 64-bit version of the stats. > But keep the sbk_free_drop_reason sounds good