Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3456098pxb; Sun, 20 Feb 2022 20:54:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzPAINof9EY1KmXgUg36ic7Xg9MffE8HYrPu8TOQWQMFW1sMme3N++eXnSEuahpd5eYDUCh X-Received: by 2002:a62:8f87:0:b0:4cc:3f6:ca52 with SMTP id n129-20020a628f87000000b004cc03f6ca52mr18373292pfd.79.1645419271036; Sun, 20 Feb 2022 20:54:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645419271; cv=none; d=google.com; s=arc-20160816; b=Dv6ZSRB3iZDYMYSVr63g57xmFsbemLa7Z2LfGtsVMTa7BQh0OeHLsdRJ1OgItf4B95 d0sPonjs4YKVkSj65WKDlM40ZqHwh3SCj3uGKUWFZb60c7ILELe9nGmcRRO90wvTm6EM 5K1zhMtiv6FLiJdMU07mH1L/1zWyX9CRMNJfhPVbdlKfbhWa3RbkQDhr93EVBUehydRA clVLQTXK+tP/QFg5MqC2ABmHCSTZYlmcWbk22cQxDE/NmNswkr9O/BYhvhSFx0xbxiF8 e/Yflz8K78TADynMHtugWH2fGtM0BBI9EGF6pqtlKkO7OwOuyeovbEVhj2ueFUIWS7iC WA1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=eW2EF9KhbxD/xeYhjLPuOXu24eU0UCl7yLAwYlOuKhk=; b=yWykMpgEUNR2JzGYUCZKRPgf7P4TewUpAZRmscN6VZ8UWspVMuNPUX4GFfKGM59Hz7 1c9drvxpa6C4Kc1K9yOqlM0P8WiyT5qM8cTtNJkxzbE3IrkPaIwjjthGcKh/wuc48blB nd8y/hkIB/M+4c64HA8qtyS5lGVagbhQstxJ+TrWPxjDz5Zm3depeTCcIZ4Z9X06VP95 E6RHEVCRj8SNBBJkny5OPL5ph07fi3tnUh6vw61dJoYiw02kzX3DZP+6/D0VCblKpCKl w8gQyMx6IuzOwipu52CQvmaR7+C2IL7mbNXiV1HP2OlVfW5e3o077IbtOhdmp+FAeegg M+WA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZnpdyCtP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j24si16600005pgg.128.2022.02.20.20.54.16; Sun, 20 Feb 2022 20:54:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZnpdyCtP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241120AbiBUEJQ (ORCPT + 99 others); Sun, 20 Feb 2022 23:09:16 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:42030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240384AbiBUEJN (ORCPT ); Sun, 20 Feb 2022 23:09:13 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D1FEB4839B for ; Sun, 20 Feb 2022 20:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645416529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eW2EF9KhbxD/xeYhjLPuOXu24eU0UCl7yLAwYlOuKhk=; b=ZnpdyCtPY+kUzmHdtA/XwO/qnqMMqnbkHs9eoYy2wcMaTe1wlnOI2O7RdWbP1KqnLyFCRy RD9SENUxeVJea5HQqSfGaD34KqC694wOm5b/nVORcRgT4nA+ZlLj+o4dDsDYTO72CEmRLm jmH6nG3r2ONL84TiRFkN91FcKpzJOjs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-68-33CBz0O2Pzy_eK1Z04lQxQ-1; Sun, 20 Feb 2022 23:08:46 -0500 X-MC-Unique: 33CBz0O2Pzy_eK1Z04lQxQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F212801AC5; Mon, 21 Feb 2022 04:08:44 +0000 (UTC) Received: from localhost (ovpn-12-166.pek2.redhat.com [10.72.12.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B9294D73A; Mon, 21 Feb 2022 04:08:28 +0000 (UTC) Date: Mon, 21 Feb 2022 12:08:25 +0800 From: Baoquan He To: Eric DeVolder Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, ebiederm@xmission.com, dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com, robh@kernel.org, efault@gmx.de, rppt@kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH v4 00/10] crash: Kernel handling of CPU and memory hot un/plug Message-ID: References: <20220209195706.51522-1-eric.devolder@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220209195706.51522-1-eric.devolder@oracle.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Eric, On 02/09/22 at 02:56pm, Eric DeVolder wrote: > When the kdump service is loaded, if a CPU or memory is hot > un/plugged, the crash elfcorehdr (for x86), which describes the CPUs > and memory in the system, must also be updated, else the resulting > vmcore is inaccurate (eg. missing either CPU context or memory > regions). This version looks much better. I am gonna to review this week and give it a shot on a machine. Can you share your test steps? I have knowledge about mem hotplug, but haven't tried cpu hotplug yet. Thanks Baoquan > > The current solution utilizes udev to initiate an unload-then-reload > of the kdump image (e. kernel, initrd, boot_params, puratory and > elfcorehdr) by the userspace kexec utility. In previous posts I have > outlined the significant performance problems related to offloading > this activity to userspace. > > This patchset introduces a generic crash hot un/plug handler that > registers with the CPU and memory notifiers. Upon CPU or memory > changes, this generic handler is invoked and performs important > housekeeping, for example obtaining the appropriate lock, and then > invokes an architecture specific handler to do the appropriate > updates. > > In the case of x86_64, the arch specific handler generates a new > elfcorehdr, and overwrites the old one in memory. No involvement > with userspace needed. > > To realize the benefits/test this patchset, one must make a couple > of minor changes to userspace: > > - Disable the udev rule for updating kdump on hot un/plug changes > Eg. on RHEL: rm -f /usr/lib/udev/rules.d/98-kexec.rules > or other technique to neuter the rule. > > - Change to the kexec_file_load for loading the kdump kernel: > Eg. on RHEL: in /usr/bin/kdumpctl, change to: > standard_kexec_args="-p -d -s" > which adds the -s to select kexec_file_load syscall. > > This patchset supports kexec_load with a modified kexec userspace > utility, and a working changeset to the kexec userspace utility > is provided here (and to use, the above change to standard_kexec_args > would be, for example, to append --hotplug-size=262144 instead of -s). > > diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c > index 9826f6d..06adb7e 100644 > --- a/kexec/arch/i386/crashdump-x86.c > +++ b/kexec/arch/i386/crashdump-x86.c > @@ -48,6 +48,7 @@ > #include > > extern struct arch_options_t arch_options; > +extern unsigned long long hotplug_size; > > static int get_kernel_page_offset(struct kexec_info *UNUSED(info), > struct crash_elf_info *elf_info) > @@ -975,6 +976,13 @@ int load_crashdump_segments(struct kexec_info *info, char* mod_cmdline, > } else { > memsz = bufsz; > } > + > + /* If hotplug support enabled, use that size */ > + if (hotplug_size) { > + memsz = hotplug_size; > + } > + > + info->elfcorehdr = > elfcorehdr = add_buffer(info, tmp, bufsz, memsz, align, min_base, > max_addr, -1); > dbgprintf("Created elf header segment at 0x%lx\n", elfcorehdr); > diff --git a/kexec/kexec.c b/kexec/kexec.c > index f63b36b..9569d9a 100644 > --- a/kexec/kexec.c > +++ b/kexec/kexec.c > @@ -58,6 +58,7 @@ > > unsigned long long mem_min = 0; > unsigned long long mem_max = ULONG_MAX; > +unsigned long long hotplug_size = 0; > static unsigned long kexec_flags = 0; > /* Flags for kexec file (fd) based syscall */ > static unsigned long kexec_file_flags = 0; > @@ -672,6 +673,12 @@ static void update_purgatory(struct kexec_info *info) > if (info->segment[i].mem == (void *)info->rhdr.rel_addr) { > continue; > } > + /* Don't include elfcorehdr in the checksum, if hotplug > + * support enabled. > + */ > + if (hotplug_size && (info->segment[i].mem == (void *)info->elfcorehdr)) { > + continue; > + } > sha256_update(&ctx, info->segment[i].buf, > info->segment[i].bufsz); > nullsz = info->segment[i].memsz - info->segment[i].bufsz; > @@ -1504,6 +1511,17 @@ int main(int argc, char *argv[]) > case OPT_PRINT_CKR_SIZE: > print_crashkernel_region_size(); > return 0; > + case OPT_HOTPLUG_SIZE: > + /* Reserved the specified size for hotplug growth */ > + hotplug_size = strtoul(optarg, &endptr, 0); > + if (*endptr) { > + fprintf(stderr, > + "Bad option value in --hotplug-size=%s\n", > + optarg); > + usage(); > + return 1; > + } > + break; > default: > break; > } > diff --git a/kexec/kexec.h b/kexec/kexec.h > index 595dd68..b30dda4 100644 > --- a/kexec/kexec.h > +++ b/kexec/kexec.h > @@ -169,6 +169,7 @@ struct kexec_info { > int command_line_len; > > int skip_checks; > + unsigned long elfcorehdr; > }; > > struct arch_map_entry { > @@ -231,7 +232,8 @@ extern int file_types; > #define OPT_PRINT_CKR_SIZE 262 > #define OPT_LOAD_LIVE_UPDATE 263 > #define OPT_EXEC_LIVE_UPDATE 264 > -#define OPT_MAX 265 > +#define OPT_HOTPLUG_SIZE 265 > +#define OPT_MAX 266 > #define KEXEC_OPTIONS \ > { "help", 0, 0, OPT_HELP }, \ > { "version", 0, 0, OPT_VERSION }, \ > @@ -258,6 +260,7 @@ extern int file_types; > { "debug", 0, 0, OPT_DEBUG }, \ > { "status", 0, 0, OPT_STATUS }, \ > { "print-ckr-size", 0, 0, OPT_PRINT_CKR_SIZE }, \ > + { "hotplug-size", 2, 0, OPT_HOTPLUG_SIZE }, \ > > #define KEXEC_OPT_STR "h?vdfixyluet:pscaS" > > > Regards, > eric > --- > v4: 9feb2022 > - Refactored patches per Baoquan suggestsions. > - A few corrections, per Baoquan. > > v3: 10jan2022 > https://lkml.org/lkml/2022/1/10/1212 > - Rebasing per Baoquan He request. > - Changed memory notifier per David Hildenbrand. > - Providing example kexec userspace change in cover letter. > > RFC v2: 7dec2021 > https://lkml.org/lkml/2021/12/7/1088 > - Acting upon Baoquan He suggestion of removing elfcorehdr from > the purgatory list of segments, removed purgatory code from > patchset, and it is signficiantly simpler now. > > RFC v1: 18nov2021 > https://lkml.org/lkml/2021/11/18/845 > - working patchset demonstrating kernel handling of hotplug > updates to x86 elfcorehdr for kexec_file_load > > RFC: 14dec2020 > https://lkml.org/lkml/2020/12/14/532 > - proposed concept of allowing kernel to handle hotplug update > of elfcorehdr > --- > > Eric DeVolder (10): > crash: fix minor typo/bug in debug message > crash hp: Introduce CRASH_HOTPLUG configuration options > crash hp: definitions and prototype changes > crash hp: prototype change for crash_prepare_elf64_headers > crash hp: introduce helper functions un/map_crash_pages > crash hp: generic crash hotplug support infrastructure > crash hp: exclude elfcorehdr from the segment digest > crash hp: exclude hot remove cpu from elfcorehdr notes > crash hp: Add x86 crash hotplug support for kexec_file_load > crash hp: Add x86 crash hotplug support for kexec_load > > arch/arm64/kernel/machine_kexec_file.c | 6 +- > arch/powerpc/kexec/file_load_64.c | 2 +- > arch/x86/Kconfig | 26 +++++ > arch/x86/kernel/crash.c | 123 ++++++++++++++++++++- > include/linux/kexec.h | 23 +++- > kernel/crash_core.c | 146 +++++++++++++++++++++++++ > kernel/kexec_file.c | 15 ++- > 7 files changed, 331 insertions(+), 10 deletions(-) > > -- > 2.27.0 >