Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 20 Feb 2022 23:20:09 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        Steven Noonan <steven@valvesoftware.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Giovanni Gherdovich <ggherdovich@suse.cz>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND v6 0/9] cpupower: Add AMD P-State Support
Message-ID: <YhJcKXo5t6E/jy8x@amd.com>
References: <20220216073558.751071-1-ray.huang@amd.com>
 <8aafb93a-772c-1806-e087-cd285694aa74@linuxfoundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8aafb93a-772c-1806-e087-cd285694aa74@linuxfoundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UHzpVd38hmAw18LiyL8WeSYfESfwjH9cMjpdiLg4VqxrdoIbjyquByD6IT8D?=
 =?us-ascii?Q?yI2+2tSJEQCCGmkvv1J4JNsAyp7GEYAUDUDdrHnwqWzaxrZg0blo3u3lBjjF?=
 =?us-ascii?Q?SfHz+1ViCf5EZBQEoohypLzlqVJzx20aPOXM0c98jYZtFhybI/qAZxsrvbWk?=
 =?us-ascii?Q?OQZN24i56CKRCmLb3V2rT3QCMHH1bS6Bl1TyBnjeuzsuK+MYVjcBEJSTit3y?=
 =?us-ascii?Q?WfhKxkW/cAsUN7KoQvjgzILSHVGJ4XySd2NgBKxrVb1/LnbMxNLU2bLzsrL7?=
 =?us-ascii?Q?bfXvMefMTeGhlYO3z83K9vE3x1ifsWLYM7RnsGx/0RCRWIOedvZrPklpSaLH?=
 =?us-ascii?Q?4xoj452JugKjsCiIFsy3qkGak+cmVnu43+25Wj9b+hvXypM8I6u3ix61e4U+?=
 =?us-ascii?Q?6qpPZFIkx8Tn8iC7Ou5td0fIdXJ5j89ZSBiWfJbl8OgKghCXB2mD43HflZi6?=
 =?us-ascii?Q?6MTUV+jRIUvqgD+KS7ChhduUl5jWNh0kW6vqy7YbZ6gbZ+iMTVtlLGIvtwfK?=
 =?us-ascii?Q?Q+Cnr2dNII5I2qoslZTXh0UnU7qPqGOHUwS3vuifwyr1QPO24toK3C4lVUfk?=
 =?us-ascii?Q?hbJZDjt+oEYH1TnY9orntYOAnskYnHKcdti/lAG+UT1VoMcF1eR39Yj3B0Z/?=
 =?us-ascii?Q?/b+hD7mCLcbdhyvgh4otnlOOb4gKVie1QLGmXaMnDKtust3awjMWeIU/CiYh?=
 =?us-ascii?Q?gn03Tgmqesr/LMaRA7Hlx0KmC/QxwzUR72syaV97BqNDpaVNG4DQkVFGWTZ8?=
 =?us-ascii?Q?Hl29ti0taSR5ynXVTKk7FGcPJz6zRczAJseuEGefsoN2RMYMlCBQMa8VdGk3?=
 =?us-ascii?Q?lj1gmaDp25Nhy0AqqYj0RvYwbkh5qfuHLd/nk3Q729jIb4l1J8/BOFpvmbBp?=
 =?us-ascii?Q?X/IThILC743Oq3nXKHv4LOSJeCy94sddUIyr4SvXVaO3Nx/VugBojLwy/wHB?=
 =?us-ascii?Q?/4kvEylPPA7DH+mr27aDm096gi9CSKCJgMF0O5PlHx9jvClCr0Xfwvv22xXy?=
 =?us-ascii?Q?cwn4F9sroV+HidXk7bqb/DBymKXm1UdpooWCvkg1kgn+vOTAWQ34HsKnrndl?=
 =?us-ascii?Q?gml9QQ5aTRlWvnpTznCsCK7L3Pd4sZhEbCM9WNHPCAOlBrftfzH8yAZ/BNu/?=
 =?us-ascii?Q?y8CPjpiyZpu1lnLoKKKK3Hi0WsXMHHhUfP/6NrkS7vOm5VkvFQ0vDzZOTsN1?=
 =?us-ascii?Q?aDHwsRVhY6og+v/5JW0X83c4pBVlXmBeu3USPoG/ywhlrXlWqoivG3WVFrtt?=
 =?us-ascii?Q?eS8FZcC6/sqwE2clmdlTVI+Oyf0tXG32lb095DceYhU1/nQU0sifNZGiO+z7?=
 =?us-ascii?Q?tWS1uFP5Qv1epqRn591U/manTagYeZqy1uW5Oh3LXlvyvynlVgNkJZy6KhXx?=
 =?us-ascii?Q?JRVagnWqhD3wrRS6rstKT21yqnoqGLqo4SBddx7iUsuOzzWkD/tfGyS48Wzu?=
 =?us-ascii?Q?ff7lJDONDMiUFVOVtku+SxSl48OhD04HIK/YTqILog9CH0sIe4SS/mZgRQED?=
 =?us-ascii?Q?fngrAetA0wiHJBiEDDPvWtXH8odCdEIYxpO1rEP2oPpetdgjOKRuo0FI1wPu?=
 =?us-ascii?Q?NOWt7jh1pCdncq26pwFM/IspG+Aw8cw2zIFVB1llliONeOXjevJDSqEqKyxJ?=
 =?us-ascii?Q?et/ihIfpvaWTxRBP8Abcmik=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3091c89e-e01a-4e43-5b58-08d9f4848924
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2022 15:20:32.5701
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yNJuomIEAKsaoP8eaBjrHGFfWCVS75/+WtV5qcNbbQqNBqlMzLG3Wi4/dhFoNoaDp0PFdWc/ZVABTkciQKSvAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4585
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shuah,

I am glad to see your comments again. Thanks for your time!

On Sat, Feb 19, 2022 at 08:27:41AM +0800, Shuah Khan wrote:
> On 2/16/22 12:35 AM, Huang Rui wrote:
> > Hi Shuah,
> > 
> > Since AMD P-State kernel is merged into 5.17-rc1, I would like to continue
> > revising the AMD P-State support for the CPUPower tool. These series are
> > rebased on latest bleeding-edge, any comments are warm for me.
> > 
> > See patch series of CPUPower in below git repo:
> > V1: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v1&amp;data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=L9G4msSTFHOztI8Dj5en2aC229%2Bn4xZl%2BGYMOG4R2dg%3D&amp;reserved=0
> > V2: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v2&amp;data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=ApWETuX6J%2BK5fbHV7ym0%2BYawxD3TAIqaffOCRlBz56g%3D&amp;reserved=0
> > V3: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v3&amp;data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=wBn4bLwo4H8E8OIKbtIQ9Rw9AJ49ctk%2FpisN1P32Xpg%3D&amp;reserved=0
> > V4: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v4&amp;data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=XITGUWrl4J01mx0V12Unn0ZuODqhAbLuS2eNUIM7IBE%3D&amp;reserved=0
> > V5: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Damd-pstate-dev-v5&amp;data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=D%2F2vCZrlrg3apxht1XX4GfRo1Unfc%2FMqyDX%2FRz0c%2FYU%3D&amp;reserved=0
> > V6: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Frui%2Flinux.git%2Flog%2F%3Fh%3Dcpupower-amd-pstate&amp;data=04%7C01%7Cray.huang%40amd.com%7C7f03b74e8f3044c8574008d9f33ea54e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637808272662923642%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=g%2FDKBuQirt3pB9dIXkTFbqjyz8LdWBFbhIZBYcRqD8o%3D&amp;reserved=0
> > 
> 
> A few checkpatch warns to fix. I usually ignore CHECK from checkpatch,
> but a few of them found on this series could improve the code.
> 

I will use checkpatch script to scan all patches in these series.

> Also is there a need to add/update manpages and documentation.
> 

Let me find a place to add some descriptions.

> I tested these my AMD Ryzen 7 4700G system. I didn't play with set commands
> and just the info ones.
> 
> cpupower info gave me this output. The first message is fine, but the
> second one is a bit odd. Should it just bail out right after the first
> message about "not support"
> 
> cpupower info
> 
> System does not support Intel's performance bias setting
> analyzing CPU 0:
> 

Let me take a look at this issue.

> Go ahead send me v7 for these and add any mapages/doc if necessary.
> I will get them into Linux 5.18-rc1
> 

No problem, I will address the comments and send V7.

Thanks,
Ray