Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 18 Feb 2022 12:54:11 -0800
From:   Ira Weiny <ira.weiny@intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
        "hpa@zytor.com" <hpa@zytor.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Subject: Re: [PATCH V8 26/44] x86/fault: Print PKS MSR on fault
Message-ID: <YhAHc8SkF/tV91ru@iweiny-desk3>
References: <20220127175505.851391-1-ira.weiny@intel.com>
 <20220127175505.851391-27-ira.weiny@intel.com>
 <2a919d9ed8ed874f8b89014c0b42cbadb44d837b.camel@intel.com>
 <Yg82L5ibjbn15AHO@iweiny-desk3>
 <d94be5f21bf18c844d7088a96ae35aa209a0ef4e.camel@intel.com>
 <edb6706a-6e06-2510-3bbc-84da97b8cd52@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <edb6706a-6e06-2510-3bbc-84da97b8cd52@intel.com>
Precedence: bulk

On Fri, Feb 18, 2022 at 12:20:58PM -0800, Dave Hansen wrote:
> On 2/18/22 09:28, Edgecombe, Rick P wrote:
> > On Thu, 2022-02-17 at 22:01 -0800, Ira Weiny wrote:
> >> Are you suggesting the PKRU should be printed instead or in addition
> >> to the
> >> PKS?
> > Well I was just thinking that PKRS should only be printed if it's an
> > access via a supervisor pte.
> 
> That's not *wrong* per se, but it's not what we do for PKU:
> 
>         if (cpu_feature_enabled(X86_FEATURE_OSPKE))
>                 printk("%sPKRU: %08x\n", log_lvl, read_pkru());
> 
> If the feature is enabled, we print the register.  We don't try to be
> fancy and decide if it's relevant to the oops.  Why don't you just stick
> PKRS on the same line as PKRU whenever it's supported?

Ah good point.  I'll do that.

Thanks,
Ira