Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030708AbXBOTPA (ORCPT ); Thu, 15 Feb 2007 14:15:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030711AbXBOTPA (ORCPT ); Thu, 15 Feb 2007 14:15:00 -0500 Received: from x35.xmailserver.org ([64.71.152.41]:1065 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030708AbXBOTO7 (ORCPT ); Thu, 15 Feb 2007 14:14:59 -0500 X-AuthUser: davidel@xmailserver.org Date: Thu, 15 Feb 2007 11:14:58 -0800 (PST) From: Davide Libenzi X-X-Sender: davide@alien.or.mcafeemobile.com To: Ingo Molnar cc: Linux Kernel Mailing List , Linus Torvalds , Arjan van de Ven , Christoph Hellwig , Andrew Morton , Alan Cox , Ulrich Drepper , Zach Brown , Evgeniy Polyakov , "David S. Miller" , Suparna Bhattacharya , Thomas Gleixner Subject: Re: [patch 08/14] syslets: x86, add create_async_thread() method In-Reply-To: <20070215165239.GI4285@elte.hu> Message-ID: References: <20070215165239.GI4285@elte.hu> X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 800 Lines: 27 On Thu, 15 Feb 2007, Ingo Molnar wrote: > +ENTRY(async_thread_helper) > + CFI_STARTPROC > + /* > + * Allocate space on the stack for pt-regs. > + * sizeof(struct pt_regs) == 64, and we've got 8 bytes on the > + * kernel stack already: > + */ > + subl $64-8, %esp > + CFI_ADJUST_CFA_OFFSET 64 Maybe a comment here would help in explaining why we do need space for the extra pt_regs (on top of the one already allocated in do_fork()) ;) It's not immediately clear that ret_from_fork and syscall_exit will issue two nested RESTORE_REGS. - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/