Received: by 2002:a05:6a10:7420:0:0:0:0 with SMTP id hk32csp3509734pxb; Sun, 20 Feb 2022 22:41:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMIV3JaDJmm3MjzKVro/EChL3/AaUuWTlvc/pJ7ZE+C0iTNcpG/F3iNwk4WLjY9zTBF/2G X-Received: by 2002:a05:6402:18:b0:410:86cd:9dce with SMTP id d24-20020a056402001800b0041086cd9dcemr19638057edu.70.1645425663561; Sun, 20 Feb 2022 22:41:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1645425663; cv=none; d=google.com; s=arc-20160816; b=T+rwAeU6Vj8j2dGcx0euyKwwzAfNTmtwZEwFp2hP7kyMShib8znRom8hXb2De7Fxaf eC1CDlzHvAFCacTPgvN8Fai6b3DoVYhNuK+YiP6Ib1It7qxgUs/QHcLxhlYveIteIW6L vMQyWLJvEpWgUa6nVWfOoMQo9zqyUmvhAki5aK0Zgq0nRvVY7ZGCdPCFNuqyD8AyO82j CKSCywNYly/HV8X/zhkoOdSPdcgffHrJlIx1RHJpzIbbsOELkv/PrOvMCbQM0vrVsxfA G0mepRjge9LDySVBemXGtauelpy+svIL+uD7jDD1o2n6cmb5DlNNDwRMkkjqJiP99ZNP BsAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=SS3hGxnh4cHL1gbKhDYEfo7VJuhyC7ByBQMHwy7VEe0=; b=OzSG5xecJ05lBPYwvYGXQlmr5Gwv7Ft+lBOn5yGsmKRdKPTAYnXva+yQx8IHNQYYFR GCmc5IeXiCPOJCgTMZW7h1OXM/SWpmMfN2t8QAVt+lCGjY37yAGiK85u+PkpNkIGQ+Pp 5NYWuZP/R63yhvN/e4xS8lAkOYhx2lep6jAv/wgg2ukbygQKbi4znZvcQRCWfSx0f7nl 3RiBseDUt8NbUwkOasAiZGJglsCLnXyTYTOZ9qUBd3Iym0wRkK7jcxa7tXrDrpXcaPKh 5qSCJFKWIPKu/RoLNEFaW+NmJ9P/yAKh5gBHxuNq1uYgtRvWh1/F+UmgmHPfdKN+vPm1 5e6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="W/9pl3vD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i3si9502720ejw.323.2022.02.20.22.40.41; Sun, 20 Feb 2022 22:41:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="W/9pl3vD"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242709AbiBSRkF (ORCPT + 99 others); Sat, 19 Feb 2022 12:40:05 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:53206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233433AbiBSRkE (ORCPT ); Sat, 19 Feb 2022 12:40:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E0C01B3721; Sat, 19 Feb 2022 09:39:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2462C60C02; Sat, 19 Feb 2022 17:39:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D769C004E1; Sat, 19 Feb 2022 17:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645292384; bh=q5vh7Hqz0EWyZEaGmusptGwSRgqiKYCYOveZSVUl/ow=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W/9pl3vD1a8QnuF3UG/Sxx/VyNR2UaSZj0UwlZ+yyvDdYA0mxVjq7HAaX6MRKmYwx 3ynbnQ/9UcJJ3JjWfzXlKwZlB2hhjF1OP+1e72ApwENGdK0HXARDPZfRYq/ZMpc2WN VBeVmiTkxq4qEcdDhxUTO6E2nrz/VXhX6t/TSr7F2ZZhCCrlWj2QM7vYy1LUB8WvEo L/j6Fu5jJCr/JHpgZpTjt4ISLK8vomkWdszJ/zSE27TlTYEaB2uXQCyP7kVNYoxLW0 nLDoNGrFAXpeYHno9sWAWxzvTlivB9gRaTxmEGfJw56841KX8Hcdd0ZfyMoANJeWQa YKGiHA530npQw== Date: Sat, 19 Feb 2022 17:46:31 +0000 From: Jonathan Cameron To: LI Qingwu Cc: lars@metafoo.de, robh+dt@kernel.org, tomas.melin@vaisala.com, andy.shevchenko@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, bsp-development.geo@leica-geosystems.com Subject: Re: [PATCH V2 0/5] iio: accel: sca3300: add compitible for scl3300 Message-ID: <20220219174631.29c56207@jic23-huawei> In-Reply-To: <20220217062705.2867149-1-Qing-wu.Li@leica-geosystems.com.cn> References: <20220217062705.2867149-1-Qing-wu.Li@leica-geosystems.com.cn> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Feb 2022 06:27:00 +0000 LI Qingwu wrote: > The current driver support sca3300 only. > Modifed for support SCL3300. > Verifed with SCL3300 on IMX8MM. > Splited the change for review. > > Same as sca3300, scl3300 have 3-axis acceleration,and temperature. > Different with sca3300, it can output inclination data directly. > The change add the support with scl3300, support inclination data output. > > Change in V2: > Drop the extra interface for set/get opration mode. > Drop the interface for enalbe/disable inclination output, > set inclination output is alwasy on. > Fix the findings in V1. Please run a spell checker on cover letters / patch descriptions. Though as people who follow IIO patches will probably note, I often forget myself and have sent some completely unreadable messages as a result! One of those do as I say, not as I do requests :) Jonathan > > LI Qingwu (5): > dt-bindings: iio: accel: sca3300: Document murata,scl3300 > iio: accel: sca3300: add define for temp channel for reuse. > iio: accel: sca3300: modified to support multi chips > iio: accel: sca3300: Add support for SCL3300 > iio: accel: sca3300: Add inclination channels. > > .../bindings/iio/accel/murata,sca3300.yaml | 1 + > drivers/iio/accel/sca3300.c | 271 ++++++++++++++---- > 2 files changed, 222 insertions(+), 50 deletions(-) >